From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF3F5C54EE9 for ; Tue, 13 Sep 2022 09:12:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B51D6B0078; Tue, 13 Sep 2022 05:12:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5644D6B007B; Tue, 13 Sep 2022 05:12:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 405B76B007D; Tue, 13 Sep 2022 05:12:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 32E336B0078 for ; Tue, 13 Sep 2022 05:12:37 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 08946C0293 for ; Tue, 13 Sep 2022 09:12:37 +0000 (UTC) X-FDA: 79906496754.08.58C181A Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf25.hostedemail.com (Postfix) with ESMTP id C5D07A00C3 for ; Tue, 13 Sep 2022 09:12:36 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id s18so5225068plr.4 for ; Tue, 13 Sep 2022 02:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date; bh=RludiuXI04g98bb6hCOo/Y+uQHagYxl6mhzM1wptlJE=; b=ZziSErcgXFTobtgN4y5qbgv8tURNEb5sxc0isyqeQJfLoU0RVzXarfIlNoeDn5ElEx l8gU5Xg2lvH0gIdizMMxc0mXyNlZJnn92OaJNh6aJdoe8Qf+EtKJz1nFD+Kdy96RVfSl EtJBEV9RCQrEydMLHeBhCUKUVSvkGeGfWU1cQXw0ghtjLKRiuxq00frbiw6pAKvomMBT FDg/8PJotaxvkLOYrix15q3LSA9jyJN/Ot++L4/Tx8+9GhOqtlTM/3myg+YkyOZ7+OTp 6kZwlU3F5WjuWtZYCvGk3HfP8dOw2inqKcgsVGJqnd5GoDycJbIzD8ZhsTH0mfqxULTC 2//Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=RludiuXI04g98bb6hCOo/Y+uQHagYxl6mhzM1wptlJE=; b=ANSXpxxaCSn2a+RZ3k6AFoF0Ucerrh3zBWVNy1kKpmCYr7gfJCllHfgJ+e/xYKzL/p JsKfh7K9olLjoXa5gyX+lq0CpwXn9nHT3fsEPn2xrfLt9kJCP6yHp8r+2BMqo3Si+f6b 4kcGKiHempuE25/WRengfDRtIsZtrpwJM3VdcbCye6i6hmNOKA2XRGVR7O3dI4Xe9L0b Jj+dgyKFgTI2BIfkylt9nJFf/eKO5/YgAxA2YQ+tdSSWYWtr/q09HTwkBr28q+NEdTUQ qevv7bTPu2YTg569z+QsVf8tKZUeblVXgaNThsK5CCP5beb+s1WIbOQAYXByZUKeDJD9 7YDQ== X-Gm-Message-State: ACgBeo2v2HPCK9kwoSR+FziqWmZIgV9GgB8uqChtfEJrIL6rANjkQSjQ PYarxXEC+tHiTeE237E/uA== X-Google-Smtp-Source: AA6agR5fkOMWeikIf2G4s+cnzgehLhSEMVAMumnMknm+iaDNywQoKQy3BUN6M0oQGYLVlkC5XlHvHg== X-Received: by 2002:a17:903:22c9:b0:178:18a1:d170 with SMTP id y9-20020a17090322c900b0017818a1d170mr17125135plg.2.1663060355904; Tue, 13 Sep 2022 02:12:35 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.3]) by smtp.gmail.com with ESMTPSA id h10-20020a170902680a00b0015e8d4eb1d5sm7804661plk.31.2022.09.13.02.12.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2022 02:12:35 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH 4/4] mm/damon/vaddr: indicate the target is invalid when 'nr_regions' is zero Date: Tue, 13 Sep 2022 17:11:27 +0800 Message-Id: <1663060287-30201-5-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> References: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663060356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=RludiuXI04g98bb6hCOo/Y+uQHagYxl6mhzM1wptlJE=; b=5x6GFqgF09JdhDi/TsoYD//6sJnsiYXkMfJOAF/FLaBnvLqgGSq/1p1BkfGwQRObAVsLAN yRgqQ1yZzT4Y9+im/XBq6W30aVhneYl2m0oUdW61lSorN76PqYMrqG2EuG8DjO9UBDTfdx hKV2LVhVLCDnFFVN+o1Wxd5GS8c3yTY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZziSErcg; spf=pass (imf25.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663060356; a=rsa-sha256; cv=none; b=kzyHWh24VUJPZ9ScFioSVBW1yEsZ2+8Lh5LCpls/am4SLrniAkZl0ChpB0yFHJ5x4ZiF7n HHArH9kQiiI//skMyy8XdzL7DcJUYNyCb6OiH6lWR+SsQtI36PYzevR2lx8P+HU/HCBQUf HhFEIB/wluBT813ZVrPWTzqpvhYFRSo= X-Stat-Signature: dfnssi6brr6wdrscmd8z77p8t6p4whbz X-Rspamd-Queue-Id: C5D07A00C3 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZziSErcg; spf=pass (imf25.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1663060356-938099 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kaixu Xia When 'init()' and 'update()' DAMON operations failed and the number of the damon_target regions is zero, the kdamond would do nothing to this monitoring target in this case. It makes no sense to run kdamond when all of monitoring targets have no regions. So add the judgement in 'target_valid()' operation to indicate the target is invalid when 'nr_regions' is zero. Signed-off-by: Kaixu Xia --- mm/damon/vaddr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index 39ea48d9cc15..65ff98d49ec0 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -598,6 +598,9 @@ static bool damon_va_target_valid(void *target) struct damon_target *t = target; struct task_struct *task; + if (!damon_nr_regions(t)) + return false; + task = damon_get_task_struct(t); if (task) { put_task_struct(task); -- 2.27.0