From: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Zhaoyang Huang <huangzhaoyang@gmail.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <ke.wang@unisoc.com>
Subject: [PATCHv2] mm: No need to check pcp page when free it to buddy
Date: Thu, 15 Sep 2022 10:40:54 +0800 [thread overview]
Message-ID: <1663209654-14727-1-git-send-email-zhaoyang.huang@unisoc.com> (raw)
From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
The pages on pcp list have been checked the validity via bellowing call chain.
It is no need to check it again when free them back to buddy by free_pcppages_bulk.
free_unref_page\free_unref_page_list
{
...
//page's validity is checked here
if (!free_unref_page_prepare(page, pfn, order))
return;
...
//page added to pcp->lists and status is ready for moving to buddy
list_add(&page->lru, &pcp->lists[pindex]);
Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
---
v2: update code and comment for clarifying
---
---
mm/page_alloc.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index e008a3d..1472ebc 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1420,14 +1420,6 @@ static bool free_pcp_prepare(struct page *page, unsigned int order)
{
return free_pages_prepare(page, order, true, FPI_NONE);
}
-
-static bool bulkfree_pcp_prepare(struct page *page)
-{
- if (debug_pagealloc_enabled_static())
- return check_free_page(page);
- else
- return false;
-}
#else
/*
* With DEBUG_VM disabled, order-0 pages being freed are checked only when
@@ -1442,11 +1434,6 @@ static bool free_pcp_prepare(struct page *page, unsigned int order)
else
return free_pages_prepare(page, order, false, FPI_NONE);
}
-
-static bool bulkfree_pcp_prepare(struct page *page)
-{
- return check_free_page(page);
-}
#endif /* CONFIG_DEBUG_VM */
/*
@@ -1512,9 +1499,6 @@ static void free_pcppages_bulk(struct zone *zone, int count,
count -= nr_pages;
pcp->count -= nr_pages;
- if (bulkfree_pcp_prepare(page))
- continue;
-
/* MIGRATE_ISOLATE page should not go to pcplists */
VM_BUG_ON_PAGE(is_migrate_isolate(mt), page);
/* Pageblock could have been isolated meanwhile */
--
1.9.1
next reply other threads:[~2022-09-15 2:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 2:40 zhaoyang.huang [this message]
2022-09-15 22:05 ` [PATCHv2] mm: No need to check pcp page when free it to buddy Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1663209654-14727-1-git-send-email-zhaoyang.huang@unisoc.com \
--to=zhaoyang.huang@unisoc.com \
--cc=akpm@linux-foundation.org \
--cc=huangzhaoyang@gmail.com \
--cc=ke.wang@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).