Re: [PATCH v7 00/21] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool

[Alex Shi <seakeel@gmail.com>]

On 9/5/24 4:04 AM, Vishal Moola wrote:
> On Wed, Sep 04, 2024 at 02:54:14PM +0800, Alex Shi wrote:
>>
>>
>> On 9/2/24 3:21 PM, alexs@kernel.org wrote:
>>> From: Alex Shi <alexs@kernel.org>
>>>
>> ...
>>
>>>
>>> This patchset abstracts the memory descriptor used in zsmalloc by zswap/zram.
>>> The descriptor still overlays the struct page; nothing has changed
>>> in that regard. What this patchset accomplishes is the use of folios in
>>> to save some code size, and the introduction of a new concept, zpdesc. 
>>> This patchset is just an initial step; it does not bias the potential 
>>> changes to kmem_alloc or larger zspage modifications.
>>>
>> ...
>>>
>>> Thanks a lot for comments and suggestion from Yosry, Yoo, Sergey, Willy
>>> and Vishal!
>>>
>>
>> This patchset could save 6.3% code size, and it's a nice abstract of zsmalloc
>> memory usage.
>> Is there any more comments, or mind to give a reviewed-by?
> 
> Please CC me on future versions. Most of the zsmalloc conversions seem
> ok, but I'd hold off on further iterations of the descriptor patches until
> the maintainers decide on what/how this descriptor will be used
> (i.e. our end goals).

Thanks for your care.

Is there some places or some conversion should be changed?

btw, the descriptor is used now and could save a few code size. :)

Thanks