From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96EF7EE6422 for ; Thu, 12 Sep 2024 02:36:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1157B6B00AA; Wed, 11 Sep 2024 22:36:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09E796B00AC; Wed, 11 Sep 2024 22:36:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E59DF6B00B0; Wed, 11 Sep 2024 22:36:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C54016B00AA for ; Wed, 11 Sep 2024 22:36:55 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3FCEBAB17F for ; Thu, 12 Sep 2024 02:36:55 +0000 (UTC) X-FDA: 82554523590.13.67A3294 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by imf24.hostedemail.com (Postfix) with ESMTP id 5871318000F for ; Thu, 12 Sep 2024 02:36:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XfZxB3oT; spf=pass (imf24.hostedemail.com: domain of seakeel@gmail.com designates 209.85.167.173 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726108560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y3JUbu16VfQSd9QVqb7yoAZ12Rb7JByfojqzpqofCls=; b=lZfwNQFBOH5vaj3u4+/B13VaDWynRoUWcnBhYXiO4riRD+21gGMoVRyyLPcs3YY/+FHSYs zDnYL5Ni+iG0jf/BUfccVqCVhiGbqClbw14PlDkUWwNQoKBzv0oSNsGLLx+X4d6t7g1YgI UfgypR9Xmra83lEpn/RSOA935EQqD8E= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XfZxB3oT; spf=pass (imf24.hostedemail.com: domain of seakeel@gmail.com designates 209.85.167.173 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726108560; a=rsa-sha256; cv=none; b=AWefTgMohRgBBnFAFyTqLr25UHN+5bC2n0hn9FcVcl7kYd+JQpNMMhzzJrYtFbZ14W+El7 7I5XB/s5GbV8TFHdHc7b6fYTAP4wTFKUFVRd9TPQkDW/T50SxvstdqkV5lIhNF44SveOhb iMZk2MI3kpZ+zo6zr/JfLJwpaMVQlI8= Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3e0394bff51so240731b6e.2 for ; Wed, 11 Sep 2024 19:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726108612; x=1726713412; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y3JUbu16VfQSd9QVqb7yoAZ12Rb7JByfojqzpqofCls=; b=XfZxB3oT9jnuk0YOPm8bR6u8sgKhvVe1Nc2eeIpWWGyHzPlr7BojRC7sfgQ616bbDb 14bb+t23xG0nPKNsVkMmfJXxbN9GEjjbN4Z37UhIxOQM0wkBkx6cNhd25UlnictZkGQP mx0sfxxLyvf0gGbuytPQ/BZW20aIMa/pyKWizRrhXY1h7I4QFrHQV8QccIIwbsLVgIcP 7/2dpS2yfHnpKa3tLhFkQ+0nl0x9CXvQ+0Z1nT1Gj29aFipf2rUB034A7I1Z993ZEw70 qMcRQTSur8OhnuPcO7UIC/Vluze/RAvje1ckVcT+5CjWQLhqm8pXXVRRrXy+tSfPumXc VOOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726108612; x=1726713412; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y3JUbu16VfQSd9QVqb7yoAZ12Rb7JByfojqzpqofCls=; b=FAxOJS6NUf8Bvrj/qTP4x/md548Nh8IfytCj+jGLBSLEp68hF5voboSGCoc/Q+YhOo WCkm5ja95m9X6QvivEnLj2i/JtLCvSKcYPk3NCzZB23S/QojO1WXYYWXbkjBSB3MC+6v IQ8x8Vh9M2OkBApIf+GLRRy8NwA7M/rUun78thK9+8c++t0FTyoCrErG8cOan5G1Rt2W KsLKaQnMn6tlmfBUzgqjWOQwSvwnKsqQKo5GF0BdSz99BFqFzpQDrsGkVSrn4dGqWiBb farZ+PaHqzLo+izEi2ut37mft+hz8lyGtbRKmFG+Kt+nNLLHQSXszg4JCyXhia4oIK7y bE5Q== X-Forwarded-Encrypted: i=1; AJvYcCUHDpHcbodrK9cOdOVP8yoHxIHEucsBZVSdld7hFNCUDRiGize8PoF/q0YlCKhIuxYus9PLBjWEcQ==@kvack.org X-Gm-Message-State: AOJu0YxiWcLrekToFW++zUIEUtI9VbTO9TJmQAGEOyTCYD3k0i3vbELN 7TsAzrlL+7ZAR0+rFV46Q3G5DZU/Riq7PVCM5V7BRcLjyoqP9gf/MI/wdkpkQ+s= X-Google-Smtp-Source: AGHT+IE8jJbwto1D6atTHvUw6MoZSBz0Mbq4oirenkf3ludI59+GenOLwEMtKNX/Mxh9AiLM/nU6OA== X-Received: by 2002:a17:903:2347:b0:205:8610:3e3c with SMTP id d9443c01a7336-2076e30652amr21113025ad.9.1726108117938; Wed, 11 Sep 2024 19:28:37 -0700 (PDT) Received: from [192.168.255.10] (23.105.223.42.16clouds.com. [23.105.223.42]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2076b009867sm5533135ad.296.2024.09.11.19.28.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Sep 2024 19:28:37 -0700 (PDT) Message-ID: <1691f16c-af41-4b38-bd5e-38af0e7a2c99@gmail.com> Date: Thu, 12 Sep 2024 10:28:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 00/21] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool To: Vishal Moola Cc: alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com References: <20240902072136.578720-1-alexs@kernel.org> <0a10e61b-f0e6-4423-996c-7884c93af65f@gmail.com> <66d8bd3e.170a0220.18832.0206@mx.google.com> Content-Language: en-US From: Alex Shi In-Reply-To: <66d8bd3e.170a0220.18832.0206@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 5871318000F X-Stat-Signature: 8hbw1auqkk8okwqyy14nt1mcpy4wzni9 X-HE-Tag: 1726108613-86006 X-HE-Meta: U2FsdGVkX1+m5Xkc5HlxG/jA5YF0/Qj1K0LD1Xnjbc/XDqYyzN10BZMNK+ZLvHiWbHt8A3QoScGhKan4kXFI6A5MxPJORvt/odx2iPXwi768c3jreCzEx9WWS8TrX9GpYCpjldk9bO9x1EzzCQG/TU3AG5zaohMtroD1GAiDdNqh1Fe2lb3eEyGJ7R8TWU79+6e6wfweEOsUU3BxFwWE2Zp8zTBj8ttfTuMO4P/jrBkpC2pnRPk2vqRnJpvyg3o3MEDkRtCRqx0BMUO3r7EE6OAqVnPhJXPoX+NB4JQhInN7sUoNIXi+b9Mul/BexMzJdmm/JRO2spFm10NrJwZMIzdrzQf2Eyr5OWnmOsnPxwtohRIlFpHD42lEx7KlOj8KtgYVfGtHWaT2XGdRpRC08Asc1VqWx0unwbx+kqZoThTocuM/RzSn87JZZO8iscF4NndZOMdKFH0ovl3v6EkCL9mVwbZj7Wc17m4qo5JI2Di2ESpKrgYfPudqHmbhW1TcGMsO1RxpX5xuRj50SGsmsU0e07il2sOH9YLwQYuqZuMwrScPOC5lvC/O8lDAZ6rKarJFN3cqnum1yUkfA00EK1xl/ls3MuFq8BZPny3OVeQ2i7OGh+kLIvNDUXOKUoybBgtYuwuo6Pnc2fEFU1eyfzJP5oxcqQo/hsnEOy/iZ3h9WJxk60uEwXIu+TtN9Vbff8zO/3oMXRJ45NkPuYIuwKgxGclrc7gb7D+pYSpl1F1dCK5TE7qr1CIcn1lZlok18Tmeovpclo34ml160qmDENd44ddV/pQTVM6uIdQc3KYaNxDvtT45gWxCfQvtaPX1W5Uh3Yu4nPhp2tOsHYD8uXTluIMsBY+jUSwS9E91aSEbsNqWPcbOWSY+YVm0oqfSljJoBy3EOYv/xZPDWRepkmZ1t/tzcg7gpc90HsTYuZGX64qq/tj+2cC8cx6y3YQcWC8w5++sf3cxE8M2YoW 98ysEhar SglhHyhM6KzgJy9qjAxdSBu3bcwzgGAeS1tEIA6docnB+SGdwvg1lbJ2Jlbkxce4wvUmQzoil/FUg81yGxbheE0gqFQox+VbNIu771EkCsNwpg+EtknRcXAkBlUC/xfZpysos6OPGjCgX0Q4SW8uMLWPqf/lKaE4kDEaJoq55MvCdCAn/RAYKVUVo9IOa5CaYvZ4B+6/LFitGnjQDRPMFNqdA90BDj7yVNh0G+GEdxGIvki9nFmiJJNJZNTlkLy4DkItqCMlCxndolmkg+eyHpyxissuESbO/dU+eJRib9EraHJjnRADEaOvAZPY4jQ5gCsoTxbg5KeIuyPgEokpEr0cjRBJahyOKKycrfTTqbCbbRpRamEs3VRIZIDNW+w/mSlVxxX0Dehjp7U0r2VVXSrhyISNW1VfrnFRJid0xX9v41tfFbCfadCeKfriUPSpN3ZKiaEZRHpVYcn1PTCPCMtIfTUFi//mfFeSLJc93EJRzXrdItOde7wWKBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/5/24 4:04 AM, Vishal Moola wrote: > On Wed, Sep 04, 2024 at 02:54:14PM +0800, Alex Shi wrote: >> >> >> On 9/2/24 3:21 PM, alexs@kernel.org wrote: >>> From: Alex Shi >>> >> ... >> >>> >>> This patchset abstracts the memory descriptor used in zsmalloc by zswap/zram. >>> The descriptor still overlays the struct page; nothing has changed >>> in that regard. What this patchset accomplishes is the use of folios in >>> to save some code size, and the introduction of a new concept, zpdesc. >>> This patchset is just an initial step; it does not bias the potential >>> changes to kmem_alloc or larger zspage modifications. >>> >> ... >>> >>> Thanks a lot for comments and suggestion from Yosry, Yoo, Sergey, Willy >>> and Vishal! >>> >> >> This patchset could save 6.3% code size, and it's a nice abstract of zsmalloc >> memory usage. >> Is there any more comments, or mind to give a reviewed-by? > > Please CC me on future versions. Most of the zsmalloc conversions seem > ok, but I'd hold off on further iterations of the descriptor patches until > the maintainers decide on what/how this descriptor will be used > (i.e. our end goals). Thanks for your care. Is there some places or some conversion should be changed? btw, the descriptor is used now and could save a few code size. :) Thanks