* [linux-next:master 4291/4370] kernel/gcov/gcc_4_7.c:162:9: error: implicit declaration of function 'within_module'; did you mean 'init_module'?
@ 2019-03-29 8:06 kbuild test robot
2019-03-29 17:45 ` [PATCH] gcov: include linux/module.h for within_module Nick Desaulniers
0 siblings, 1 reply; 11+ messages in thread
From: kbuild test robot @ 2019-03-29 8:06 UTC (permalink / raw)
To: Greg Hackmann
Cc: kbuild-all, Nick Desaulniers, Tri Vo, Peter Oberparleiter,
Andrew Morton, Linux Memory Management List
[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 1baf02ec984b88b435e2fa065300179a3f48e7d2
commit: 8c3d220cb6b5f502745285106154bad632f43b15 [4291/4370] gcov: clang support
config: x86_64-randconfig-a0-03291513 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 8c3d220cb6b5f502745285106154bad632f43b15
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
kernel/gcov/gcc_4_7.c: In function 'gcov_info_within_module':
>> kernel/gcov/gcc_4_7.c:162:9: error: implicit declaration of function 'within_module'; did you mean 'init_module'? [-Werror=implicit-function-declaration]
return within_module((unsigned long)info, mod);
^~~~~~~~~~~~~
init_module
cc1: some warnings being treated as errors
vim +162 kernel/gcov/gcc_4_7.c
152
153 /**
154 * gcov_info_within_module - check if a profiling data set belongs to a module
155 * @info: profiling data set
156 * @mod: module
157 *
158 * Returns true if profiling data belongs module, false otherwise.
159 */
160 bool gcov_info_within_module(struct gcov_info *info, struct module *mod)
161 {
> 162 return within_module((unsigned long)info, mod);
163 }
164
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33213 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH] gcov: include linux/module.h for within_module
2019-03-29 8:06 [linux-next:master 4291/4370] kernel/gcov/gcc_4_7.c:162:9: error: implicit declaration of function 'within_module'; did you mean 'init_module'? kbuild test robot
@ 2019-03-29 17:45 ` Nick Desaulniers
2019-03-29 18:01 ` Randy Dunlap
0 siblings, 1 reply; 11+ messages in thread
From: Nick Desaulniers @ 2019-03-29 17:45 UTC (permalink / raw)
To: oberpar, akpm
Cc: Nick Desaulniers, Greg Hackmann, Tri Vo, linux-mm, kbuild-all,
kbuild test robot, linux-kernel
Fixes commit 8c3d220cb6b5 ("gcov: clang support")
Cc: Greg Hackmann <ghackmann@android.com>
Cc: Tri Vo <trong@android.com>
Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
Cc: linux-mm@kvack.org
Cc: kbuild-all@01.org
Reported-by: kbuild test robot <lkp@intel.com>
Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
kernel/gcov/gcc_3_4.c | 1 +
kernel/gcov/gcc_4_7.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/kernel/gcov/gcc_3_4.c b/kernel/gcov/gcc_3_4.c
index 801ee4b0b969..0eda59ef57df 100644
--- a/kernel/gcov/gcc_3_4.c
+++ b/kernel/gcov/gcc_3_4.c
@@ -16,6 +16,7 @@
*/
#include <linux/errno.h>
+#include <linux/module.h>
#include <linux/slab.h>
#include <linux/string.h>
#include <linux/seq_file.h>
diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
index ec37563674d6..677851284fe2 100644
--- a/kernel/gcov/gcc_4_7.c
+++ b/kernel/gcov/gcc_4_7.c
@@ -13,6 +13,7 @@
*/
#include <linux/errno.h>
+#include <linux/module.h>
#include <linux/slab.h>
#include <linux/string.h>
#include <linux/seq_file.h>
--
2.21.0.392.gf8f6787159e-goog
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] gcov: include linux/module.h for within_module
2019-03-29 17:45 ` [PATCH] gcov: include linux/module.h for within_module Nick Desaulniers
@ 2019-03-29 18:01 ` Randy Dunlap
2019-03-29 18:08 ` Randy Dunlap
2019-03-29 18:09 ` Nick Desaulniers
0 siblings, 2 replies; 11+ messages in thread
From: Randy Dunlap @ 2019-03-29 18:01 UTC (permalink / raw)
To: Nick Desaulniers, oberpar, akpm
Cc: Greg Hackmann, Tri Vo, linux-mm, kbuild-all, kbuild test robot,
linux-kernel
On 3/29/19 10:45 AM, Nick Desaulniers wrote:
> Fixes commit 8c3d220cb6b5 ("gcov: clang support")
>
> Cc: Greg Hackmann <ghackmann@android.com>
> Cc: Tri Vo <trong@android.com>
> Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
> Cc: linux-mm@kvack.org
> Cc: kbuild-all@01.org
> Reported-by: kbuild test robot <lkp@intel.com>
> Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
see https://lore.kernel.org/linux-mm/20190328225107.ULwYw%25akpm@linux-foundation.org/T/#mee26c00158574326e807480fc39dfcbd7bebd5fd
Did you test this? kernel/gcov/gcc_4_7.c includes local "gcov.h",
which includes <linux/module.h>, so why didn't that work or why
does this patch work?
thanks.
> ---
> kernel/gcov/gcc_3_4.c | 1 +
> kernel/gcov/gcc_4_7.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/kernel/gcov/gcc_3_4.c b/kernel/gcov/gcc_3_4.c
> index 801ee4b0b969..0eda59ef57df 100644
> --- a/kernel/gcov/gcc_3_4.c
> +++ b/kernel/gcov/gcc_3_4.c
> @@ -16,6 +16,7 @@
> */
>
> #include <linux/errno.h>
> +#include <linux/module.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> #include <linux/seq_file.h>
> diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
> index ec37563674d6..677851284fe2 100644
> --- a/kernel/gcov/gcc_4_7.c
> +++ b/kernel/gcov/gcc_4_7.c
> @@ -13,6 +13,7 @@
> */
>
> #include <linux/errno.h>
> +#include <linux/module.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> #include <linux/seq_file.h>
>
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] gcov: include linux/module.h for within_module
2019-03-29 18:01 ` Randy Dunlap
@ 2019-03-29 18:08 ` Randy Dunlap
2019-03-29 18:09 ` Nick Desaulniers
1 sibling, 0 replies; 11+ messages in thread
From: Randy Dunlap @ 2019-03-29 18:08 UTC (permalink / raw)
To: Nick Desaulniers, oberpar, akpm
Cc: Greg Hackmann, Tri Vo, linux-mm, kbuild-all, kbuild test robot,
linux-kernel
On 3/29/19 11:01 AM, Randy Dunlap wrote:
> On 3/29/19 10:45 AM, Nick Desaulniers wrote:
>> Fixes commit 8c3d220cb6b5 ("gcov: clang support")
>>
>> Cc: Greg Hackmann <ghackmann@android.com>
>> Cc: Tri Vo <trong@android.com>
>> Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
>> Cc: linux-mm@kvack.org
>> Cc: kbuild-all@01.org
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
>> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> see https://lore.kernel.org/linux-mm/20190328225107.ULwYw%25akpm@linux-foundation.org/T/#mee26c00158574326e807480fc39dfcbd7bebd5fd
>
> Did you test this? kernel/gcov/gcc_4_7.c includes local "gcov.h",
> which includes <linux/module.h>, so why didn't that work or why
> does this patch work?
No, this patch does not fix the build error for me.
> thanks.
>
>> ---
>> kernel/gcov/gcc_3_4.c | 1 +
>> kernel/gcov/gcc_4_7.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/kernel/gcov/gcc_3_4.c b/kernel/gcov/gcc_3_4.c
>> index 801ee4b0b969..0eda59ef57df 100644
>> --- a/kernel/gcov/gcc_3_4.c
>> +++ b/kernel/gcov/gcc_3_4.c
>> @@ -16,6 +16,7 @@
>> */
>>
>> #include <linux/errno.h>
>> +#include <linux/module.h>
>> #include <linux/slab.h>
>> #include <linux/string.h>
>> #include <linux/seq_file.h>
>> diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
>> index ec37563674d6..677851284fe2 100644
>> --- a/kernel/gcov/gcc_4_7.c
>> +++ b/kernel/gcov/gcc_4_7.c
>> @@ -13,6 +13,7 @@
>> */
>>
>> #include <linux/errno.h>
>> +#include <linux/module.h>
>> #include <linux/slab.h>
>> #include <linux/string.h>
>> #include <linux/seq_file.h>
>>
>
>
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] gcov: include linux/module.h for within_module
2019-03-29 18:01 ` Randy Dunlap
2019-03-29 18:08 ` Randy Dunlap
@ 2019-03-29 18:09 ` Nick Desaulniers
2019-03-29 18:10 ` Randy Dunlap
1 sibling, 1 reply; 11+ messages in thread
From: Nick Desaulniers @ 2019-03-29 18:09 UTC (permalink / raw)
To: Randy Dunlap
Cc: Peter Oberparleiter, Andrew Morton, Greg Hackmann, Tri Vo,
Linux Memory Management List, kbuild-all, kbuild test robot, LKML
On Fri, Mar 29, 2019 at 11:01 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 3/29/19 10:45 AM, Nick Desaulniers wrote:
> > Fixes commit 8c3d220cb6b5 ("gcov: clang support")
> >
> > Cc: Greg Hackmann <ghackmann@android.com>
> > Cc: Tri Vo <trong@android.com>
> > Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
> > Cc: linux-mm@kvack.org
> > Cc: kbuild-all@01.org
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> see https://lore.kernel.org/linux-mm/20190328225107.ULwYw%25akpm@linux-foundation.org/T/#mee26c00158574326e807480fc39dfcbd7bebd5fd
>
> Did you test this?
Yes, built with gcc 7.3 and
defconfig
+
CONFIG_GCOV_KERNEL=y
CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y
CONFIG_GCOV_FORMAT_4_7=y
> kernel/gcov/gcc_4_7.c includes local "gcov.h",
> which includes <linux/module.h>, so why didn't that work or why
> does this patch work?
Good point. May be something in the configs from 0-day bot. Boarding
a plane for Bangkok, but can dig further once landed.
Maybe module support was disabled?
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] gcov: include linux/module.h for within_module
2019-03-29 18:09 ` Nick Desaulniers
@ 2019-03-29 18:10 ` Randy Dunlap
2019-03-29 18:18 ` [PATCH v2] gcov: fix when CONFIG_MODULES is not set Nick Desaulniers
0 siblings, 1 reply; 11+ messages in thread
From: Randy Dunlap @ 2019-03-29 18:10 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Peter Oberparleiter, Andrew Morton, Greg Hackmann, Tri Vo,
Linux Memory Management List, kbuild-all, kbuild test robot, LKML
On 3/29/19 11:09 AM, Nick Desaulniers wrote:
> On Fri, Mar 29, 2019 at 11:01 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 3/29/19 10:45 AM, Nick Desaulniers wrote:
>>> Fixes commit 8c3d220cb6b5 ("gcov: clang support")
>>>
>>> Cc: Greg Hackmann <ghackmann@android.com>
>>> Cc: Tri Vo <trong@android.com>
>>> Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
>>> Cc: linux-mm@kvack.org
>>> Cc: kbuild-all@01.org
>>> Reported-by: kbuild test robot <lkp@intel.com>
>>> Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
>>> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>>
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> see https://lore.kernel.org/linux-mm/20190328225107.ULwYw%25akpm@linux-foundation.org/T/#mee26c00158574326e807480fc39dfcbd7bebd5fd
>>
>> Did you test this?
>
> Yes, built with gcc 7.3 and
> defconfig
> +
> CONFIG_GCOV_KERNEL=y
> CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y
> CONFIG_GCOV_FORMAT_4_7=y
>
>> kernel/gcov/gcc_4_7.c includes local "gcov.h",
>> which includes <linux/module.h>, so why didn't that work or why
>> does this patch work?
>
> Good point. May be something in the configs from 0-day bot. Boarding
> a plane for Bangkok, but can dig further once landed.
>
> Maybe module support was disabled?
Yes, I reported the problem with CONFIG_MODULES not enabled.
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v2] gcov: fix when CONFIG_MODULES is not set
2019-03-29 18:10 ` Randy Dunlap
@ 2019-03-29 18:18 ` Nick Desaulniers
2019-03-29 20:53 ` Randy Dunlap
0 siblings, 1 reply; 11+ messages in thread
From: Nick Desaulniers @ 2019-03-29 18:18 UTC (permalink / raw)
To: oberpar, akpm
Cc: Nick Desaulniers, Greg Hackmann, Tri Vo, linux-mm, kbuild-all,
Randy Dunlap, kbuild test robot, linux-kernel
Fixes commit 8c3d220cb6b5 ("gcov: clang support")
Cc: Greg Hackmann <ghackmann@android.com>
Cc: Tri Vo <trong@android.com>
Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
Cc: linux-mm@kvack.org
Cc: kbuild-all@01.org
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kbuild test robot <lkp@intel.com>
Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
kernel/gcov/gcc_3_4.c | 4 ++++
kernel/gcov/gcc_4_7.c | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/kernel/gcov/gcc_3_4.c b/kernel/gcov/gcc_3_4.c
index 801ee4b0b969..8fc30f178351 100644
--- a/kernel/gcov/gcc_3_4.c
+++ b/kernel/gcov/gcc_3_4.c
@@ -146,7 +146,11 @@ void gcov_info_unlink(struct gcov_info *prev, struct gcov_info *info)
*/
bool gcov_info_within_module(struct gcov_info *info, struct module *mod)
{
+#ifdef CONFIG_MODULES
return within_module((unsigned long)info, mod);
+#else
+ return false;
+#endif
}
/* Symbolic links to be created for each profiling data file. */
diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
index ec37563674d6..0b6886d4a4dd 100644
--- a/kernel/gcov/gcc_4_7.c
+++ b/kernel/gcov/gcc_4_7.c
@@ -159,7 +159,11 @@ void gcov_info_unlink(struct gcov_info *prev, struct gcov_info *info)
*/
bool gcov_info_within_module(struct gcov_info *info, struct module *mod)
{
+#ifdef CONFIG_MODULES
return within_module((unsigned long)info, mod);
+#else
+ return false;
+#endif
}
/* Symbolic links to be created for each profiling data file. */
--
2.21.0.392.gf8f6787159e-goog
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2] gcov: fix when CONFIG_MODULES is not set
2019-03-29 18:18 ` [PATCH v2] gcov: fix when CONFIG_MODULES is not set Nick Desaulniers
@ 2019-03-29 20:53 ` Randy Dunlap
2019-03-30 23:57 ` Tri Vo
0 siblings, 1 reply; 11+ messages in thread
From: Randy Dunlap @ 2019-03-29 20:53 UTC (permalink / raw)
To: Nick Desaulniers, oberpar, akpm
Cc: Greg Hackmann, Tri Vo, linux-mm, kbuild-all, kbuild test robot,
linux-kernel
On 3/29/19 11:18 AM, Nick Desaulniers wrote:
> Fixes commit 8c3d220cb6b5 ("gcov: clang support")
There is a certain format for Fixes: and that's not quite it. :(
> Cc: Greg Hackmann <ghackmann@android.com>
> Cc: Tri Vo <trong@android.com>
> Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
> Cc: linux-mm@kvack.org
> Cc: kbuild-all@01.org
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kbuild test robot <lkp@intel.com>
> Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> kernel/gcov/gcc_3_4.c | 4 ++++
> kernel/gcov/gcc_4_7.c | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/kernel/gcov/gcc_3_4.c b/kernel/gcov/gcc_3_4.c
> index 801ee4b0b969..8fc30f178351 100644
> --- a/kernel/gcov/gcc_3_4.c
> +++ b/kernel/gcov/gcc_3_4.c
> @@ -146,7 +146,11 @@ void gcov_info_unlink(struct gcov_info *prev, struct gcov_info *info)
> */
> bool gcov_info_within_module(struct gcov_info *info, struct module *mod)
> {
> +#ifdef CONFIG_MODULES
> return within_module((unsigned long)info, mod);
> +#else
> + return false;
> +#endif
> }
>
> /* Symbolic links to be created for each profiling data file. */
> diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
> index ec37563674d6..0b6886d4a4dd 100644
> --- a/kernel/gcov/gcc_4_7.c
> +++ b/kernel/gcov/gcc_4_7.c
> @@ -159,7 +159,11 @@ void gcov_info_unlink(struct gcov_info *prev, struct gcov_info *info)
> */
> bool gcov_info_within_module(struct gcov_info *info, struct module *mod)
> {
> +#ifdef CONFIG_MODULES
> return within_module((unsigned long)info, mod);
> +#else
> + return false;
> +#endif
> }
>
> /* Symbolic links to be created for each profiling data file. */
>
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] gcov: fix when CONFIG_MODULES is not set
2019-03-29 20:53 ` Randy Dunlap
@ 2019-03-30 23:57 ` Tri Vo
2019-04-02 2:54 ` Nick Desaulniers
0 siblings, 1 reply; 11+ messages in thread
From: Tri Vo @ 2019-03-30 23:57 UTC (permalink / raw)
To: Randy Dunlap
Cc: Nick Desaulniers, Peter Oberparleiter, Andrew Morton,
Greg Hackmann, linux-mm, kbuild-all, kbuild test robot, LKML
On Fri, Mar 29, 2019 at 1:53 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 3/29/19 11:18 AM, Nick Desaulniers wrote:
> > Fixes commit 8c3d220cb6b5 ("gcov: clang support")
>
> There is a certain format for Fixes: and that's not quite it. :(
>
> > Cc: Greg Hackmann <ghackmann@android.com>
> > Cc: Tri Vo <trong@android.com>
> > Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
> > Cc: linux-mm@kvack.org
> > Cc: kbuild-all@01.org
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
>
> Thanks.
>
> > ---
> > kernel/gcov/gcc_3_4.c | 4 ++++
> > kernel/gcov/gcc_4_7.c | 4 ++++
> > 2 files changed, 8 insertions(+)
Thanks for taking a look at this Nick! I believe same fix should be
applied to kernel/gcov/clang.c. I'll send out an updated version later
today.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] gcov: fix when CONFIG_MODULES is not set
2019-03-30 23:57 ` Tri Vo
@ 2019-04-02 2:54 ` Nick Desaulniers
2019-04-03 15:24 ` Matthew Wilcox
0 siblings, 1 reply; 11+ messages in thread
From: Nick Desaulniers @ 2019-04-02 2:54 UTC (permalink / raw)
To: Tri Vo
Cc: Randy Dunlap, Peter Oberparleiter, Andrew Morton, Greg Hackmann,
Linux Memory Management List, kbuild-all, kbuild test robot, LKML
On Sun, Mar 31, 2019 at 6:57 AM Tri Vo <trong@android.com> wrote:
>
> On Fri, Mar 29, 2019 at 1:53 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > On 3/29/19 11:18 AM, Nick Desaulniers wrote:
> > > Fixes commit 8c3d220cb6b5 ("gcov: clang support")
> >
> > There is a certain format for Fixes: and that's not quite it. :(
Looks like the format is:
Fixes: <first 12 characters of commit sha> ("<first line of commit>")
so:
Fixes: 8c3d220cb6b5 ("gcov: clang support")
We should update:
https://www.kernel.org/doc/html/v5.0/process/stable-kernel-rules.html
to include this information.
> Thanks for taking a look at this Nick! I believe same fix should be
> applied to kernel/gcov/clang.c. I'll send out an updated version later
> today.
All yours, happy to review.
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] gcov: fix when CONFIG_MODULES is not set
2019-04-02 2:54 ` Nick Desaulniers
@ 2019-04-03 15:24 ` Matthew Wilcox
0 siblings, 0 replies; 11+ messages in thread
From: Matthew Wilcox @ 2019-04-03 15:24 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Tri Vo, Randy Dunlap, Peter Oberparleiter, Andrew Morton,
Greg Hackmann, Linux Memory Management List, kbuild-all,
kbuild test robot, LKML
On Tue, Apr 02, 2019 at 09:54:50AM +0700, Nick Desaulniers wrote:
> Looks like the format is:
> Fixes: <first 12 characters of commit sha> ("<first line of commit>")
> so:
> Fixes: 8c3d220cb6b5 ("gcov: clang support")
>
> We should update:
> https://www.kernel.org/doc/html/v5.0/process/stable-kernel-rules.html
> to include this information.
It's in Documentation/process/submitting-patches.rst already.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-04-03 15:24 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-29 8:06 [linux-next:master 4291/4370] kernel/gcov/gcc_4_7.c:162:9: error: implicit declaration of function 'within_module'; did you mean 'init_module'? kbuild test robot
2019-03-29 17:45 ` [PATCH] gcov: include linux/module.h for within_module Nick Desaulniers
2019-03-29 18:01 ` Randy Dunlap
2019-03-29 18:08 ` Randy Dunlap
2019-03-29 18:09 ` Nick Desaulniers
2019-03-29 18:10 ` Randy Dunlap
2019-03-29 18:18 ` [PATCH v2] gcov: fix when CONFIG_MODULES is not set Nick Desaulniers
2019-03-29 20:53 ` Randy Dunlap
2019-03-30 23:57 ` Tri Vo
2019-04-02 2:54 ` Nick Desaulniers
2019-04-03 15:24 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).