public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: David Hildenbrand <david@redhat.com>, Andy Lutomirski <luto@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Peter Xu <peterx@redhat.com>,
	Axel Rasmussen <axelrasmussen@google.com>
Subject: Re: [PATCH] x86/fault: speed up uffd-unit-test by 10x: rate-limit "MCE: Killing" logs
Date: Tue, 7 May 2024 09:53:34 -0700	[thread overview]
Message-ID: <16ab2040-9d99-41b8-8b9d-39b0753533c6@nvidia.com> (raw)
In-Reply-To: <21d88422-7378-4a63-8fbf-f70889f309c1@redhat.com>

On 5/7/24 9:43 AM, David Hildenbrand wrote:
> On 07.05.24 18:28, John Hubbard wrote:
>> On 5/7/24 1:13 AM, David Hildenbrand wrote:
...
>> I'd like to just do this patch almost as-is, just with a fixed up 
>> subject,
>> perhaps:
>>
>>       x86/fault: rate-limit to avoid flooding dmesg with "MCE: Killing"
>> reports
>>
>> Yes?
> 
> 
> Makes sense to me (and thanks for confirming that we don't need 
> complexity elsewhere).
> 
> I think we at least need "Fixes:" (not sure if stable is warranted as 
> well, 1b0a151c10a6d823f033023b9fdd9af72a89591b didn't CC stable).
> 
> Consider adding a link to the report in that thread.
> 
> Acked-by: David Hildenbrand <david@redhat.com>
> 

OK, there's enough changes to the commit description that I'll go ahead
and send a v2, with a new subject line, a Fixes:, your Ack, a link to
the other conversation, and maybe reword a bit based on your feedback
too.

Thanks for the review and the Ack!

thanks,
-- 
John Hubbard
NVIDIA



  reply	other threads:[~2024-05-07 16:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-07  2:29 [PATCH] x86/fault: speed up uffd-unit-test by 10x: rate-limit "MCE: Killing" logs John Hubbard
2024-05-07  8:13 ` David Hildenbrand
2024-05-07 16:28   ` John Hubbard
2024-05-07 16:43     ` David Hildenbrand
2024-05-07 16:53       ` John Hubbard [this message]
2024-05-07 16:55         ` David Hildenbrand
2024-05-07 18:08       ` Axel Rasmussen
2024-05-07 18:10         ` John Hubbard
2024-05-07 18:15           ` Axel Rasmussen
2024-05-07 22:49             ` John Hubbard
2024-05-07 19:26 ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16ab2040-9d99-41b8-8b9d-39b0753533c6@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=axelrasmussen@google.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterx@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox