From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1C85C43334 for ; Tue, 7 Jun 2022 12:59:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54A108D0003; Tue, 7 Jun 2022 08:59:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D1818D000E; Tue, 7 Jun 2022 08:59:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3576C8D0003; Tue, 7 Jun 2022 08:59:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1E8318D0003 for ; Tue, 7 Jun 2022 08:59:50 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D4F4A32AEA for ; Tue, 7 Jun 2022 12:59:49 +0000 (UTC) X-FDA: 79551446898.08.F61582F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id C52C7A0062 for ; Tue, 7 Jun 2022 12:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654606788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lLkIExdSAfZXhKlnnfUm2v8chK83vx8JP1WYxXIWoTk=; b=QGfferDzUOKCu4jgL8TvWAj1ObsAuuU6a42CjdW6SSxKIfoiFegmQ/Aqz/jw36GPu/s5Ow J3Q8w/OOLlZas7T/5TnDiT0DwuYlBdP/i71IHBOuM9NDikt+mxO0RWSPwhcP2dr+Gg3KJe tVLewkCjKlsHsQWkNrHe2MwHSXdxuNo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-549-ck-YzaRBM4earaj4ulxMBg-1; Tue, 07 Jun 2022 08:59:47 -0400 X-MC-Unique: ck-YzaRBM4earaj4ulxMBg-1 Received: by mail-wr1-f71.google.com with SMTP id t2-20020adfe442000000b002108370e7a3so3868048wrm.3 for ; Tue, 07 Jun 2022 05:59:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=lLkIExdSAfZXhKlnnfUm2v8chK83vx8JP1WYxXIWoTk=; b=3FL2rmzYajHQJbQNusUavZ/kgB+x+gPVk1BGogvI/PpjWi3QSoGjzQ4r/UBlfAcHIc xE6mXTuMSorVSuYmxq8Y+XjuNHaZ9RgcZtMkTk1DL1e4qwZvgEBK0IKtJtRjB9XuqQ35 LkRKJqyZBdkLffg/+p4X8wkx1FIDwuDre5v5a8zj127Z6ByLoCTja+QNOjwX/iK64+rC d6aXBc+k63kRqlbBW5TDan1vBAEG/4VTjeppsTXmw8H/L8b3VqiuxZJy3Lnu4/LjIvOl 02tPapmKWLK0raV8yqC36zURkgq4JxHlHPNP06zQDa6VwXWRUH0dTUms0sCCgaCpBk3M 19Fg== X-Gm-Message-State: AOAM5325XDD3PtIsPzHlYYkRWm102zsTy7Fmy3LSe+6EhIUb0y9LRmO8 S5c/nk8/1iO5Sh4MV/LrM/6BkuJhHB6LsOFGfg3kOF9wH+RMb3IHzwT/mB8QCC5g0AQ6rp64DKR aQxCOmbif6iQ= X-Received: by 2002:a05:600c:154d:b0:394:880f:ae3a with SMTP id f13-20020a05600c154d00b00394880fae3amr57162983wmg.13.1654606786071; Tue, 07 Jun 2022 05:59:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqobIROp0frQyRbHeDBQX0/wyK9D7b9XqZKUc3BVsApHVxTT80upGqI6zMshvJq/DgrW/pbQ== X-Received: by 2002:a05:600c:154d:b0:394:880f:ae3a with SMTP id f13-20020a05600c154d00b00394880fae3amr57162952wmg.13.1654606785803; Tue, 07 Jun 2022 05:59:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:500:4c8d:4886:f874:7b6f? (p200300cbc70905004c8d4886f8747b6f.dip0.t-ipconnect.de. [2003:cb:c709:500:4c8d:4886:f874:7b6f]) by smtp.gmail.com with ESMTPSA id be5-20020a05600c1e8500b003942a244ee6sm20657928wmb.43.2022.06.07.05.59.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 05:59:44 -0700 (PDT) Message-ID: <16c92358-0daf-94d0-0f73-92faef827d51@redhat.com> Date: Tue, 7 Jun 2022 14:59:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/3] mm/slab: delete cache_alloc_debugcheck_before() To: Daniel Vetter , LKML Cc: DRI Development , Daniel Vetter , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , linux-mm@kvack.org References: <20220605152539.3196045-1-daniel.vetter@ffwll.ch> <20220605152539.3196045-2-daniel.vetter@ffwll.ch> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220605152539.3196045-2-daniel.vetter@ffwll.ch> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: i9e71sob1zn6nifwbtbi5wpxq1469yxe X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QGfferDz; spf=none (imf15.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C52C7A0062 X-HE-Tag: 1654606762-233031 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.06.22 17:25, Daniel Vetter wrote: > It only does a might_sleep_if(GFP_RECLAIM) check, which is already > covered by the might_alloc() in slab_pre_alloc_hook(). And all callers > of cache_alloc_debugcheck_before() call that beforehand already. > > Signed-off-by: Daniel Vetter > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Andrew Morton > Cc: Vlastimil Babka > Cc: Roman Gushchin > Cc: linux-mm@kvack.org > --- LGTM Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb