From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 382FDC433F5 for ; Sat, 21 May 2022 16:38:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD2516B0085; Sat, 21 May 2022 12:38:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5AB66B0087; Sat, 21 May 2022 12:38:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FBCC6B0088; Sat, 21 May 2022 12:38:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8CBC56B0085 for ; Sat, 21 May 2022 12:38:24 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 636CE33C35 for ; Sat, 21 May 2022 16:38:24 +0000 (UTC) X-FDA: 79490308128.26.9FEAA46 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf19.hostedemail.com (Postfix) with ESMTP id 6A56B1A001D for ; Sat, 21 May 2022 16:38:12 +0000 (UTC) Received: by mail-lf1-f44.google.com with SMTP id br17so6688747lfb.2 for ; Sat, 21 May 2022 09:38:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=Wb/V91Pwh4wB3EAs6xgX+enNMi2t+13tZlysFcCX1i4=; b=EhsaiP3edvHWkF6iZ/g4kbDdoucu2Hg9/DwUaWCO1Iu39vG/HSh7DpGYTKIBa8nltX 7fjwk8jAcmjbcbZJLhP95KzdEjzefrc50ViZXA78q+dlaTqNOQqO/F7nOOFKaFVThoOP dU7Wj/9rE6xQZzw0Y2K39AqL7cUZtdLf1QAu1TaSF/Ooh8+2Q74tSwpYs/aw/RKVFDBv iDwRJwtQ0zedkl8HFdOeziMW5IH+3q55Nzg0+/Ec12EsHwr+57XmAqP66tl5ItbXKpDQ g1/J1VMpu7IVTmXkHN7siOvn389e2ft7AgNIpbEelIf2PqHCdv7vJ9n/x3Yk81guXbQR 9hog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=Wb/V91Pwh4wB3EAs6xgX+enNMi2t+13tZlysFcCX1i4=; b=g1JpRsHF9pwEeeGD0VkN/U3PkYiXE0JIvnjNWvv/OuolwN+Yw2q2mHAvhAM/hy00D7 scU/v3sDStMzBzX7V3utBLsQmEhiC1OzuhZzVmslxKgkP/ICbYQDOc6VCwU8eTK4+AYC v0upJREME38bVuyaGYZNfeuNOq0lwWBSTTQkoPTXip37BmxbuMwPkja2l968jutcHN08 HG+JB4NZisigWeFY/x7K7ehqvlIeY0R1cRvGUBQuosiJva0oL8ZhMBWedvB5/6gRNXBY s5Ja6jjHZyNiQJ2xfdaaet7U4km3lJ9+4ScCEDU7rWmdvHC2/p3B4Fg3fBqPMA/KMN5e F6+w== X-Gm-Message-State: AOAM533bGiIgi8kiL1hiMMD7y85d8y7g02Eo8zObTGAbMrG4X90+dnoT MOZACvu5DtFYgdo1M4dWJQt1Yg== X-Google-Smtp-Source: ABdhPJycYdcmWtOeexBDTeDN18dVHF6RUwKxUM2Ot0xLt2OS/9K5EOP0DVYoEuoz4+XoaRxHeoumVg== X-Received: by 2002:a19:7104:0:b0:474:d376:2cd3 with SMTP id m4-20020a197104000000b00474d3762cd3mr10438574lfc.175.1653151102636; Sat, 21 May 2022 09:38:22 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.185]) by smtp.gmail.com with ESMTPSA id bf16-20020a056512259000b00477cb9b8762sm960850lfb.50.2022.05.21.09.38.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 May 2022 09:38:22 -0700 (PDT) Message-ID: <16f17021-61a3-c6f4-f60c-1acd3a0b66b9@openvz.org> Date: Sat, 21 May 2022 19:38:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 From: Vasily Averin Subject: [PATCH mm v2 5/9] memcg: enable accounting for percpu allocation of struct psi_group_cpu To: Andrew Morton Cc: kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , cgroups@vger.kernel.org References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=openvz-org.20210112.gappssmtp.com header.s=20210112 header.b=EhsaiP3e; spf=pass (imf19.hostedemail.com: domain of vvs@openvz.org designates 209.85.167.44 as permitted sender) smtp.mailfrom=vvs@openvz.org; dmarc=pass (policy=none) header.from=openvz.org X-Rspam-User: X-Stat-Signature: jd3gph5zqejuam7zb9hz6cqitrx7r1mq X-Rspamd-Queue-Id: 6A56B1A001D X-Rspamd-Server: rspam01 X-HE-Tag: 1653151092-429789 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: struct pci_group_cpu is percpu allocated for each new cgroup and can consume a significant portion of all allocated memory on nodes with a large number of CPUs. Common part of the cgroup creation: Allocs Alloc $1*$2 Sum Allocation number size -------------------------------------------- 16 ~ 352 5632 5632 KERNFS 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) 1 192 192 10504 (__d_alloc+0x29) 2 72 144 10648 (avc_alloc_node+0x27) 2 64 128 10776 (percpu_ref_init+0x6a) 1 64 64 10840 (memcg_list_lru_alloc+0x21a) percpu: 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f 2 12 24 312 call_site=percpu_ref_init+0x23 1 6 6 318 call_site=__percpu_counter_init+0x22 '+' -- to be accounted, '~' -- partially accounted Signed-off-by: Vasily Averin --- kernel/sched/psi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index a4fa3aadfcba..f0b25380cb12 100644 --- a/kernel/sched/psi.c +++ b/kernel/sched/psi.c @@ -957,7 +957,8 @@ int psi_cgroup_alloc(struct cgroup *cgroup) if (static_branch_likely(&psi_disabled)) return 0; - cgroup->psi.pcpu = alloc_percpu(struct psi_group_cpu); + cgroup->psi.pcpu = alloc_percpu_gfp(struct psi_group_cpu, + GFP_KERNEL_ACCOUNT); if (!cgroup->psi.pcpu) return -ENOMEM; group_init(&cgroup->psi); -- 2.36.1