From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 718FCC3ABBE for ; Tue, 6 May 2025 21:18:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B63006B0082; Tue, 6 May 2025 17:18:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0F886B0083; Tue, 6 May 2025 17:18:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B1986B0085; Tue, 6 May 2025 17:18:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 79DEA6B0082 for ; Tue, 6 May 2025 17:18:10 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 94BA3B81B8 for ; Tue, 6 May 2025 21:18:11 +0000 (UTC) X-FDA: 83413745982.21.89B4951 Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by imf04.hostedemail.com (Postfix) with ESMTP id 6B49940008 for ; Tue, 6 May 2025 21:18:09 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b="JW/IFUd0"; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf04.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.170 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746566289; a=rsa-sha256; cv=none; b=vfU+TZ/q64PFTzCY2dmlgTJV/LfrOkZYWLj61eFbcOmdOkRgf25j6v+44ssv6cGj9G+GAS ONOAQBv7gudgbiXC+n1Vgq7dnxT/nz9NzZ3vLqPaHlUzgPIYy4aWN/XP2/woAd6wG7oNNp AOQrjLj0lvzRkhAswiUBrFeG9z11ouY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b="JW/IFUd0"; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf04.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.170 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746566289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vhk1HBI/4LMXTfhNfYxi9xZ9PhHpTPrJe65ilxoqp+Y=; b=CMUUbuw5EBsN6ZSxXg4SBnH1yHFNfj5MP8Qjrae8aMVYVd6Q5NOKJh9kC43gxrUtXHB0QX AazP1Qc9juErpwoqBAKLiTOebokxnY41xbg8QX7JQwr3nQE6VLQ50G2xbt/704sS0WsIgn Yrn80/U3W/tBrFOkGbANhq0HWHLl3iA= Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-3d589ed2b47so21318185ab.2 for ; Tue, 06 May 2025 14:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1746566288; x=1747171088; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vhk1HBI/4LMXTfhNfYxi9xZ9PhHpTPrJe65ilxoqp+Y=; b=JW/IFUd0duQijzV80WZFMvS8nABtGnLtPHa5oI5ZZqdXtGt+c7aSS2q23I8tDqgDwS K005d+1rzTriBtTrTdY2Vj/07sQwp8zHmSxMja2DUvPdWdzWPLJn/nQDD9UQQeb+WcNj KFolp0to3iQUdek1bNqaa76LMzGqzBEKS3cQM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746566288; x=1747171088; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vhk1HBI/4LMXTfhNfYxi9xZ9PhHpTPrJe65ilxoqp+Y=; b=OuU6P5+9PJ8UO/3cjBaRijhCMcKB27Hsm6++nBLEmKW9j/5XcDniLVETHKAIune8HI ttGFfhO9cEvAJtjUjWO+WVUsXtSzAzcvloMU4Cbgvqnr0nUZsZy6v1SGmX79xTRITThi K4ZLg+QY28gxLJ+/ilKKzWM3gLuuzL3rTrUaaqHS2uljbtlnNXpySqGq0MNuLlvoyAMA uc96xs5XkrdX4hkSQui+4De9yx/RkI4XHd7ejAyzeB2NJIbb6eOt/eF8SAVGiSUVC49v fS/58JXaFTwV85vCqM85A9Ackv0VYnv3++chPAZ6CNmZquEWMqn/uNFmFxirGx/v4klh huFg== X-Forwarded-Encrypted: i=1; AJvYcCWJrd128jtARsSaDrNrcygOuJQEjlHPHQXxhiOfbkc5bNH8vlMXZtd2fmjGsCxU8JqhKcM94EbQBQ==@kvack.org X-Gm-Message-State: AOJu0YxjOauRaD4ykSt28MP59L61+SV+ahJoIrHbe0FNwfj4TK8RxVc7 aZQgeZuBJDiVougRKCKF/dOwehntjJXUpypiyhtXa6zi3/H3tyX4Idac5T7BUxI= X-Gm-Gg: ASbGncurTIU7SIjGEj3jabJluT/TpEJ7BwrQMsMB6bt8ypK+lQLxmA86Ky5N74zpU5k 5X0FMMmWuZkXDm/y4IE13xzz3eoIn3dKzsT32nclcXFIicpkvA58sxFNK0wq/imU4h8NbBcf5Sb eQs3IpInOp7BqTZI5P/j3JwqR3a3/7hm1AEGMTjwtHrxt6+x9VC4yCVEmR5WUGbwlI+5FG5NQE2 wWzYkffKFZOu7EkIj8nqzM7CiaamnsixHHuaPJ5dY0aOcmmk6r6aBg6/gQ+t8auUsiTU0pbmNxg oEcukVGWzkFiH9wJ8TwtDfzHYzg2iiae465fw0DETnklKSMZnT0= X-Google-Smtp-Source: AGHT+IHUA+sn2FCbduj4eCJZBOdW4tseCQ5oMi7Bx4Yf5oLI8Rys2VzAzxELUSzWphfH7ztNR5z4iA== X-Received: by 2002:a92:b0f:0:b0:3da:7237:525a with SMTP id e9e14a558f8ab-3da738e5fb2mr7278445ab.8.1746566288378; Tue, 06 May 2025 14:18:08 -0700 (PDT) Received: from [192.168.1.14] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f88a916042sm2419259173.40.2025.05.06.14.18.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 May 2025 14:18:07 -0700 (PDT) Message-ID: <17464a97-e7be-49d4-9422-96ff824dba7c@linuxfoundation.org> Date: Tue, 6 May 2025 15:18:06 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_* To: Peter Zijlstra , John Hubbard Cc: Lorenzo Stoakes , Christian Brauner , Shuah Khan , "Liam R . Howlett" , Suren Baghdasaryan , Vlastimil Babka , pedro.falcato@gmail.com, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Sang , seanjc@google.com, Shuah Khan References: <5b0b8e1e-6f50-4e18-bf46-39b00376c26e@nvidia.com> <20250501114235.GP4198@noisy.programming.kicks-ass.net> Content-Language: en-US From: Shuah Khan In-Reply-To: <20250501114235.GP4198@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 6B49940008 X-Rspamd-Server: rspam04 X-Stat-Signature: q74gsjpjntq4hb7hug4ccxhrz15qxuta X-HE-Tag: 1746566289-355849 X-HE-Meta: U2FsdGVkX18cVgXMtaZaWukh3KfvgfnrOb2qR04IAJNi1G7bS7+o3vWlxqwOUkeLKz9Ric36Xpgphuax/gs74Cs7x2REYVPnFI16V9tty3RR2xDFREpkKcVX2Qd72g0c8yiAlRQwcGRZpvvtUxs4ZUTF/aWOl7Mc/NJ43MO2uZBfWkqMbi1UQ4E78gM8YvkeVqs4FMIrgfnuJiPS1oA9Yg+sz+sbFYS3I6Pr1h9aZNUahXY1ehNGLIAx5QlEk9s1so2fhsta95JcIf5JkBPBCjOQXezB/a1JbEx9Zm1ha9ft2nkiTcCGZgP5bMoA7LgBWJuh9UNH3Bi9Z6D57X7gpCJzXKHBQx5zcipm11yf6a0gpc95cKYQ+u8BPSXRpACrCINSAeHHSsIDRiVEnOZHxmIMUSxD8sYO9X2P5I0cEjPwcNAtv1qzIjn+z9qSbcCvKx8VOXG4Ec2m8Jjxl3UP74Rp7v370qXVxGGFtFOxiQKGbpal9IWk5V/DJB3ZWnnIbIwDun8vCExRO5vJn4oXw2w36zptdtcPqtxiPFOtAeDNDc/4H6FJ0KGezYjfMKuF7y4WPYXmb2XJBUU4wdah1wYJ5ZyvgdsSIEKG+VZJeJELcxACM38LAJDMhly8xYcA/umdRiUuAPc1ROMfMYzNTtVBic3VTP/0QT5EQ3vWmCwrzFjgt0gXBv4qp0rj8HKuxH4WWIwMXqkj/9Tdd9StG4mU7jE6Z/WDZGu8vsskA/dj2fZGqAWOvtpsLAMmw9GjAIR2yn2apVEBB3xS0lO6FuPHtcU/fKMFoiuhU6YdGX1kRFg89rQbgVSaW2gZHzpgcRpLstdeG2TXgfsdcKIdBBRgTld4z4ch+IyOEHTK3gULmI05pQ8eKbkjPbN+8fnxad+M9KDZydUyeIEZA8WWtQeNTKDDuY4472YfuK+rli5l9rfXvfIAsQDG5G1PEnMwz8VVLscHi4BJip2ChA3 bmTzv1hl mV1lzLa8w23SAYle4fqeZfn7eE/E2ca+6APOgDv6Xl2pM3ufatmPRP5AkXuntL5khFW+HQDOr2TLyhKKPVhQZXdWZEfbAjCDYm8Q6xnrUXgfBwZc/QET5X5p2XZ6sfkZ0kypKhnoH/KVPQktl6DChA0P7FzXnRQScjiel7PzEPFi8ewUQTHZr1J8kFqsENKbbG4rHh8yFKLY8mR9ad0W7DP3SL/yaQmo/dqzZU4J2vNJuEfp6xXUdpOZCnq4sMaFnIWMg3OuFuWtnc9J9KYDx8/lxsSXKkk5Grb4S3u77ZdcFxPr3+DOZOsTwUGoCgCox7xfwUIJEdwZZ6iQzqAKSgk8zo8DSU2fG/BHFARCNYUaMyjrQ5dK8eTTl4nm9EzJHJQ69mdazYgKszWDAl9g+xkE9Win7iq8vm4c1gUMXxEi2dUB63rPcmwo3TkTm+PUmKY9E2CdPhYPfeUHdKPokh74weg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/1/25 05:42, Peter Zijlstra wrote: > On Wed, Oct 16, 2024 at 07:14:34PM -0700, John Hubbard wrote: >> On 10/16/24 3:06 PM, Lorenzo Stoakes wrote: >>> On Wed, Oct 16, 2024 at 02:00:27PM -0600, Shuah Khan wrote: >>>> On 10/16/24 04:20, Lorenzo Stoakes wrote: >> ... >>>>> diff --git a/tools/testing/selftests/pidfd/pidfd.h b/tools/testing/selftests/pidfd/pidfd.h >>>>> index 88d6830ee004..1640b711889b 100644 >>>>> --- a/tools/testing/selftests/pidfd/pidfd.h >>>>> +++ b/tools/testing/selftests/pidfd/pidfd.h >>>>> @@ -50,6 +50,14 @@ >>>>> #define PIDFD_NONBLOCK O_NONBLOCK >>>>> #endif >>>>> +/* System header file may not have this available. */ >>>>> +#ifndef PIDFD_SELF_THREAD >>>>> +#define PIDFD_SELF_THREAD -100 >>>>> +#endif >>>>> +#ifndef PIDFD_SELF_THREAD_GROUP >>>>> +#define PIDFD_SELF_THREAD_GROUP -200 >>>>> +#endif >>>>> + >>>> >>>> As mentioned in my response to v1 patch: >>>> >>>> kselftest has dependency on "make headers" and tests include >>>> headers from linux/ directory >>> >>> Right but that assumes you install the kernel headers on the build system, >>> which is quite a painful thing to have to do when you are quickly iterating >>> on a qemu setup. >>> >>> This is a use case I use all the time so not at all theoretical. >>> >> >> This is turning out to be a fairly typical reaction from kernel >> developers, when presented with the "you must first run make headers" >> requirement for kselftests. >> >> Peter Zijlstra's "NAK NAK NAK" response [1] last year was the most >> colorful, so I'll helpfully cite it here. :) > > Let me re-try this. > > This is driving me insane. I've spend the past _TWO_ days trying to > build KVM selftests and I'm still failing. > > This is absolute atrocious crap and is costing me valuable time. > > Please fix this fucking selftests shit to just build. This is unusable > garbage. I don't recall all the reasons why kselftests needed "make headers" One reason I could think of was that when a new test depends on a header change, the test won't build unless headers are installed. If this requirement is causing problems for tests that don't fall into the category and we probably have more of them mow, we can clean that up. John, you mentioned you got mm tests working without headers? Can you share the commit here. thanks, -- Shuah