From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A501C001DC for ; Thu, 27 Jul 2023 19:49:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9517E6B0072; Thu, 27 Jul 2023 15:49:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D9946B0074; Thu, 27 Jul 2023 15:49:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 753C26B0075; Thu, 27 Jul 2023 15:49:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 61E2E6B0072 for ; Thu, 27 Jul 2023 15:49:15 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2BE2EA0D3A for ; Thu, 27 Jul 2023 19:49:15 +0000 (UTC) X-FDA: 81058430670.08.8E56453 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 414D540009 for ; Thu, 27 Jul 2023 19:49:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CDWpo489; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690487353; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lhKBfrs7PWxagBM4M/4Uh0236cjqOcIxZ56PmZEdO5Q=; b=Yr1p285WqoIPptO6eb+LFcoe5JE+thpQU/2riMwUn4rtdkNHZbbI7+ygHg8iORE4tx4DqZ aUGJAexxlABcXPATQgp3kC8HTApx4BbfnaMprE6pO+9+TD+HWcdJyQWDXbcteca8dpgkGA UT3G9HNUQMMXpjgyYvinR+9rHJD5Bsg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CDWpo489; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690487353; a=rsa-sha256; cv=none; b=xyzbg4Kt8JQYlm9WZmPb7bKtDrjso+xHzEAJbMnM7oxLPKJ+JysMlb7DlgOuWWH6ZJ1vNI jKZUdfbJCklnX8Aj2YfT9AMdU9zkGM7aNVyFA9e4G/wKCFut2NNUIw0qqLnjnz6aygpZR7 quJtOriWacDol4h5xbqzFiv5RD4dhUI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690487352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lhKBfrs7PWxagBM4M/4Uh0236cjqOcIxZ56PmZEdO5Q=; b=CDWpo489G/Kvo327LcneaKGL4uCx87Aj78cmwvPf9fT/dQLsM1RaV/LjTmgBZdZ9q9Uwx1 /E7eFH4v33eS2SdATFFnP97UiZQoW44PVNRTswvdrRVOUqScLnJVe37UOmht9e16vgi8p7 af9Ox8/c8nFx3c9/BYaSeXslEGfaYZ0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-493-o54PgO0nPbi9ttTz3960KA-1; Thu, 27 Jul 2023 15:49:06 -0400 X-MC-Unique: o54PgO0nPbi9ttTz3960KA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2441B185A7BC; Thu, 27 Jul 2023 19:49:05 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECB371121330; Thu, 27 Jul 2023 19:49:02 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230727093529.f235377fabec606e16c20679@linux-foundation.org> <20230727161016.169066-1-dhowells@redhat.com> <20230727161016.169066-2-dhowells@redhat.com> <175119.1690476440@warthog.procyon.org.uk> To: Hugh Dickins Cc: dhowells@redhat.com, Andrew Morton , Christoph Hellwig , Jens Axboe , Al Viro , John Hubbard , David Hildenbrand , Matthew Wilcox , Chuck Lever , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] shmem: Fix splice of a missing page MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <178882.1690487342.1@warthog.procyon.org.uk> Date: Thu, 27 Jul 2023 20:49:02 +0100 Message-ID: <178883.1690487342@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 414D540009 X-Stat-Signature: gridgd97r3y1onu4jyh8fbw6xuibqjtj X-Rspam-User: X-HE-Tag: 1690487353-797509 X-HE-Meta: U2FsdGVkX1/Ox/zrrbnsGHqC2wOP3xoDeQ80Fs7Lq4uHmCz1Od4eMO+JPhJe8JT78by5aC0v66rtkBNX9CpO2Oo5oBXqz/cwVhEbcYJAAm0Y+g3g6f8Y9NaN0L/HGXC/8LUmRWnvF2CwT7eNAbPjRtsbJNVJBvvyEY375y7r3ayPimNfICG9HJIliTo538ai+GiZ0nd0KkScJulzRxsbI6PPN4OxtP8hKqegWXJ33qXmoQ4n19Q27+8fUBBW4uSt7BxV3ilzwQcCEBMG1EP0zMwTmxjNK4sBDxAYo3aWn0069NXoQOU0GtxT7TA+zUCRBybujzT24qKUiQ8lHhC60dpdccK1UQvYblUZ0SJNmMO1/p4Z2VARFoXyoduevuEA9qy3cBjUuJl3kYKHwMsGgFgz5IZNNZNZdqHZbW8lhXs2e5kMOMOyR7zYaDqxmmfbee3/V29vzzjZB6kzjtQb80wyecqEzeKQ7gI4Gae0g+GieIztO9GmoRZE/1nEKrGaJiDm2NW8LGgbpbfrBUWbhOKiQLv594udK5IJxwWCQgkZ1e/t4QUcgmEVW8/UkmjGAIvwcVp07jgt4+TjGEu/4KXqeIhzqJhlgDRikyIyBQCSw4WvVNNhNEP+WbxwrkdnA1zmS+U6Birjs1lWPG6W21zPJ2knCs2XM+YKe2QAsSA1nOBgu9lu0LwnqFWe7m9JAthbYEqvGUFeONoVulOpnl76HPr2nlOWRPSjLGzbXIUaXrKAAahqw4IXsZE1J9cofjf0wpoR7geY1pUIfntr08tAklaCiBIxDcENA+bK0iLK8BL/k2n6SLVwdW5F/nEL+9BYXuLTNuDtWWr7nTnWMvzKPbxcuHnk84MOnrU4bEVp4AOCIwVSFQjkyw8xTGpMZPGcMFmvDxBnkKY1TJZ2/gs/M/Pji6d6yHBExJ6T1TLob40pgMAcnuEe7INCwfjcAcP+3IQ3iNpqdrMB5Dw kunhmSp+ 3LettzdLifouEt2B/9cxUZJTjzghvdGCrGom/8gfzcK8csNSJ+Ki9aTpqerJU3n+3+848SsLeT2BozIa2alTkjJOkQ6Bm7+MEbvK9W1xLTKyz984FTtFOK0n4xiKkgCxjKsYyRemPRLImEKR10iP8viN9Q2V1o6HideqpysNKpHbx75x22mS3qOKIL8Qt36wl8LXL8k6uU19vbif71KeycwQZvyx7c71FdUU2u+1hiF0JzVvo2bLluwDRJj1i5AR/zsznS774SJ7qJduhM8FAuVqI1Q5kd1LNsgMR8N+J8gUFl0U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hugh Dickins wrote: > On Thu, 27 Jul 2023, David Howells wrote: > > Andrew Morton wrote: > > > > > This is already in mm-unstable (and hence linux-next) via Hugh's > > > "shmem: minor fixes to splice-read implementation" > > > (https://lkml.kernel.org/r/32c72c9c-72a8-115f-407d-f0148f368@google.com) > > > > And I've already reviewed it:-) > > I'm not sure whether that ":-)" is implying (good-natured) denial. I've reviewed it, and the review still seems good. > You reviewed the original on 17 April, when Jens took it into his tree; > then it vanished in a rewrite, and you didn't respond when I asked about > that on 28 June; I missed it in the rush to try and get everything debugged during the merge window prior to going on holiday. > then you were Cc'ed when I sent it to Andrew on 23 July (where I explained > about dropping two mods but keeping your Reviewed-by). Hmmm... I don't find that one in my inbox. > This version that Andrew has in mm-unstable includes the hwpoison fix > that we agreed on before, in addition to the len -> part fix. Ok. David