On using allocation in sysctl handler

On using allocation in sysctl handler

[Auguste Mome]

Hi,
I added an allocation GFP_KERNEL inside a sysctl handler and got the error
BUG: sleeping function called from invalid context
in_atomic(): 1, irqs_disabled(): 0, pid: 723, name: sysctl

Is it obvious error and I should use GFP_ATOMIC?
I guess yes, but it just happens since I switched to a 2.6.30 on ppc, and it did
not happen on 2.6.30 x86.
So I'm not sure if something is wrong on ppc, of if something changed
recently in sysctl,
or simply my code was wrong and the check has improved in memory system.

Thanks,
Auguste.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: On using allocation in sysctl handler

[Auguste Mome]

I did the allocation inside a lock, that's the real problem, not the
GFP thing. Really sorry for the noise.

On Sat, Mar 27, 2010 at 12:56 PM, Auguste Mome <augustmome@gmail.com> wrote:
> Hi,
> I added an allocation GFP_KERNEL inside a sysctl handler and got the error
> BUG: sleeping function called from invalid context
> in_atomic(): 1, irqs_disabled(): 0, pid: 723, name: sysctl
>
> Is it obvious error and I should use GFP_ATOMIC?
> I guess yes, but it just happens since I switched to a 2.6.30 on ppc, and it did
> not happen on 2.6.30 x86.
> So I'm not sure if something is wrong on ppc, of if something changed
> recently in sysctl,
> or simply my code was wrong and the check has improved in memory system.
>
> Thanks,
> Auguste.
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>