Re: [PATCH v2 5/5] mm: mincore: refactor mincore_page()

["David Hildenbrand (Arm)" <david@kernel.org>]

On 7/10/26 14:00, Kefeng Wang wrote:
> Use early returns to reduce indentation and improve readability.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  mm/mincore.c | 21 ++++++++++-----------
>  1 file changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/mm/mincore.c b/mm/mincore.c
> index 9952bc3edf76..30a3317082d1 100644
> --- a/mm/mincore.c
> +++ b/mm/mincore.c
> @@ -94,7 +94,7 @@ static unsigned char mincore_swap(swp_entry_t entry, bool shmem)
>   */
>  static unsigned char mincore_page(struct address_space *mapping, pgoff_t index)
>  {
> -	unsigned char present = 0;
> +	unsigned char present;
>  	struct folio *folio;
>  
>  	/*
> @@ -104,17 +104,16 @@ static unsigned char mincore_page(struct address_space *mapping, pgoff_t index)
>  	 * tmpfs's .fault). So swapped out tmpfs mappings are tested here.
>  	 */
>  	folio = filemap_get_entry(mapping, index);
> -	if (folio) {
> -		if (xa_is_value(folio)) {
> -			if (shmem_mapping(mapping))
> -				return mincore_swap(radix_to_swp_entry(folio),
> -						    true);
> -			else
> -				return 0;
> -		}
> -		present = folio_test_uptodate(folio);
> -		folio_put(folio);
> +	if (!folio)
> +		return 0;
> +
> +	if (xa_is_value(folio)) {
> +		if (!shmem_mapping(mapping))
> +			return 0;
> +		return mincore_swap(radix_to_swp_entry(folio), true);
>  	}
> +	present = folio_test_uptodate(folio);
> +	folio_put(folio);

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David