From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20EB3C7115A for ; Thu, 19 Jun 2025 16:04:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9949C6B0088; Thu, 19 Jun 2025 12:04:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96C4B6B0089; Thu, 19 Jun 2025 12:04:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 882726B008A; Thu, 19 Jun 2025 12:04:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7B6AD6B0088 for ; Thu, 19 Jun 2025 12:04:53 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3716E160561 for ; Thu, 19 Jun 2025 16:04:53 +0000 (UTC) X-FDA: 83572623666.06.BCF603A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id D709440010 for ; Thu, 19 Jun 2025 16:04:50 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QwWvj73d; spf=pass (imf01.hostedemail.com: domain of ddutile@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ddutile@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750349091; a=rsa-sha256; cv=none; b=8I/hCRLR3MqDyviJVsPev863mZHguZsFjmZOxaJe2kutMzeyHL/ZYNtnAgxV/7cBwMSGON c4bHeLHfPg/YI34YNBJJBr5pUqPEqcZQZeJ0TqwVoPi9gsX2JQmRCY+bf2sZmtfY2kS4sQ u2ek6wq1pRDGiaLvaOXCyg9BinKPes8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QwWvj73d; spf=pass (imf01.hostedemail.com: domain of ddutile@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ddutile@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750349091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jnOhBasCiJjIhYRxZYUdwPDMPuwY0WvKyYdO2+gnZTM=; b=jSSAMUski33oURp3w9CkPxmXmVR1XSjc+QwbzT1305Lo07IfkjiU0U9st9H+8a8R7gCkOF BcU96NR1OVBwuh4os6L0hn1N8OLk+26gsCEIon94GM9MsONYKCeM8XSRDP2XVBM52TE6/5 jcUR9m+FSpBu/xSDEzJYRwimsCbMbs4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750349090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jnOhBasCiJjIhYRxZYUdwPDMPuwY0WvKyYdO2+gnZTM=; b=QwWvj73d102xS1o3/h1Sx6+9r0TYj+nr+ChEcPrQpXwRrRuAMGtX1P5iWY8SJQBJXNwJlf eSt9ObpsmzVGggppkLCwZ5Cih1wBJ9Y4RekipPl8LgpfqmMmMWYrYyfA4qe/dQvnAq9Nxp ksR/ioJxMT8mSiAly/P35D4atd9ZL78= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-144-x8c-nVhSPjyaNn-M-H_c2A-1; Thu, 19 Jun 2025 12:04:48 -0400 X-MC-Unique: x8c-nVhSPjyaNn-M-H_c2A-1 X-Mimecast-MFC-AGG-ID: x8c-nVhSPjyaNn-M-H_c2A_1750349088 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b3184712fd8so705859a12.3 for ; Thu, 19 Jun 2025 09:04:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750349088; x=1750953888; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jnOhBasCiJjIhYRxZYUdwPDMPuwY0WvKyYdO2+gnZTM=; b=tIjaaNKIMDLFgvKLkpwIzHXBA700uaDt6duL+3AlrOWaFy977IpHEqHUqJqGLRmM7R DN1ORcIqi5fKNxtb07PXjzq2W7nPrQe4vWJTX4dBFoN6pblibgOBlLtKpYjqGRgwm53t zCCLntYMKLqSx39KlDTfibNLhyACxZAaSi5VQkDJd4BOlu4mDbFA4dVShTVMPblGlrSO /ShVuxN+Q9iVaaeUmLYCbexIYtjvSzhI3N8bdnatBZmT6ybiR92OiVMeox4DWZYKa4Ze 9++7CNKt+IbzQE3MCY7IY0+wdMTZ1IRsg8pc7IZrekfYrHAv86jkHs4dnw8dTpLSIfIO PX3w== X-Forwarded-Encrypted: i=1; AJvYcCUNPqIyN6+RMktRM977cftyzbSF83OJOQ0V7IWitUEAiz9OfSFQoQeyewb4+DhmdVx8274QgmHTiw==@kvack.org X-Gm-Message-State: AOJu0YyAzZ6xqDNfeBFN1DQpZG8Nc60qO+iI0LUCf4hmj7QS++k5r8Gd DGzbwfN7H74QjktICFWNARFbXeyzPilWJ33hKU1qkEycshv28PmVx27CPH48pncmikOQDVItbfz 74bB1gPaMAa42CQ9yRelMLW9Pj9mgY8iNyNrsTvkiWuZek7jPvLsf X-Gm-Gg: ASbGncsUWE7Kb4dubJFDwH3QJBqs9HNiA8cwA1op5ezzrDHWR6XkkoqM9coqhOAqnTw DjliB5eA84Y62XfDExioBkP2NLdMfmLiPFT0xThjFXQfHGNE4OoURfp0O5DLoEQJWjLp4bUnK/4 IDGtr/BG7LuwSEjq681b+w5JE/s3ILC+DQCquZxe812YJsVTlejoUwUf9GKN0cZRSMjgpVVwz10 ZyIfmpXziPAhzmIYg3+fNAIraz/Uv06JSewzQI6fp2TR8lWRtoeQIpb3bEtbdD9cpznzeAXrXZo 4VicPr7oAjsDXcrrTuETjvo= X-Received: by 2002:a17:902:ecce:b0:22f:b6d6:2737 with SMTP id d9443c01a7336-2366b32e726mr380403805ad.10.1750349087800; Thu, 19 Jun 2025 09:04:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjJXAklTpU4bxpt+jnWBfHNJB4kATINyoW2fUcIAggJV9+NymIlKk9BuBUHb5XP9WcmOt80w== X-Received: by 2002:a17:902:ecce:b0:22f:b6d6:2737 with SMTP id d9443c01a7336-2366b32e726mr380403205ad.10.1750349087399; Thu, 19 Jun 2025 09:04:47 -0700 (PDT) Received: from [192.168.40.164] ([70.105.235.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365deca379sm121411835ad.210.2025.06.19.09.04.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jun 2025 09:04:46 -0700 (PDT) Message-ID: <18151eb8-60ec-438b-b9fb-026efc8b848d@redhat.com> Date: Thu, 19 Jun 2025 12:03:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 4/5] KVM: arm64: Allow cacheable stage 2 mapping using VMA flags To: Ankit Agrawal , Jason Gunthorpe , Catalin Marinas Cc: "maz@kernel.org" , "oliver.upton@linux.dev" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "will@kernel.org" , "ryan.roberts@arm.com" , "shahuang@redhat.com" , "lpieralisi@kernel.org" , "david@redhat.com" , "seanjc@google.com" , Aniket Agashe , Neo Jia , Kirti Wankhede , Krishnakant Jaju , "Tarun Gupta (SW-GPU)" , Vikram Sethi , Andy Currid , Alistair Popple , John Hubbard , Dan Williams , Zhi Wang , Matt Ochs , Uday Dhoke , Dheeraj Nigam , "alex.williamson@redhat.com" , "sebastianene@google.com" , "coltonlewis@google.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "ardb@kernel.org" , "akpm@linux-foundation.org" , "gshan@redhat.com" , "linux-mm@kvack.org" , "tabba@google.com" , "qperret@google.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "maobibo@loongson.cn" References: <20250618065541.50049-1-ankita@nvidia.com> <20250618065541.50049-5-ankita@nvidia.com> <20250618163836.GA1629589@nvidia.com> From: Donald Dutile In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lyuj0IZlOcDHicyh7wXzpTw4kjv7Sc93QJBUbDeA590_1750349088 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D709440010 X-Stat-Signature: ttw6kkg5ks5s1h1jjjb8ptcp4kg4e9qc X-Rspam-User: X-HE-Tag: 1750349090-103298 X-HE-Meta: U2FsdGVkX18jLIXwQlLfoiSz5ui5WvLjpZ5eCfUvUzn2U178Kj+8oSJ02V1eNRowsVab6hk/lvpmPnCe4pwEJbNenKAP8llVarI26onaup6mGs6kCPfLLqvcXOKtzam5lyp+PNKLt3SGXWAkSy+GSvserpGB7bmfXtBAppvp8h606PmhGAR8sm8HBVrzyz9FXEAbsEG1GAu7kNN3DXha0ikHC8MgeehglZgDee/T+YQTFUTMuV+qpS8W21RCeq+6O7sSEj9cv7y47/0/ra8xKKIj7AaCUYYvIhsN+VO4vKOTeAbsvvxwlNQDmHQViqGkBNE3NmpoDyyQphz7knfYJPs18EQVs+zZekOhsLVjIha0Kh6SQhbojCJo+qdeIIuOuTsds7p0siBFRCVJHuLSoHIKfDzQbSGyASY/qHHLkXa0t8BIlVcSHsJKvWCWDqE0zFxrDccFZhv7w3jTt/EZxZtmoB61pUI4iNOg54VBOV4XHzaBwff3Mt95DP3IlOm8leogGyLpqL0ZeLHDIUh9wC5idutHykdkvr0U1gbO0be6ILHqKJTds6/isUgWCC953gY0ZU7Oh4eQggcmV72XppFeIqlEdkNeTSn9QZvQ1RIdgxQyrVCYVmPpGnu71YuWxr6Ap424Y48M/e5ZHEXd53JBYKHCICNhdZ/S/zWo3FcXmIpl7uHOK2JaWsJmH0OnuQTAVOfJ1QUGoVvfFlA2deHFesSfG0XnuFC18b0lS1auUl41WeeS06ihM/UyOAUkl0jZ54GiYWRUkMKKphss4bSY8CKmSApqjVuWAlMOP3o5wbuwDhx5nvVio4+eVhxaq8jfoqRWXFQMhOciDUSty6at2KFVGMuD11lFlv6uzPhb/JGZwOo9v4KSOr8zymBs1e6iuPx+SqpFkq+QlSJrvqxpDFib3vWTJYGjoReTn5A5GoDYazRq6SqsXi0eS9Uo1k6kJfDp6BaMyKVrLis y4xRS45Z VF1HuEo9+fdp/SqC2b2dqmVstotW4PllcZdD/+e0043fOxC0lTpN71SGPpy2FdWIyU9E2nbuto9euNEhL3Z/Cj+7VJkGHxsZt0Y4y5rcxZrIdqXfbrc6n7QYDOwZTAdZKZKM6WG33pmp+4LXCZwJcryybjvAsvj78oio5GIvkz6hnrMWNqCcBMEBBydUTcKAqkWCE+0oqSeo7Flp+43+2dorBmOXhqkPKpTe6IV70TryIQUICgdQKgdnpStV/TshWDF2RUUZx2bboOAg3xOoFrRcA/zaURVsc78+eWG2AOS9GyrDhDth+u8aeWJl0eURaYOFlwEoqiTrVyvRa04THGzWXaWJVVeBtcOt+uZGGtprrCCdUR9yEGVoa8C+VjIBaV/pEdxSoBp0lKWWsjNsPr0dbkUH8edRv/XZW4nk3UXA+yTI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/19/25 8:14 AM, Ankit Agrawal wrote: > Considering the feedback, I think we may do the following here: > 1. Rename the device variable to S2_noncacheable to represent if the S2 is going to be marked non cacheable. Otherwise S2 will be mapped NORMAL. > 2. Detect what PFN has to be marked S2_noncacheable. If a PFN is not in the kernel map, mark as S2 except for PFNMAP + VMA cacheable. Q: 'mark as S2 except'... should be 'mark as S2_noncacheable' ? > 3. Prohibit cacheable PFNMAP if hardware doesn't support FWB and CACHE DIC. > 4. Prohibit S2 non cached mapping for cacheable VMA for all cases, whether pre-FWB hardware or not.