Re: [PATCH 30/30] nfs: fix various memory recursions possible with swap over NFS.

KOSAKI Motohiro
2008-07-25T11:15:52Z

> On Fri, 2008-07-25 at 19:46 +0900, KOSAKI Motohiro wrote:
> > > GFP_NOFS is not enough, since swap traffic is IO, hence fall back to GFP_NOIO.
> >
> > this comment imply turn on GFP_NOIO, but the code is s/NOFS/NOIO/. why?
>
> Does the misunderstanding stem from the use of 'enough'?
>
> GFP_NOFS is _more_ permissive than GFP_NOIO in that it will initiate IO,
> just not of any filesystem data.
>

> The problem is that previuosly NOFS was correct because that avoids
> recursion into the NFS code, it now is not, because also IO (swap) can
> lead to this recursion.

Thanks nicer explain.
So, I hope add above 3 line to patch description.

Cheers!