From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F2C8C433DB for ; Fri, 5 Mar 2021 18:16:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 089A364F1E for ; Fri, 5 Mar 2021 18:16:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 089A364F1E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8D3F06B005D; Fri, 5 Mar 2021 13:16:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 881C86B006C; Fri, 5 Mar 2021 13:16:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 723346B006E; Fri, 5 Mar 2021 13:16:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 55C4B6B005D for ; Fri, 5 Mar 2021 13:16:57 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 08F08180ACEEE for ; Fri, 5 Mar 2021 18:16:57 +0000 (UTC) X-FDA: 77886626874.29.8D65F43 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf11.hostedemail.com (Postfix) with ESMTP id DED2920053C3 for ; Fri, 5 Mar 2021 18:16:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614968196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xSmCXVggNB/CHBO3Bg4UxMkncMMlhKiVJCaV9LoD9Ks=; b=LxXoB4j2VMWMSIhfPsf10+cOap3COPHzKJ+NkrcsfNCm3aSRGtJ8+rQE4BsOxcGytMnpTf YkhxA6zNFYEcAxX/e9tUVjPEJ3BBlbpKTQZzu8KFHSBc3G3BkwQ3bnb53ELVLWzyOiXw6F j81VpI0vFtBqA/pFIHrWSbTprPjXDR8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-306-j6jDLvrLOQGnIWgPki6p7w-1; Fri, 05 Mar 2021 13:16:34 -0500 X-MC-Unique: j6jDLvrLOQGnIWgPki6p7w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 75EC01018F64; Fri, 5 Mar 2021 18:16:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 68F1F19CB0; Fri, 5 Mar 2021 18:16:32 +0000 (UTC) Received: from zmail19.collab.prod.int.phx2.redhat.com (zmail19.collab.prod.int.phx2.redhat.com [10.5.83.22]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E213C4BB40; Fri, 5 Mar 2021 18:16:31 +0000 (UTC) Date: Fri, 5 Mar 2021 13:16:28 -0500 (EST) From: Veronika Kabatova To: Anshuman Khandual , Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Catalin Marinas , Ard Biesheuvel , Mark Rutland , James Morse , Robin Murphy , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Dan Williams , David Hildenbrand , Mike Rapoport Message-ID: <1890909388.30244858.1614968188922.JavaMail.zimbra@redhat.com> In-Reply-To: <2001895867.30197818.1614947320141.JavaMail.zimbra@redhat.com> References: <1614921898-4099-1-git-send-email-anshuman.khandual@arm.com> <2001895867.30197818.1614947320141.JavaMail.zimbra@redhat.com> Subject: Re: [PATCH V3 0/2] arm64/mm: Fix pfn_valid() for ZONE_DEVICE based memory MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.36.114.98, 10.4.195.10] Thread-Topic: arm64/mm: Fix pfn_valid() for ZONE_DEVICE based memory Thread-Index: HYYsJ7UKXk8vnHFKJgWVD82gr9EAgcl6WMNp X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DED2920053C3 X-Stat-Signature: 61n89qhqxxm59t13u9iz5njzbxib49st Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614968200-724536 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ----- Original Message ----- > From: "Veronika Kabatova" > To: "Anshuman Khandual" > Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, l= inux-mm@kvack.org, "Catalin Marinas" > , "Will Deacon" , "Ard Biesheuv= el" , "Mark Rutland" > , "James Morse" , "Robin Murph= y" , "J=C3=A9r=C3=B4me Glisse" > , "Dan Williams" , "David H= ildenbrand" , "Mike > Rapoport" > Sent: Friday, March 5, 2021 1:28:40 PM > Subject: Re: [PATCH V3 0/2] arm64/mm: Fix pfn_valid() for ZONE_DEVICE bas= ed memory >=20 >=20 >=20 > ----- Original Message ----- > > From: "Anshuman Khandual" > > To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, > > linux-mm@kvack.org > > Cc: "Catalin Marinas" , "Will Deacon" > > , "Ard Biesheuvel" , > > "Mark Rutland" , "James Morse" , > > "Robin Murphy" , > > "J=C3=A9r=C3=B4me Glisse" , "Dan Williams" > > , "David Hildenbrand" > > , "Mike Rapoport" , "Veronika > > Kabatova" > > Sent: Friday, March 5, 2021 6:38:14 AM > > Subject: Re: [PATCH V3 0/2] arm64/mm: Fix pfn_valid() for ZONE_DEVICE b= ased > > memory > >=20 > >=20 > > On 3/5/21 10:54 AM, Anshuman Khandual wrote: > > > This series fixes pfn_valid() for ZONE_DEVICE based memory and also > > > improves > > > its performance for normal hotplug memory. While here, it also > > > reorganizes > > > pfn_valid() on CONFIG_SPARSEMEM. This series is based on v5.12-rc1. > > >=20 > > > Cc: Catalin Marinas > > > Cc: Will Deacon > > > Cc: Ard Biesheuvel > > > Cc: Mark Rutland > > > Cc: James Morse > > > Cc: Robin Murphy > > > Cc: J=C3=A9r=C3=B4me Glisse > > > Cc: Dan Williams > > > Cc: David Hildenbrand > > > Cc: Mike Rapoport > > > Cc: Veronika Kabatova > > > Cc: linux-arm-kernel@lists.infradead.org > > > Cc: linux-mm@kvack.org > > > Cc: linux-kernel@vger.kernel.org > > >=20 > > > Changes in V3: > > >=20 > > > - Validate the pfn before fetching mem_section with __pfn_to_section(= ) in > > > [PATCH 2/2] > >=20 > > Hello Veronica, > >=20 > > Could you please help recreate the earlier failure [1] but with this > > series applies on v5.12-rc1. Thank you. > >=20 >=20 > Hello Anshuman, >=20 > the machine in question is currently loaned to a developer. I'll reach > out to them and will let you know once I have any results. >=20 Hi, I'm happy to report the kernel boots with these new patches. I used the 5.12.0-rc1 kernel (commit 280d542f6ffac0) as a base. The full console log from the boot process is available at https://gitlab.com/-/snippets/2086833 in case you want to take a look. Note that there are some call traces starting around line 3220, but they are NOT introduced by these two patches and are also present with the base mainline kernel. Veronika >=20 > Veronika >=20 > > [1] > > https://lore.kernel.org/linux-arm-kernel/cki.8D1CB60FEC.K6NJMEFQPV@redh= at.com/ > >=20 > > - Anshuman > >=20 > >=20 >=20