From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C485C4345F for ; Tue, 16 Apr 2024 16:12:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E94C6B008A; Tue, 16 Apr 2024 12:12:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 972AA6B008C; Tue, 16 Apr 2024 12:12:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EC576B0092; Tue, 16 Apr 2024 12:12:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5F4886B008A for ; Tue, 16 Apr 2024 12:12:18 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1E29CA1CFE for ; Tue, 16 Apr 2024 16:12:18 +0000 (UTC) X-FDA: 82015887156.05.0A1AEC7 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf04.hostedemail.com (Postfix) with ESMTP id 421494000F for ; Tue, 16 Apr 2024 16:12:16 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Dhq5frU6; spf=pass (imf04.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713283936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EKrDgIJgNXo/R8quzpUy0yW7erzp8PxvHvcTe/50ujU=; b=0vD6Q/LXQLeYgZY//nK3YK4YqL3yufHg7G7C1drD0hfFmkdvnarskq53WTCqOVAqy++Nzb wCfVew3rHuAOND0GRwZgW+zXUzLbCWQQQb/m/zvHMUALrsY2+Kdl8X4/xWv0Y7hymFeJpr P3oDmBGDzt9BVAwGA9Alf1mO89EA74Q= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Dhq5frU6; spf=pass (imf04.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713283936; a=rsa-sha256; cv=none; b=OenENi5YaX9wLImkN2CV6NNvC7wx2vLDd7N55vS55YKg7x6F0+9t+7eTYWVk7I4XfsDwiq OmTquvtOxRFljclJrYmupJDiBUSJoXMWiuYp/qLPj7kd7io6bL4Mbako4OVjTzpa73tH+L 8yNST0M1ByU50nN0gCJL6qJjqP5wD7E= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1e3f6f03594so29885585ad.0 for ; Tue, 16 Apr 2024 09:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713283935; x=1713888735; darn=kvack.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=EKrDgIJgNXo/R8quzpUy0yW7erzp8PxvHvcTe/50ujU=; b=Dhq5frU6byGcb1cYiQAS74XL/5CAQUaSfwU6nPGM9oZHKDKp5dNE0KK+KrvgvOGLur fst7w2afYMlI21khxW4VvH6xZamrCqMdD3fVMzqKHHexFyQHVXTE8xQ7zanpGUPAHGVb 51F6M6/ryDNq/rLoHYkwWMRP3usNZWUkaoQ6fsBm7+9JVcBd4Imyw0ki3pxBemPn3eif voWYMr62+2JKzqfD4qVJhVi2RVkAbyEFNGhG2foK/C1zGrwWNNzT+VFHvmJ9dum8fWo+ k+wfzUR8snHqj3y2ig9t1hgRmdI607y9IFT7luWPBFLJDqd2ubfT4i5utf+507zngwEF /4Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713283935; x=1713888735; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EKrDgIJgNXo/R8quzpUy0yW7erzp8PxvHvcTe/50ujU=; b=tUdmWcTnW/lHp5NfVjnEeupsmXG6a/Au2gkNp67huwc8JzxTvvStAoJ3S58o/1s2cU XTDmWUA3Vp7WSMhzEAO1rWsF5TWkkKD1Cfl+tAOq/+n39AAPZ6V4wn6Y48R9cKS9xQuX b13DngoYZy6mvGiOHRqFcM1975G+b8QZNIa+E9+qYSxs4XXWBaTQh+gAStUvizQ2mAZL sw8TPQ9goMR/HM+DUf7KRtUNVM0ZRg5dP19bNEOSe0Vg0oppCa1exCMp0zMpAdLxAvMu 48p2sgc+KTLngZLA97PrbBfivE5KUOYwIWrZhVQlhrrVkKmhLXsMkKRhkc/udeuXnBT+ a3Jg== X-Forwarded-Encrypted: i=1; AJvYcCVH+uGzUTIvAvHiCwGHw555TdMJHT4/ZoptRL5cs04Wks3H5jJgiuololgTCyvKgn8577e1PFhDfl+Zv5gG5s0NQDM= X-Gm-Message-State: AOJu0YxavDQe3GgXsNQfxFBTLfBHiN36xq5/X3asjPNlB16UhbzidMXq cj/y0yVt3OguiqL+gDqjt0hEMH4gxByn0dZJajOMhOArVEMoCSc0 X-Google-Smtp-Source: AGHT+IEaBhKQrtE4y17EN+JRfoZ0nAtlgq9TOIgtvD46kDZyqFoPetYC3y2iMwccARAF9quBrezxcQ== X-Received: by 2002:a17:903:595:b0:1e3:e4ff:7054 with SMTP id jv21-20020a170903059500b001e3e4ff7054mr10328895plb.38.1713283934861; Tue, 16 Apr 2024 09:12:14 -0700 (PDT) Received: from ?IPv6:2605:59c8:43f:400:82ee:73ff:fe41:9a02? ([2605:59c8:43f:400:82ee:73ff:fe41:9a02]) by smtp.googlemail.com with ESMTPSA id lf16-20020a170902fb5000b001e5119c1923sm10005822plb.71.2024.04.16.09.12.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 09:12:14 -0700 (PDT) Message-ID: <18ca19fa64267b84bee10473a81cbc63f53104a0.camel@gmail.com> Subject: Re: [PATCH net-next v2 07/15] mm: page_frag: add '_va' suffix to page_frag API From: Alexander H Duyck To: Yunsheng Lin , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Eric Dumazet , Jesse Brandeburg , Tony Nguyen , Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Felix Fietkau , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , "Michael S. Tsirkin" , Jason Wang , Andrew Morton , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , David Howells , Marc Dionne , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org Date: Tue, 16 Apr 2024 09:12:01 -0700 In-Reply-To: <20240415131941.51153-8-linyunsheng@huawei.com> References: <20240415131941.51153-1-linyunsheng@huawei.com> <20240415131941.51153-8-linyunsheng@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Stat-Signature: 8uuu4h3h1rax4jzs6i7377qm3rp4pyg6 X-Rspamd-Queue-Id: 421494000F X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1713283936-113588 X-HE-Meta: U2FsdGVkX198tRFCC1HSGkMgWz1Z9KpdSkXDU4lS8DYdtQJEGR38H+bsy8734MfqfDOfOhGjzJeoU5OQCOlm5B4Cbcs3EQyhlCPXBc5Wuyc2zclvBFp3nMJ/nDorco0Wujocv2ZFdiY1RfWPO23myREBZc2MIA+kGsT3vQAwzZs6ZR2q9w2G0R6AJeHLKCIbKGiAPRu7pXNXyG1iUcWtT8Xpw77G7Xuvko+2gazb1t8fWJh2IiYNm6yFwCxqGdSsnoUIw66OHNJJU5CckSq96QWVy3hooP8i7LBN+bvQ8MKlaAa1r9MNMsek0187CtpoNadYajMYipnPEgtUxeOhSa+AIeSdXwRdUET71sW+B5ks3gkXo9+DFv8BecfVMxaamNLSh51lqxVZUsl3qyBrxqSFcidZvu1cp0wTddOa2JVhBJsfbffN4EOpUcpp1TwRdYAH4f16k2iHva+QoTqaNXwf5kA32NpGlatXNbWF4K8Iuj/KNP4yr44D3SNMyd4WqcvhCJ/MLPIjaZ7ElSdOz37ggiBIJV8eAv3X50cxPCnGz/QtqRRF2ibxDPDUCuCIEZNdrf/+KRXFwTfBNoqS05u1+Frx8XL/1arLbNfbLoL0v+Cp/PIaU/FTXlXJwdmv0FJoOqcZzB0EM42RoSVKhKryOEW5ZJcI5gmw371HZ7y0kOc1u5JswUZ4N3Mu/PRYze9wC7pwiQxk8a6OJq6Tt6LCUM/bC3QNI/HxC41HhA4LRDPcHBKMBeg4HVz/qWXr/hLnxu5raJYgRE2s9gxMJH8HC7mXT5tu8Vg30587zGvnWmXCg0MzbsMQKGCAxkBWF/7XRByUa3r8T+jBFzscmSnHRQMQKXo+nzpYd1KURmd4pYHsUQlWPyyFmkMfGkeclcpUiJq2kp1D0GtXj3siVPvBvIrzW/07kkTFDOMlqT0EEv5SHJ4hbMY5/JyEwj8r54m+wehInpWm4u8q5mU AvC8FexA NMw0PE9negQ5sxJ2Ux9AChIOwZY1r2T2QLuDjags3tmFHfA2XvaajXhN8whmq7HrSjx35zxClwfTE2g5X+/3ipQF8RyQXvn24GdpGpeWzX8iBCFjqr5CBdqXVAq3ABBa0xz9pqmgdJmca1uL4FgicCNwX/Z5Iqzw94YwZp1T5S3fZgz2dhQSC/XNlHevY8ZNXjZmJMiehpKxYmCU+SUjKYOfrBzP9iF62xgw8QYkPP50+stOYIIPa0oKbUqVoZ4Rdjva/+a4R/Q+DQenMLDGVzGhhS/kw8i4Yp8Ic9j1VYXrLV7i5l+E0R3qGtkZF43xdHlE9RcCqTrEQ0H+JKik3+2rybcx1tnWR/e76aSmrzvINWN1eECx/liEZtabp6l6qXpeq6mU4zHs2tmBLPy/9rY/M3Bb2U7ftSajvfR/U71W7oGypPKkjPIrHzGFdv2HSHPLAu7QK356nhFKAS+6aX6UEzlJGHKU6p0SyUPyPlJS9WDHyKpbSfTrkhw/7Xhj+XTBoJIoHxNdgcAeQtv0WLDaRFQVRzKQKi/TxclDbC7+MzSenFcTF4IrN4OvX2pV6Qhs0ytEeoKe0Pg4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2024-04-15 at 21:19 +0800, Yunsheng Lin wrote: > Currently most of the API for page_frag API is returning > 'virtual address' as output or expecting 'virtual address' > as input, in order to differentiate the API handling between > 'virtual address' and 'struct page', add '_va' suffix to the > corresponding API mirroring the page_pool_alloc_va() API of > the page_pool. >=20 > Signed-off-by: Yunsheng Lin This patch is a total waste of time. By that logic we should be renaming __get_free_pages since it essentially does the same thing. This just seems like more code changes for the sake of adding code changes rather than fixing anything. In my opinion it should be dropped from the set.