From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ira Weiny <ira.weiny@intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Alexander Potapenko <glider@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Tony Luck <tony.luck@intel.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
David Sterba <dsterba@suse.com>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Al Viro <viro@zeniv.linux.org.uk>, Helge Deller <deller@gmx.de>
Subject: Re: [PATCH] mm/highmem: Align-down to page the address for kunmap_flush_on_unmap()
Date: Fri, 27 Jan 2023 18:58:55 +0100 [thread overview]
Message-ID: <1920277.PYKUYFuaPT@suse> (raw)
In-Reply-To: <Y9LdmUw8TkoJOWvM@casper.infradead.org>
On giovedì 26 gennaio 2023 21:07:53 CET Matthew Wilcox wrote:
> On Thu, Jan 26, 2023 at 03:33:46PM +0100, Fabio M. De Francesco wrote:
> > If ARCH_HAS_FLUSH_ON_KUNMAP is defined (PA-RISC case), __kunmap_local()
> > calls kunmap_flush_on_unmap(). The latter currently flushes the wrong
> > address (as confirmed by Matthew Wilcox and Helge Deller). Al Viro
> > proposed to call kunmap_flush_on_unmap() on an aligned-down to page
> > address in order to fix this issue. Consensus has been reached on this
> > solution.
> >
> > Therefore, if ARCH_HAS_FLUSH_ON_KUNMAP is defined, call
> > kunmap_flush_on_unmap() on an aligned-down to page address computed with
> > the PTR_ALIGN_DOWN() macro.
>
> You missed a spot. Sent the version I've had in my tree for a few days.
I'm sorry for missing the other call site.
Furthermore, your patch has a better commit message.
However, I'm also sorry because I would have expected a different kind of
support from you. My patch could have been improved with v2.
Anyway, I assume that you missed that I had asked you and Al if anybody were
interested in doing these changes and probably you missed also that Ira
encouraged me to send a patch, whereas you did not show any interest...
https://lore.kernel.org/lkml/3146373.5fSG56mABF@suse/
Fabio
P.S.: Helge wrote to me privately but you cannot know it.
next prev parent reply other threads:[~2023-01-27 17:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 14:33 [PATCH] mm/highmem: Align-down to page the address for kunmap_flush_on_unmap() Fabio M. De Francesco
2023-01-26 19:50 ` Ira Weiny
2023-01-26 20:37 ` Helge Deller
2023-01-26 20:49 ` Matthew Wilcox
2023-01-27 23:07 ` Ira Weiny
2023-01-26 20:53 ` Al Viro
2023-01-27 22:48 ` Ira Weiny
2023-01-26 20:07 ` Matthew Wilcox
2023-01-27 17:58 ` Fabio M. De Francesco [this message]
2023-01-27 18:03 ` Matthew Wilcox
2023-01-26 20:38 ` Andrew Morton
2023-01-26 20:48 ` Matthew Wilcox
2023-01-26 21:04 ` Al Viro
2023-01-26 21:56 ` Matthew Wilcox
2023-01-26 22:17 ` Al Viro
2023-01-27 23:13 ` Ira Weiny
-- strict thread matches above, loose matches on Subject: below --
2023-01-26 14:11 Fabio M. De Francesco
2023-01-26 14:26 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1920277.PYKUYFuaPT@suse \
--to=fmdefrancesco@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=deller@gmx.de \
--cc=dsterba@suse.com \
--cc=glider@google.com \
--cc=ira.weiny@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).