From: CAI Qian <caiqian@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Hugh Dickins <hugh@veritas.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/3] Generic support for revoking mappings
Date: Mon, 27 Sep 2010 04:52:29 -0400 (EDT) [thread overview]
Message-ID: <1933893701.2026841285577549772.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <m1sk0x9z62.fsf@fess.ebiederm.org>
Just a head up. Tried to boot latest mmotm kernel with those patches applied hit this. I am wondering what I did wrong.
Pid: 1, comm: init Not tainted 2.6.36-rc5-mm1+ #2 /KVM
RIP: 0010:[<ffffffff811d4c78>] [<ffffffff811d4c78>] prio_tree_insert+0x188/0x2a0
RSP: 0018:ffff880c3b1bfcd8 EFLAGS: 00010202
RAX: ffff880c374b40d8 RBX: 0000000000000100 RCX: ffff880c374b40d8
RDX: 0000000000000179 RSI: 0000000000000000 RDI: 0000000000000179
RBP: ffff880c9f4ba188 R08: 0000000000000001 R09: ffff880c374b9330
R10: 0000000000000001 R11: 0000000000000002 R12: ffff880c374b40d8
R13: 00000007fa7367ba R14: 00000007fa7367be R15: 0000000000000000
FS: 00007fa7369d9700(0000) GS:ffff8800df540000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffc0 CR3: 0000000c374b1000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process init (pid: 1, threadinfo ffff880c3b1be000, task ffff880c3b1bd400)
Stack:
ffff880c3b1bd400 ffff880c374b4088 ffff880c374b40d8 ffff880c374b4088
<0> ffff880c9f4ba168 ffff880c9f4ba188 ffff880c374b3680 ffffffff810daff8
<0> 0000000000000002 ffff880c374b41f8 ffff880c374b42b0 ffffffff810e9171
Call Trace:
[<ffffffff810daff8>] ? vma_prio_tree_insert+0x28/0x120
[<ffffffff810e9171>] ? vma_adjust+0xe1/0x560
[<ffffffff8119715b>] ? avc_has_perm+0x6b/0xa0
[<ffffffff810e97b9>] ? __split_vma+0x1c9/0x250
[<ffffffff810ebf88>] ? mprotect_fixup+0x708/0x7b0
[<ffffffff810e4aca>] ? handle_mm_fault+0x1da/0xcf0
[<ffffffff81033910>] ? pvclock_clocksource_read+0x50/0xc0
[<ffffffff81047220>] ? __dequeue_entity+0x40/0x50
[<ffffffff81198a31>] ? file_has_perm+0xf1/0x100
[<ffffffff810ec1b2>] ? sys_mprotect+0x182/0x250
[<ffffffff8100aec2>] ? system_call_fastpath+0x16/0x1b
Code: 56 20 e9 d4 fe ff ff bb 01 00 00 00 48 d3 e3 48 85 db 0f 84 08 01 00 00 45 31 ff 66 45 85 c0 4c 89 e1 74 78 0f 1f 80 00 00 00 00 <48> 8b 46 c0 48 2b 46 b8 4c 8b 6e 40 48 c1 e8 0c 4c 39 ef 4d 8d
RIP [<ffffffff811d4c78>] prio_tree_insert+0x188/0x2a0
RSP <ffff880c3b1bfcd8>
CR2: ffffffffffffffc0
---[ end trace 667258bb79b38e02 ]---
----- "Eric W. Biederman" <ebiederm@xmission.com> wrote:
> During hotplug or rmmod if a device or file is mmaped, it's mapping
> needs to be removed and future access need to return SIGBUS almost
> like
> truncate. This case is rare enough that it barely gets tested, and
> making a generic implementation warranted. I have tried with sysfs
> but
> a complete and generic implementation does not seem possible without
> mm
> support.
>
> It looks like a fully generic implementation with mm knowledge
> is shorter and easier to get right than what I have in sysfs today.
>
> So here is that fully generic implementation.
>
> Eric W. Biederman (3):
> mm: Introduce revoke_mappings.
> mm: Consolidate vma destruction into remove_vma.
> mm: Cause revoke_mappings to wait until all close methods have
> completed.
> ---
> include/linux/fs.h | 2 +
> include/linux/mm.h | 2 +
> mm/Makefile | 2 +-
> mm/mmap.c | 34 +++++-----
> mm/nommu.c | 5 ++
> mm/revoke.c | 192
> ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 219 insertions(+), 18 deletions(-)
>
> Eric
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-09-27 8:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-25 23:33 [PATCH 0/3] Generic support for revoking mappings Eric W. Biederman
2010-09-25 23:33 ` [PATCH 1/3] mm: Introduce revoke_mappings Eric W. Biederman
2010-09-27 10:49 ` Pekka Enberg
2010-09-27 14:23 ` Eric W. Biederman
2010-09-25 23:34 ` [PATCH 2/3] mm: Consolidate vma destruction into remove_vma Eric W. Biederman
2010-09-27 6:37 ` Pekka Enberg
2010-09-27 6:39 ` Pekka Enberg
2010-09-27 6:44 ` Eric W. Biederman
2010-09-27 7:11 ` Pekka Enberg
2010-09-25 23:34 ` [PATCH 3/3] mm: Cause revoke_mappings to wait until all close methods have completed Eric W. Biederman
2010-09-27 7:15 ` Pekka Enberg
2010-09-27 8:04 ` Eric W. Biederman
2010-09-27 8:52 ` CAI Qian [this message]
2010-09-27 9:12 ` [PATCH 0/3] Generic support for revoking mappings Américo Wang
[not found] <86925983.2027701285578620865.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-27 9:10 ` caiqian
[not found] <1345860830.2030761285581270894.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-27 9:55 ` caiqian
2010-09-27 13:52 ` Eric W. Biederman
2010-09-28 6:25 ` Eric W. Biederman
[not found] <1586726953.2193271285663810410.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-28 8:51 ` caiqian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1933893701.2026841285577549772.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com \
--to=caiqian@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).