From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9025CC36002 for ; Wed, 9 Apr 2025 09:05:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26EDA6B015E; Wed, 9 Apr 2025 05:05:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F7556B015F; Wed, 9 Apr 2025 05:05:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 046E06B0160; Wed, 9 Apr 2025 05:05:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D683A6B015E for ; Wed, 9 Apr 2025 05:05:31 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 89069C1E9D for ; Wed, 9 Apr 2025 09:05:32 +0000 (UTC) X-FDA: 83313922104.07.4838C01 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 0C14420003 for ; Wed, 9 Apr 2025 09:05:29 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aGz4vE0T; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744189530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1iDO9MMl4N3RRYmrexFHKDKAzEZh06JJGIlAqH65H+Y=; b=1OZjbbc2WJIJ+UB12GjIUQ05W/QfJBxfN9F6lm7PPKB3YQyRvsePf6wQLsh+WHB2YH2OwB 5I7f0v11K65Wnp0yYAuKF5AAaZ4GyTl8LnMKt2B6ZUkIY/6Oy4F8qCx4V4c0/+hWbFH9Gw zdtCJwqx1VMxpu5kqC6Zs8bGw+KfO3I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744189530; a=rsa-sha256; cv=none; b=vg+l7/m2HG6Hh/ltHnSYI4Gnu0ORmd9VC8iEiOirKr/r+qEopKJ4sPXdfCF9UQPd64gPx4 ZQDlvVUlJNyNH5pulx66m3oD8iE2xO1HVpAF5fJh2hJXt7JRSeFvK/uiExOGIUL8lejRbl NxrioLvqdu0hW9DN7FZwNtlPsgZTi+k= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aGz4vE0T; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744189529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1iDO9MMl4N3RRYmrexFHKDKAzEZh06JJGIlAqH65H+Y=; b=aGz4vE0T44ObkZlbbwWSQ5dBN3yq38n9Oyw5M4N2DvKiuU1qTHJ2r5ZuQSRoxeQPI/Owbt J0ThNkVFiwoDb9OcTad+WSyvZqIjtex1XXQVcnfvr2tIZcJXmeKiJpQjQS3wli7rRcCSVO SUQuoTlVEb7hEuYa6UhDXumeBZs7aGI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657--c0HvMuePdusXY1We6eG6A-1; Wed, 09 Apr 2025 05:05:27 -0400 X-MC-Unique: -c0HvMuePdusXY1We6eG6A-1 X-Mimecast-MFC-AGG-ID: -c0HvMuePdusXY1We6eG6A_1744189527 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4394c489babso31686705e9.1 for ; Wed, 09 Apr 2025 02:05:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744189527; x=1744794327; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1iDO9MMl4N3RRYmrexFHKDKAzEZh06JJGIlAqH65H+Y=; b=u/VTFoVRSxXUl5Lm+Q96ytkn5hQsR9LqMwNCFbdaSS7F4O3/R3FY69pB8PkVZbNy7n +BUYfJZ4mBphzIDMpVflunyqX6akbaFw2aN0RZCYscIELpMLLCd0VF+1nSHkDvSf0RVp OrljBe4s67rXLmx+I2BbMsiGh9v1kFh9+j0xaNyA+7xI/omX4iMsKFim+WGxt0qurOpc MM+UxFDKQDdv2k+WY/5AWZa8iOUGfyPAyKgqU2i80XzmxI+GGU8jQW9bN+prN54rQiKU vdyLwyXzxzMcvWl3s+Kh2XAnY8fMBpzLSpw8fG8dF10pmsE/MI9FxYgCIeMdpcWXzWj/ 6xWw== X-Forwarded-Encrypted: i=1; AJvYcCWGkg7tyKoB23R4eXx6uqSy/MLv0vyShO3xD8vDDZ9PY9UhaaRXYsyl5VKa1INYJVgNa6KF9I2exw==@kvack.org X-Gm-Message-State: AOJu0Ywk0hhzLwvaiyJnAsG7AIBd8/HpWAIwtSWAf4T0LskWist6Iof+ VZhFFsKKhcWoeG02E0EbJEmtUGFuIZ3Kaj1k2orw3ToreMqDnn9QwYZc0ED6Uen05EDhMjlETz6 fKUglPxgtpQb8s5nY9DQWu0ygQunNLoeez5ivB4OsjTE2UgJd X-Gm-Gg: ASbGnctrOLXBbZ+VHRr/bs6v8Y35kPVadu1WDTomS3o9Lm1pFSFeMRLI4jGToC55okk j6vqMOCCMhHNJmEgew5MyubE1UOvlJAP0+V/cYwBUeYyBiI5PjZb1Zb7WcA911LARce7vkB0vBs 4n5RRKnnpsQnKOop8vTCeJmkxYS8ZdlL/d8WpGda7mk38RdekjGVvqGt5Wxrg/bsuffNn8p+w/p SWoEOZhJjTyv6HZKl746K3E57UC/WjKJiHSuRi3mTb1tC7IIheM0T0oMESBezEihpPiGkIAhD5Z YxARg6sm7Vs+NYmKP6XQAiz5tQY9W+DQfnHMsb+nLscr3OnLRjZlCJaUf4FQRMhCgH334pSZl1B CqpuOJW/7OA6vyuPLcTEkzEoAW8CsYwU9Cw== X-Received: by 2002:a05:600c:4f4f:b0:43d:563:6fef with SMTP id 5b1f17b1804b1-43f1ff2f7b8mr11402845e9.21.1744189526784; Wed, 09 Apr 2025 02:05:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEsx7wCRCByNDp3vRMCobQmLS/Z8q3mGWkAI2jHMGbEvurBgQxJ1sSDoc6/fcJT9fDzVWRiOg== X-Received: by 2002:a05:600c:4f4f:b0:43d:563:6fef with SMTP id 5b1f17b1804b1-43f1ff2f7b8mr11402605e9.21.1744189526296; Wed, 09 Apr 2025 02:05:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:8400:ed9b:a3a:88e5:c6a? (p200300cbc70d8400ed9b0a3a88e50c6a.dip0.t-ipconnect.de. [2003:cb:c70d:8400:ed9b:a3a:88e5:c6a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f207c914csm13080075e9.39.2025.04.09.02.05.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Apr 2025 02:05:25 -0700 (PDT) Message-ID: <19562f7e-38ce-41fc-8dfc-bfd6b1259291@redhat.com> Date: Wed, 9 Apr 2025 11:05:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/3] mm/mempolicy: Support memory hotplug in weighted interleave To: Rakie Kim , akpm@linux-foundation.org Cc: gourry@gourry.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, Jonathan.Cameron@huawei.com, osalvador@suse.de, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com References: <20250408073243.488-1-rakie.kim@sk.com> <20250408073243.488-4-rakie.kim@sk.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250408073243.488-4-rakie.kim@sk.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9IVULY1Lg914LHbMWC-PJCCOMQ8p95MPJbAFjsZhBSQ_1744189527 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: bi7aytihpwu496qgfdfjdbkmby5o3omb X-Rspam-User: X-Rspamd-Queue-Id: 0C14420003 X-Rspamd-Server: rspam08 X-HE-Tag: 1744189529-189561 X-HE-Meta: U2FsdGVkX19mFaJETmiCQyBCSQiHx1sKhbEgn0OxCkWNGd7Z72Vojwle7DFDT8LSOaVP3oGmfRaO7LcKXdrd6o87DDuZcy9bqDrSoajj5TygDTEy17uft3ZBIrSwe0xYEOSK8xj/PmgpnvfKJ7bc1q/PMOzB3RSTwQ1DAIeM0jYXLklN54iaSHb0xffGx3nf3WHnhPTD0mnu30lDHhryc81rHS+gNAfa10d397bWBfgyKSS3ttZeNpwbQFO3gZE5XqS789s/J1LjyBXwql3w8DBhqTSaJZiYjZhbdKH7lX8Fe+oQ8144Jb2WNBQb4ANGMvSZg8XF8KUr7q7EH2OsF/dscBRj5MmV3aJaCHs/6r/1ZKSwQGRmwoTjQbt5kevRBypALNAdpVIfJnkldeG3EIpNVya5xczTe8iFJ/zZQ933kB39kKrTnKtAJQgKtalcaouwZNTalOI9Rl+iz6o6+Wk0zi+jaWkW1TMLy/xYuYEuxQQ49VhEwTy+pFmv0bVi6xWzVP3rXwOMvv/55SP83paHQAT6+7X44rWG0MCECgB0wvxCL2PCug7N4BbBtxPS2kSbTue/DTGlEt3VsVmuzrD99pvaFb07XJEQCS93zxzAPUve5aGqPUC4k7m9gDMWBShSrKYVB3DfZ/YQzJKoY+zhADZtvV2L+YC0yrQFrctLxcKmzVq2S2/uSqcM94MoG6eLMJFxHZezvlC3w/G+mKcVnX5OYtkLHBNTH7h3G+mz/SZduP9ChP0a66Orh6cRRryyZN/CBN5RrigwXNtMW1rFOwwdRy/LfrLHvbPOytFJyiByl+WWc8OxnI43PR/nJC6xQIay5y5ZkOz8Birl4MBebHPuS7Z5lmyeA3KawepB3O7K/sXF14QBV4GuPMTYxbslUM8oxNLeme4DZRHGdEIYhxUtxmRpjvx7d1Cl6xTIhCTTX+8dbBYnaoiYUmmGmybFaNfeAOPttsxzka2 PmG31rRY mhW5zh5zmn4WIrl4LXQGxgkYT3jD3trNZjSnoQg/8tklEHKzxcclh7uRIBo7Jr50Fi6XcWIp4xPH16RqZRKu/oEGWseZr3oBzBGbEwvYoqnnu68koLch38XjU69/G44hE5Ieym0hNJD8kUbdYVPlndaR2uwrNAiqgKlO7PgaliTTBsYYLJQJePjbBJqpQw1Aq4r4bbO3iweUISXOV5h02by1A4b11Un/2zGy+4qQohHOxIrV8HJN/S1fiB9I4pDIQRRgdfHKnFpW1mGduaieGpyiSIqgiKNP2q4erSWpNRYIYdJf0WFrjJqOg1W1nSE6KP3Cqmxtfdvj+vm4AHVwznoghaP4kNXLMWOSmwZAsNdzu/JihUKH0wI/IeX9wdYjdpvrDCaatbJJYWzU8SQbjVXCYRDkAOKs2nv3ALaRQH4HEB5koMo9cQhBuikrcf0RHx7zmAsfVjfPqIr3IGM0RmnK0HmMYnS+yZ9qVJrrdrc18X6kp0VCZ8udX+7JVm6UzzuyLdERbFg03tRT4Nusy+70bvaGS/OWgNogoBH0q+ekZd5jAuLQ4RRMNgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.04.25 09:32, Rakie Kim wrote: > The weighted interleave policy distributes page allocations across multiple > NUMA nodes based on their performance weight, thereby improving memory > bandwidth utilization. The weight values for each node are configured > through sysfs. > > Previously, sysfs entries for configuring weighted interleave were created > for all possible nodes (N_POSSIBLE) at initialization, including nodes that > might not have memory. However, not all nodes in N_POSSIBLE are usable at > runtime, as some may remain memoryless or offline. > This led to sysfs entries being created for unusable nodes, causing > potential misconfiguration issues. > > To address this issue, this patch modifies the sysfs creation logic to: > 1) Limit sysfs entries to nodes that are online and have memory, avoiding > the creation of sysfs entries for nodes that cannot be used. > 2) Support memory hotplug by dynamically adding and removing sysfs entries > based on whether a node transitions into or out of the N_MEMORY state. > > Additionally, the patch ensures that sysfs attributes are properly managed > when nodes go offline, preventing stale or redundant entries from persisting > in the system. > > By making these changes, the weighted interleave policy now manages its > sysfs entries more efficiently, ensuring that only relevant nodes are > considered for interleaving, and dynamically adapting to memory hotplug > events. > > Signed-off-by: Rakie Kim > Signed-off-by: Honggyu Kim > Signed-off-by: Yunjeong Mun Why are the other SOF in there? Are there Co-developed-by missing? Acked-by: David Hildenbrand -- Cheers, David / dhildenb