From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAB1AC54E58 for ; Wed, 13 Mar 2024 01:24:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 297218E002C; Tue, 12 Mar 2024 21:24:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2467C8E0011; Tue, 12 Mar 2024 21:24:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 099678E002C; Tue, 12 Mar 2024 21:24:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F015E8E0011 for ; Tue, 12 Mar 2024 21:24:18 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B628E40591 for ; Wed, 13 Mar 2024 01:24:18 +0000 (UTC) X-FDA: 81890270196.14.FCB0481 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf21.hostedemail.com (Postfix) with ESMTP id 5F3D31C0008 for ; Wed, 13 Mar 2024 01:24:14 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=D+IvQ20z; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xPSXxH0Y; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf21.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710293055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xYI5MIn1Zdry7bE+rELECrm7x7MpMaYOlPrSkbQRovE=; b=nE4jI0K63grDme5V7Xd8KRVv/yGMELnzjzP8OAzpVauhMnXrZIRBNmKePDYLRmku6LOSap gsXM5IKH5+GTjfXoXe2BZKTAR6F+gBCPnkPP8hLvfiaJSxGvR4XAVfwJMf++vb1jrSOfXc DApTDn9enJaOVaVo19CI10nG8wKXuBo= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=D+IvQ20z; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xPSXxH0Y; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf21.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1710293055; a=rsa-sha256; cv=pass; b=RpgWEnr9cSW3P1n/dqpxd8hhHrJnGJSsTjfLCT7BJWVAicM5d5FRCcqxUesljet2dvs8qt ng6Om8SU/umNJPuEslW79VGTZaK9EG0IP11D5SfdwUr/VEj/gGDDLi7jVq81qbiyx/HMvG 2b8s6A082oODxibk6qNLODCpc4Ji0cY= Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42CKPued016601; Wed, 13 Mar 2024 01:23:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=xYI5MIn1Zdry7bE+rELECrm7x7MpMaYOlPrSkbQRovE=; b=D+IvQ20zsl5/Lefn3cnIVZRVZDE7IuERTB2d9DcSwCYNlIf7pHKL92c37Bld10/IFSh3 M21g+DSe6Txh+v90LeibYgFX35FxVMFnM73+MiBSH1njys+hha2xdioPR4Qcyv7MyPnr Iuli+bjqKfl2jrnUz+qmFWhsAQblqQ0Xd1IOxRCgCHV0gKGQpgVuPOLerD7Q4omu10qC oklZ7XOVfydj5eN3xQiYsuzx0DJBuR2kusVawD/pYMTWwQK1n/kQ+mvyY2mES879j+4U A/OhjGUveB4fTvDbQFKO7UU+K6NdGT7z9AJ1N1U0f+RNt6Df/Mhtk62UoAPAmW8/ym72 1A== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wrftdfnn7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Mar 2024 01:23:58 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 42D0Y1Ro009075; Wed, 13 Mar 2024 01:23:47 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3wre7e9mc3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Mar 2024 01:23:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I34l4cVcQurtgxKKbxkFZ7DluZ/KksV3gifGRCMzFSH60G1uJ/ZOnwgg/mYrjMMxaadT+00pZjQOx7bwtQmCDJV11IO4H/DM7+ljePbbGBGg35fT4QG1rusG23Xz3Ucll/GlNcmPqZsncX8mlp+S3RAYLlYRED92+BP0ieh0vUPxIjCIhpi7WU9c6NDdra1WXrBu02UCiLQwjmVQ65toxguA+2cEDLdUy5YDvdwQLLWJcFvEocWZmRvfJf+MFU+517Qu9hYeFNA79zUDNnh4is4vapEkUyNbDs5puqbx4aHnqgcpmos14aQmWT6+9fSxYFO7KkfLfnPQd6QNPI9TkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xYI5MIn1Zdry7bE+rELECrm7x7MpMaYOlPrSkbQRovE=; b=UZCllIDSSk66IbZTDX+AhPvvU61/js85/x+rzkPnXw8e6Vugb7hPTVrD0XaTpRjr897f0Ud5OK9a59Pqza0PN2lLe0kqjqg23txd0GOxJI5ouG+lx6NCaf0eQTe8x26OANMCqQ8alvEoUA4C+0jBbDDW8i+WOFU3TlMSRfGY8tblnUreUqRVZX3+UT9J0hMRtqDs0FghUJrbEDxM+t3qoM+03XIT8UhgnmUM3d1kmHhGN4UmQENhySf2bIno6tmf/zlnTNywqGMyKdWIa0o5eI3H0l+LXV0EWL+8lrtD8AuoLVyd7BZI+Fbes7wVuXLEgPhvnNC0dLw8JF45UjfvbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xYI5MIn1Zdry7bE+rELECrm7x7MpMaYOlPrSkbQRovE=; b=xPSXxH0YVfxA3bMHIAF6c52f29BO0EQieeJKYAv7TtatT1Qdo7JtVuvYGYzN784d/2jJZnTC8a1kEv7Pll2CyngnB5HJDq7j8gNmJdgI9aJeS919+UBEAbBBoW2z+7sycvT1MpzFLnEebYazipySLWb/r+h7TO9MYb1OIcVF9rs= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by CH3PR10MB7647.namprd10.prod.outlook.com (2603:10b6:610:169::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Wed, 13 Mar 2024 01:23:45 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::210e:eea7:3142:6088]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::210e:eea7:3142:6088%5]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 01:23:45 +0000 Message-ID: <196d00e3-4335-4f8f-ac51-5ccfa5ef5f75@oracle.com> Date: Tue, 12 Mar 2024 18:23:43 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] mm/memory-failure: Convert memory_failure() to use a folio Content-Language: en-US To: Matthew Wilcox , Miaohe Lin Cc: linux-mm@kvack.org, Naoya Horiguchi , Andrew Morton , ak@linux.intel.com, Jane Chu References: <20240229212036.2160900-1-willy@infradead.org> <20240229212036.2160900-7-willy@infradead.org> <5eab08d7-ae38-4f99-401f-f361466e34e0@huawei.com> From: Jane Chu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BY5PR13CA0019.namprd13.prod.outlook.com (2603:10b6:a03:180::32) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|CH3PR10MB7647:EE_ X-MS-Office365-Filtering-Correlation-Id: f726a14d-cbc9-4773-018b-08dc42fc39d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QUX4vS+bvvgaovdStJpB0L+aonkOSPLywKIi8HeRaCZQQhp42zAZzAiA28L43kEqyGioTxtGQJw2i9IzX+x9P+6uogx3Pb7dr6yw8OME//TIS98giwOxTq6KYN3qLaKZr9c95EJ9m14syq9MK8kGgL35vG1nZ/ezGBTv02COpNIo/hLDyXM4nDSdcGdYZtxwFTO6R20oW//XWo1ZvlergjuWM0bmInGf8xkaUjwmIjxG70yK+sDOlkpVtpuojuWWNdOtn4gJfrHeZvTKOAnSWL4OXx0q5nV13XE4NwOfWrDPYh6mIVD1aX/0BYwJxQgXjwXkzMV5oEsurVv33/2hdjFZqzf5QfhMPhqrR59fFMnj27cCawtw5O6PD982/kiTshTEyMlrm0UbfpecqEAHFZdHs0UE4vJUdhAO5H+PO8KsaefDZkFsY6ajWphD9sa5UFGWFf/fg0+bSj0ihj+5pHRxbcqUb2pWmJthCpMgqovaAMzgZSETa88cxCKUMPhliozLSDP4hQpZ6zGuIm8B97HsVxAAd4IVkd4VF1TrTEeXPG93qXMNNmL+He2MKG43/BJRerlcYOtp6N+RCSJYDq7paY/7kzJy4KiAwpLGpNVl+w5V8lEk+CufvORYCAt4hxD+asbxji9HkU7+ZzYn+Bcn42NmnPnGtnogr8cWGlQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RStjbTFSWEdlazNJY3pvQ3ZIUG8yaVRnVVBsa0V6NUkwdy9rdURpWGtIbHY1?= =?utf-8?B?U09IMnNYTmsrSjRhQkVCdVNMZ3JRNWpDQng3S2tLQ1o1b1UwZHNYN2JGK1dB?= =?utf-8?B?Q2FvaEduWUlnaHFOSkNtTW9jVWNBaFpVMzd0QTZSQm9WZDFSY004YzlJMWQ4?= =?utf-8?B?MjdMQkQrdmZnVjNqQ3huUmNhK2hFb2FRTXlNTlFjZTVxUVJMRzg5SEJoMXU0?= =?utf-8?B?b3JRNDN5UEoydUNQKzlSOXZWM2RPN004OGw5NEU1QlA3eE4xREwxNGFKekFj?= =?utf-8?B?SjFrS1AzaFpCdVhXM1V3cFV6TnhiWmlDZGYvQWh5cnlDVkwzV0dLalgyZVNu?= =?utf-8?B?OTF6T013Z3Z4MVNFakN4L1h0bnN4M0RlNWE4YVFZZkdKVHl2dk1XVy8xVGpm?= =?utf-8?B?OEtPZ09UZGdTdi84UkhrZk1HQUZvOXdhT0xtbWRTRUh5UVhOczBKVDBMRWRy?= =?utf-8?B?c29ncGlMdVZDWmZIbG9WMmhTTUJ2OFVBUitXemtBZ1Z1RXByZFUwcW9pNjRk?= =?utf-8?B?QTB3YW9oRjVUb2FWb0tUc0ZLbmZmRGtiVHkrR0FhcWdnODFENVppc3c1eHVO?= =?utf-8?B?S2JPbjZCNm5VN05tckZKcUhMb2tXU2xWZ0ZxWEFVUm53aDN0UEc5RnZudXpt?= =?utf-8?B?QUdMT0N0ZktzbkY2SkZHblZISEpwbHRQTnNzd2daSTNESERSdVNFVDdMSnM4?= =?utf-8?B?UmNwS3hsN01ad1Z1NTdINHVkTE5PSnptMHd0RW8yVm1WOGY5WFhWVllsdXh1?= =?utf-8?B?QnF0Rkt3N3EyclhUYU5WQkFPMnVuYXdCdEkyUzl1RVNLbU10U1A2NVh1cHFY?= =?utf-8?B?SFBuUVZad29JUkRhbmk2WHNUdHVZQkpTdVNBa29YbmsxRXdtVm9TTGsvb01N?= =?utf-8?B?aVVhOVVhYkRCV3p0d050VHVpaDdGOFNIM01NRnpXaVdsblo3b3Q4Nk1UNTU0?= =?utf-8?B?c0NuVW85TDFmdVJ2bEtBdVFSN3FSbmJ6RHlCNzNJN2xvb0UrZGdZWllpWEVW?= =?utf-8?B?TGhGOCszRzY3TjVtT0FTSHFLL3pqTzZOc2ZGbHY5MlExRGV6bllpeGJVbFBE?= =?utf-8?B?N3BYc3Vpa0dyNVM2d0RHV3NTUzMya2hPcGM3REpzZDdBZ0c3K3ZIcUUyTXBY?= =?utf-8?B?YStpbThBQm1FYlcxMTBFbXI5NlZzZXF1UFlwRE5rVGZoREhpSXNtSjgwajIw?= =?utf-8?B?RGdMSloyTGFuZzAwUC9sTVRoZktZZSt4ZlZYNm4rWlBIMWRUWXNZekUrYXJJ?= =?utf-8?B?RzZNcEdPRUJoWUdUK3RBYWhMVllUMk1yODBuWW52YXZnbFZCZTUwNW1NNHVY?= =?utf-8?B?TGMzR3BpWUlNQjg2c2RqMmFUa0pIUXMzUVgraWE3c29sblc1NDhLWENFZTZn?= =?utf-8?B?K2haS0tJc01OcExXVC9EL3VnU3F1enhEaGhtd0RHWVJuQnFzT1liNUtMMjY1?= =?utf-8?B?UnJyR2VSN2ZMcFlRNGMzaFBvd2owRlhMRkpSOFRacm5RMG54cUU4VkQ4THVw?= =?utf-8?B?ZkVPTTR6MDY3SDJqb0hsWThDTDZDU3BaZEtndENwZlFhWGFWenNHTGkzaVlO?= =?utf-8?B?dE1kMHdwWkZHaEE4N1B1SXhneFZaL2x4ZTZHMUZTNHNQamhaSGltUFozYmxC?= =?utf-8?B?YTRxUzJpTW1NTlpOeUlHcGRhSGlYT0Q0MmxiYytFUFFsUHZ4VGNlWjJDVnMx?= =?utf-8?B?NWR3V3FLSjdGU1FLZEl5RUkxVGp0M05vbGlMR0xBT2owNEhMZ3hOMUNJeG5l?= =?utf-8?B?NWdaVmV4QnQyQlpGZEs5YzJEZ2E1VmxSVlhMaGIzdklnU01RR3FBY2RZZjRW?= =?utf-8?B?dk0zSHg5YnlCUVEzTDI4WlU5YmROVlRJUXVNRGtaWmg4ZGY2SnJkS3puR2pF?= =?utf-8?B?aFJBdHR3bHl2c0p5MTE2MzdsRTZUa01rSjlBVGR2ZkM1WDdvaDJmWERJTGpo?= =?utf-8?B?ZlVaVUg4MDJLYitmTklZUnZXMzBxai9VSVVFQlVZRkE0cnZWeDgrbXhuN2Y3?= =?utf-8?B?WTJVUDdLeE9XSGhOYXVpc3lkZEx3UUt6b21xSnE0ZGZ2QzRYVXJOTnM2cjdC?= =?utf-8?B?R29sYTZ1WnFYc3RMcTlJQ25wUjBreTlnTCtObzNtdUE2UUF6QWZWV0lNSStQ?= =?utf-8?Q?S0A8c8fNViREvzrmariC+753s?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: lvLX7MO3xZHWBue9a54RvYHewN7fMvVU2o0VQaMNuop5oh5nbYMrXA05mzmKIuv2/P5bQH82t62NqY+32+oIh2liYgs48wZ+WTP2g44l2AZyiJJkrR3lKMxXCgf41RH3dVsWPy7gx6mB+eMRrwdkFBTs6zjHHIBlzKCdBHi7B2PeHs2zU9BNLsEWP1PoytlVXGTsZ+m2m7DT6XEKPfk8rmb24DMe/qromP+XeGjqa8vInlPrNw0nANEmiOK6ozmwxzHNQvsEYrwOd6Y5JVz2aoNmgQOZZ+40BVMWDMkeLydL0VPfkNKa33+zOFaVTTQA9uHRAGlut2YilRkuw1kFKSKpa/eWzj6fJ63iemXe/vmU66aOD1kLa5RQJM28ilejF4Zl8Suv2doThHqlSds/U0qi3rlCH7uKpGaR80Bvi7yVW1+vuVJBzsmBD2P3QFeGFqT36w9iLO4HIa4gWppUD+0LFCC9MgYSbg4vDXXYmmU2cgvnKzqNSAPwTEtlyr3yqs7r8KryxMzQOlNhxARkF8yjwi5P8nrHcDtCS0+gX6Aq+FZqOEl5KLfK1yQcSsQOBqf4lrX6A5VyfAiFxBC0HxkTwflZT8ACMIo7d/sopKk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f726a14d-cbc9-4773-018b-08dc42fc39d8 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 01:23:45.0615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0MoGftq7/6OB6BCQZhvV1jVJKpYjP25UJ+7OtFWBekRoikfOiDME7r/IwZP3qdJbLu7qrfZa6Pbrl7C7kaD3cA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7647 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-12_14,2024-03-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403130010 X-Proofpoint-ORIG-GUID: _mm-Rrb6fuTf8158akLh315XKx_GoasC X-Proofpoint-GUID: _mm-Rrb6fuTf8158akLh315XKx_GoasC X-Rspamd-Queue-Id: 5F3D31C0008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9a4itde4i3675m16no5x39p481tcxfth X-HE-Tag: 1710293054-262729 X-HE-Meta: U2FsdGVkX1/TvbC4D/ZCTyME5nn8pAvI70o3mQH/y/OZ3pIzpA0mEmxx2O0edEW4sevNzuLA6/4xvR5MazYpZy+0Ppl73fI67RW77uNwQ6Pggput3LwIYeESZIRQkuZh1xY3ZKbenlPJG07ghFSG2BtxwwZSNJ+sBviM5FpExqfZHxLAnk/Zpt3hCbsiJ5f4aBwt9f9jELrBoC7WskTsvLwUGSLQ81xP0ve1n+2wOLg8xe45AtnGo+I/HebClHpsrKxhHsU/gjUW5pAb7vonGIDaUZb2ioNrv4HwVr9dcjx7TLs2JwCD4MsrJm3FzhmL8YOFx/TzDpXdRGOwxjDW5wyhnzVC0OAurM5taQO2V+M7fl1NT2SdGx7FIFuHCFE3vvcVutzbTdp6LCgdr8fyXnAr0XDh7SNDqdQ3/15ZLKx4zP0nktAAos+wV2wLP6toyLd/b3pD/3g98qgWg6C73lH8todJnSAu+Cjq7AS/wQ8cH/RZ/m29aRnbCYuRPlBqd2aVnVXf/EBaj1IfGSF1kbhWnxyTYNwSBOR6P8AU5To+Elz3oDvtWrh6umqomtWaHXKYM1NPxEyMqs93irlT7hfHuXul7xd0VIeCisB8OklY/iB6ahmVjPZJnYbMHhtgLL1GRNuh3JfuX9lwzdRgdWSAvAEwtp6KCv9Y02RxtY0NcJh98cAkFr+gFo88P17L/WuRWdAdLG8gp498Apz+zo7EB/H+S0gjcRDG9CWS6ACJn6MIv0KVtt+7E37mfoz8hDszKh6DZpYfXlZe99UVxdcYftWtSG5i6eam9uh7dQVWgkY5lZsUuhK0Lt6qILlAQUmfzBGUiMLpMqYV+E5q68mbwjeOMbSzee+s1nHVVs77IuWwGm9OdAfDqmODaxP6gE2dL6cqZLlEDwLq45pyAyQmH1/29XrqEwxqFB/xAJUf6LguqMEicwpN4d08pURHHi/ew2L16Sp+mddOagR IzL7ifxT wgh/8MDcp8sJeMVG9XZgnr50ved4RInk6EPv0wXUV9MUuPD45yxPTj7IJx2PspGXD7dSlT8Ojy93xdiGGQwTwL06PNEuYwIIsZsqsOMhwU6ZC7C8EPIsdhgHHpoWmz3CVOI1b X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/12/2024 7:14 AM, Matthew Wilcox wrote: > On Tue, Mar 12, 2024 at 03:07:39PM +0800, Miaohe Lin wrote: >> On 2024/3/11 20:31, Matthew Wilcox wrote: >>> Assuming we have a refcount on this page so it can't be simultaneously >>> split/freed/whatever, these three sequences are equivalent: >> If page is stable after page refcnt is held, I agree below three sequences are equivalent. >> >>> 1 if (PageCompound(p)) >>> >>> 2 struct page *head = compound_head(p); >>> 2 if (PageHead(head)) >>> >>> 3 struct folio *folio = page_folio(p); >>> 3 if (folio_test_large(folio)) >>> >>> . >>> >> But please see below commit: >> >> """ >> commit f37d4298aa7f8b74395aa13c728677e2ed86fdaf >> Author: Andi Kleen >> Date: Wed Aug 6 16:06:49 2014 -0700 >> >> hwpoison: fix race with changing page during offlining >> >> When a hwpoison page is locked it could change state due to parallel >> modifications. The original compound page can be torn down and then >> this 4k page becomes part of a differently-size compound page is is a >> standalone regular page. >> >> Check after the lock if the page is still the same compound page. > I can't speak to what the rules were ten years ago, but this is not > true now. Compound pages cannot be split if you hold a refcount. > Since we don't track a per-page refcount, we wouldn't know which of > the split pages to give the excess refcount to. I noticed this recently  * GUP pin and PG_locked transferred to @page. Rest subpages can be freed if  * they are not mapped.  *  * Returns 0 if the hugepage is split successfully.  * Returns -EBUSY if the page is pinned or if anon_vma disappeared from under  * us.  */ int split_huge_page_to_list(struct page *page, struct list_head *list) { I have a test case with poisoned shmem THP page that was mlocked and GUP pinned (FOLL_LONGTERM|FOLL_WRITE), but the split succeeded. thanks, -jane