public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: "Dr. Werner Fink" <werner@suse.de>
To: myrdraal@jackalz.dyn.ml.org
Cc: linux-kernel@vger.rutgers.edu, linux-mm@kvack.org
Subject: Re: 2.1.91pre2 death by swapping.
Date: Thu, 26 Mar 1998 14:00:53 +0100	[thread overview]
Message-ID: <199803261300.OAA25495@boole.suse.de> (raw)
In-Reply-To: <19980326034544.27868@jackalz> (message from Myrdraal on Thu, 26 Mar 1998 03:45:44 -0500)


> 
> Hi,
>  Well, shortly after I wrote my previous message, 2.1.91pre2 died a nasty
>  death. This system has 64mb RAM and was lightly loaded, the main thing
>  it was doing was playing a MOD. It started to swap out of the blue, the
>  mod started skipping more and more, and eventually stopped playing
>  entiredly while the machine thrashed. It continued thrashing for 10-15
>  minutes, every program totally stopped while this was happening. Using
>  the magic sysrq show memory option, I could see that the free pages
>  number was fluctuating between 10200 and 10250 or so. Eventually I rebooted
>  back to 2.1.90 with the magic sysrq.
> -Myrdraal


I've found the following piece of code in the 2.1.91pre2:

--------------------------------------------------------------------------
--- v2.1.90/linux/mm/filemap.c	Tue Mar 10 10:03:36 1998
+++ linux/mm/filemap.c	Wed Mar 25 13:13:36 1998
@@ -150,6 +150,10 @@
 				}
 				tmp = tmp->b_this_page;
 			} while (tmp != bh);
+
+			/* Refuse to swap out all buffer pages */
+			if ((buffermem >> PAGE_SHIFT) * 100 > (buffer_mem.min_percent * num_physpages))
+				goto next;
 		}
 
 		/* We can't throw away shared pages, but we do mark
--------------------------------------------------------------------------

IMHO the `>' should be a `<', shouldn't it?

... and the better place fur such a statement is IMHO
linux/mm/vmscan.c:do_try_to_free_page() which would avoid the shrink_mmap()
and its do-while-loop.


          Werner

       reply	other threads:[~1998-03-26 13:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <19980326034544.27868@jackalz>
1998-03-26 13:00 ` Dr. Werner Fink [this message]
1998-03-26 14:18   ` 2.1.91pre2 death by swapping Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199803261300.OAA25495@boole.suse.de \
    --to=werner@suse.de \
    --cc=linux-kernel@vger.rutgers.edu \
    --cc=linux-mm@kvack.org \
    --cc=myrdraal@jackalz.dyn.ml.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox