From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B18DCC5B552 for ; Wed, 4 Jun 2025 06:05:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 341416B0597; Wed, 4 Jun 2025 02:05:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F2A26B0599; Wed, 4 Jun 2025 02:05:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E1506B059A; Wed, 4 Jun 2025 02:05:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 003206B0597 for ; Wed, 4 Jun 2025 02:05:54 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9FE09120540 for ; Wed, 4 Jun 2025 06:05:54 +0000 (UTC) X-FDA: 83516682228.24.9DF84B4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 1FC06140006 for ; Wed, 4 Jun 2025 06:05:51 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eWlEeDv7; spf=pass (imf23.hostedemail.com: domain of gshan@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749017152; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/ltLi5ra24Jsb0STBHkenR2Lb1EgkF/r4FbLJPR1eTI=; b=HipxWfeTG/kJe1jSqWw+d44czLv2qP9oXHJxXm5alcBWPq/wsa+PNaMnGjr7lBnhl1+BIf DNkqZjp1YOxs8ZSl2SHVQxB/e5kfPxu7cJC15MU5ZRiDkwwB520rncbENvihhnNCEhA0F5 eh/lFp8axRkrQO28wJm2e1X3EBR239k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749017152; a=rsa-sha256; cv=none; b=HQk6HSN3WSXYJbu/G7DcUIdat8DQYJ795cFsURh5HzF6lVnzu6AVYLVBbr2ircQ+Lizai9 zRPEtxsgbrIcBxUdnff6J0KVCbugwqIUER1tW4ydxQaPUDpUWTbPvdtMo32gk2QU1nAScY Bj0FNoLDr5MD9yan0jxvd5GI/mGtzmg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eWlEeDv7; spf=pass (imf23.hostedemail.com: domain of gshan@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749017151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ltLi5ra24Jsb0STBHkenR2Lb1EgkF/r4FbLJPR1eTI=; b=eWlEeDv76/X/+FjRwZdVg1vLj+o9J7Tkaf1bZVjy1XBVzCYCTwhVkvmrb3ecUXYTgTnCIX wUTOI82AxM/4yDH9HxoM/aYgvOYn4KN/TdHR+Yb20et9fpIEAnaBnSMg9o4ZPaJAgVslri MMks1mh4AILJMPOBk3vvbQUv+DNVPTM= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-ht3XOYBtOOepJQ65m4PI2g-1; Wed, 04 Jun 2025 02:05:50 -0400 X-MC-Unique: ht3XOYBtOOepJQ65m4PI2g-1 X-Mimecast-MFC-AGG-ID: ht3XOYBtOOepJQ65m4PI2g_1749017149 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-73bfc657aefso4688604b3a.1 for ; Tue, 03 Jun 2025 23:05:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749017148; x=1749621948; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/ltLi5ra24Jsb0STBHkenR2Lb1EgkF/r4FbLJPR1eTI=; b=W9mzN5avcWGb544ELl2glYC+YsxCOE705sUHZlpii+Hww3FJueODFD72fWUAG1gPRZ iybAT3FNZLa/gNSsUDDeifR6qLyHKvJm+RMCJSeMiE1Fjoq/QVViqqSdn19FW08STVLo wHiWVHeeE9zYN1qv7Xt7KQUEd085Bh0LyNBmpCs99wiy9CHnFmcbB1As7D2Sl3Toh6Vh pzXc4wxDuIAaaLP+sSeb3G+SZJQuMEhjvuH6ssjDk8WFHraS+u+Bn5u3phnRbsCurNhb 93+Gm9TeG68dRGn1ENbGi71uaQFoF4Px0EaZMhLqVKedYRVt8s7IubNn9fIukC05Qn/P C9RA== X-Forwarded-Encrypted: i=1; AJvYcCVjfE7G0I9bfemGSWJfQGMs2DSHj/7G0IO/xkCaKVRJ5RQZDsCve4lM483qzzkbj4/V28TM/0bMAw==@kvack.org X-Gm-Message-State: AOJu0YyOdzIAZ34CCEucl5wv9VPTvwusXOTCiWRbqbHgiEIRpHf4IoXq VETW0HQJonFJV3vdLHrr0e8NSmr4dte3J5fWUYGRSpkBVdbSdVNleJUVPIxcA97GZR5/pUxW1Fe r17wPuHBEidvNmGhU31631BQDn1dr4VG7MO2gIQ6BvhSjZi+P/KETgfSfcMPf X-Gm-Gg: ASbGncta+buQfCW5O5SNfOGyfdX2Y6RS8s7WvXhboOUo1aZuZviSuKu1TdrFjUKHz4R BoRfnoPD9fAOpHKUitZYURl07EuI7RvYjG9n1xL7s9GIxLq5zYd2GLlRND8u0bfhZe6OP+7QUqp iZRo6iweVrEz/AkWmD/Qtc1a92Zo7O8kW0IDRs70J1nIxQGyhVhTzq5kNJCSlJuQEc3q43lD2pQ NIci3uxw6coHZjFvG/prUQN0Asj7nv2YXDXd+oZghiudJ+VDFYPc/3VqehOMzW+VFS7A12tyjzv bKln6oAOztv+lgGQKBEXzTfkOFv6e/pMSm/Q6Hg8bD0LWfcPBf0= X-Received: by 2002:a05:6a00:1488:b0:742:a91d:b2f6 with SMTP id d2e1a72fcca58-7480b41ed78mr2603751b3a.13.1749017148486; Tue, 03 Jun 2025 23:05:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBsfgsaAmGId0zrYF9y6DFo02h+riK2t8uOhUFLQymVW6YzwyhCaemYYcLF8v0T3nQ6io34Q== X-Received: by 2002:a05:6a00:1488:b0:742:a91d:b2f6 with SMTP id d2e1a72fcca58-7480b41ed78mr2603694b3a.13.1749017148117; Tue, 03 Jun 2025 23:05:48 -0700 (PDT) Received: from [192.168.68.51] (n175-34-62-5.mrk21.qld.optusnet.com.au. [175.34.62.5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b2eceb0a005sm6938285a12.7.2025.06.03.23.05.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 23:05:47 -0700 (PDT) Message-ID: <19aa8bb5-7133-4005-a808-8cdc8a7acfc7@redhat.com> Date: Wed, 4 Jun 2025 16:05:27 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 12/16] KVM: arm64: Refactor user_mem_abort() calculation of force_pte To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250527180245.1413463-1-tabba@google.com> <20250527180245.1413463-13-tabba@google.com> From: Gavin Shan In-Reply-To: <20250527180245.1413463-13-tabba@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NZFgyO6wSjaFXfO_9mWhQ2x94pk2bgNq2Gk6caTJZUU_1749017149 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1FC06140006 X-Stat-Signature: dd1h6g3m4u4tc86mb9ynmyenngsc7fuj X-Rspam-User: X-HE-Tag: 1749017151-838715 X-HE-Meta: U2FsdGVkX1+egfK/YTMAHeZaAc+5veeeSwMlrZVhuLLfdCX/TjqGRdDd31r3lu3Djliogk1dJcytonKnXfT7XZEehPhee4Of39E06pt4nbC/yMfd11vD4vgwbRdnqGW3FIsWLNcaZdwFpSRh8htQvCVqC6hCU9r7fxPzWxTW9Bvbbr3mCcLre+Luai7g/UxlWvNJ+OwYq5Dh2TjqBYzdYEGz3x+hfJ7NKjabTsSfIDVNkwowqDmEtlrGKsDYoTG9+K1c4QQo5FMSstn4QeH+9jtlslLaRHWFRIMRL5OKWExAjzUpoq8NMOzCRtivCjqrgs9aPLAMLy9t+jO2J3GdtIlK8U/4eKyMERP22FB/ofZu9bqN077kpV9bBeIukX7FVEFOGyBh0djX5A0+mhu5Yf6w52shC+Rcdcl60WDTgyGl6TbecwNZIhrk9asKI6roWnkKzuYyJ68QkkebGQ4wXiCVVZqnvfHyD0EaBhrBlUZOEllwIdbanFOYk7Hto9viiVtyQB406xlK12SVb7+qXyuxq8JKOejdWifyH2G7pcfY9MdaHi0NjZyadPyb8i1geg/1SmRkV/y7nre9l3NGBaeYcGqH1RNgE8dXGTrkzccU0VYs2E9kLxIcCYW9pUpTTcrPn6qdekr7TzRwvlc+kD+msJFni9FVo3EluPrpzF0bR5WsEFC/7pH+e8MdYVchwH3/uOprWf1c5UBltwvPHnzdmOcSaEogVzSG0NSDIZwC88S9tkd3isUOTgfq8HF/oJDRN+HPjp1tkmXqGwNPlP2FJxwezsNiAy3Ay0cElEea5eO4mhxsDJw74owZB5z2W8z0ReEX7BtEPHvbD16S5NAiAQ/SVTzHJQKBVhWBMu7YRblPrAj/9X/UPdFX3W/9l6VX8Aq6WlCJzEI4ZHU9arbA213ne7cdzg2xExU3gBz4wo3pzIin29lzvi9WWJXHQhf7lcMFDTZ6bBjJAh9 qO++Uq+8 2RDoXAYud4QduavEVHclXogoLXG6NnC8zh4BuO+UCo2vCaeqqCMgimmpI/i209yBRfMKEiRMYApiDbwIoGElJXvYsjY5og7p4YdRti35QUPCKhy10AUHr1lCztaMZ3lzL5y/NDX/AhVpZjuF9y0QZQQIQpo8hLjZmsBh9MVU9BhZLHo5BtvWGhKFX3g4BSSPlFtYAtLoPkglp/E54D5ZofvDmEIN9fp0wqqrTGZy/fLn8exkcsn8ssWJpvA1ypLQQ/T1eCVpIOYefFU87G3HO5VzecpJigg7UqayuItC3h65CKIWFNkUWrWIUMftKxWeiS7iSUxpAZ9PPr+2TmcX8yN+pJ8LQjxYd805MeRBpYg5OAdByM+5tQe+Nb9f1duAnmQBhHTRgaIYasyV+sOEWZga2eMnAw8rXthhCTW8P9n3JNH50b1HZad20lilWPHKTevYXxmGQyZwj3mskyiYG2jS8hxa4X7QiTpyy4VAYWBHbw+VB6qLlDnS3kck6Y8hdp9vV70aUDO0rLxPircI60Dls59t2k2InDFUyPJ7eP7/hGkc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/28/25 4:02 AM, Fuad Tabba wrote: > To simplify the code and to make the assumptions clearer, > refactor user_mem_abort() by immediately setting force_pte to > true if the conditions are met. Also, remove the comment about > logging_active being guaranteed to never be true for VM_PFNMAP > memslots, since it's not actually correct. > > No functional change intended. > > Reviewed-by: David Hildenbrand > Signed-off-by: Fuad Tabba > --- > arch/arm64/kvm/mmu.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > Reviewed-by: Gavin Shan