From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E5EC433DB for ; Wed, 3 Feb 2021 18:58:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D175464F87 for ; Wed, 3 Feb 2021 18:58:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D175464F87 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1E9E96B0005; Wed, 3 Feb 2021 13:58:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 173A16B0006; Wed, 3 Feb 2021 13:58:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03BC46B006E; Wed, 3 Feb 2021 13:58:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id DD95A6B0005 for ; Wed, 3 Feb 2021 13:58:47 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9BED7180AD81D for ; Wed, 3 Feb 2021 18:58:47 +0000 (UTC) X-FDA: 77777868294.01.F6C2CFE Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP id AA62840B8CD5 for ; Wed, 3 Feb 2021 18:58:44 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id E7F9D64F61; Wed, 3 Feb 2021 18:58:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612378723; bh=PEYBOm0OePsiPNwQdE6LWS8QVtji2a0NydsNbpbrheA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=YrCJmRIfdfesjuEHIh5wXyFNyprTKwZEUK2NZM3r7LKXVCvzPSc7wSM+DLKbKaxtX MceRUV9/p8f6dyB7mdkb4fkf3qMINUAbnDrDMi7FIphV8WGp80jdCmMhdvtnU6mZik 49DbSe2IktGSDlgN6JRay37YcYdljSAQmXBidcRXQ5EjgRfAacXUaqiIxGfxXM5/Qv SQtuNB+rSMR8lvT9rdKx3QuVzifwMV4zxWKf70H77igztHVB8NllFInGH1SzyW7X95 yJkFTbsLrTBaDD5ABNwqT7q2BBbKj1vDQj7e9xhLFiPHMNvXLaYMIVNYhBl6vbgxTn W8tVELKgU/h/A== Subject: Re: [PATCH][RESEND] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed To: Petr Mladek Cc: Steven Rostedt , Sergey Senozhatsky , linux-kernel@vger.kernel.org, vbabka@suse.cz, linux-mm@kvack.org, willy@infradead.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, roman.fietze@magna.com, keescook@chromium.org, john.ogness@linutronix.de, Andy Shevchenko , Rasmus Villemoes , akinobu.mita@gmail.com References: <20210202213633.755469-1-timur@kernel.org> From: Timur Tabi Message-ID: <19c1c17e-d0b3-326e-97ec-a4ec1ebee749@kernel.org> Date: Wed, 3 Feb 2021 12:58:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: AA62840B8CD5 X-Stat-Signature: 76xa9pbx66psxe4zxrktywbq6anjj3nx Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1612378724-870973 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/3/21 7:31 AM, Petr Mladek wrote: > Also please make sure that lib/test_printf.c will work with > the new option. As you suspected, it doesn't work: [ 206.966478] test_printf: loaded. [ 206.966528] test_printf: plain 'p' does not appear to be hashed [ 206.966740] test_printf: failed 1 out of 388 tests What should I do about this? On one hand, it is working as expected: %p is not hashed, and that should be a warning. On the other hand, maybe test_printf should be aware of the command line parameter and test to make sure that %p is NOT hashed?