From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02675C4CED1 for ; Fri, 4 Oct 2019 07:33:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B7EBB21D71 for ; Fri, 4 Oct 2019 07:33:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VQCZ4JuK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7EBB21D71 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 621F06B0003; Fri, 4 Oct 2019 03:33:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D30D6B0005; Fri, 4 Oct 2019 03:33:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C1E26B0007; Fri, 4 Oct 2019 03:33:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 2B1D66B0003 for ; Fri, 4 Oct 2019 03:33:43 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id CEFED180AD822 for ; Fri, 4 Oct 2019 07:33:42 +0000 (UTC) X-FDA: 76005287484.05.moon87_3d6ea4d7ae31e X-HE-Tag: moon87_3d6ea4d7ae31e X-Filterd-Recvd-Size: 4233 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Oct 2019 07:33:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570174421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=8Y//Zmntx4ufnGGRI8hf20Nrx5NIc6pYNaUZckNMkBo=; b=VQCZ4JuKJl3MrdqvF2AiRQlqKVlAxS9iOVKDaFi6WIRgVOW5WVJYh5P3+6Ng4l6t6aVMSw BWNtlvLCvjCVjabtQM3Lx4ph10yss2pvEf1E1iD26QSs78rFAnt3dU314jyyggH0Pm4ftg CndjwenTNfa/v4PhCstlJZkTAD8UgRU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-170-EDjoEliQMsqHEYykIAcELw-1; Fri, 04 Oct 2019 03:33:38 -0400 Received: by mail-wr1-f71.google.com with SMTP id v17so1902468wru.12 for ; Fri, 04 Oct 2019 00:33:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t4ppAKkwTNFOQrRrntnYHnidIdCMVMlsgWRFlLoEftU=; b=Iz0UzdXUsMwHfqWgX0nymjT9YB5F4oRRYFmWWDjSosvFy1THW+1yv1JLvVnUrQScu3 qbs9cu/SaJqlXBdB1ZOQgae7EhnYNR9OBl9HiVDrcQ6ERIjdtT6n98AOXJU6jXZXNPdx 6aCQ2A0ztwlJzfQw5KKeFOqSSdPGUxXXHR48Sw4M6wWwUFYTl/E68jBRDjUcFT6iLxbe SWA5q90JHsoisiVoHVHlvtpnaa/5zeMhtKaHQuLS7caO4bc2BTW6HL6Rak34AU8HBywu o2wkAmK90aMtzIhPn2LUBm2mnnwbE2Msc7oGPvJRjiFZh+qTlSERDQan5zFL5nQ8JEZ6 Ho2g== X-Gm-Message-State: APjAAAVd7vWz98kEke+/9PGMyeYFtSiXR7O8GWxTGMetw5H6XC8axPKV /PvhICSXup7WYwSulPGrl+YiO40LcTAcrsf7A9p1BS1tq4y2asjfMCVYBvB+ZRAkbF7rjRV35/x xZvuIFSCAsXE= X-Received: by 2002:a5d:4c45:: with SMTP id n5mr11022758wrt.100.1570174416798; Fri, 04 Oct 2019 00:33:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqwHyEyM3S+vayaNWQN/Gp53Rbi7fPv/uH0l0mxTG5dhQxQVT8pRgCbd+4675sQR97/I/iY/tg== X-Received: by 2002:a5d:4c45:: with SMTP id n5mr11022736wrt.100.1570174416564; Fri, 04 Oct 2019 00:33:36 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:e56d:fbdf:8b79:c79c? ([2001:b07:6468:f312:e56d:fbdf:8b79:c79c]) by smtp.gmail.com with ESMTPSA id e9sm15809881wme.3.2019.10.04.00.33.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Oct 2019 00:33:36 -0700 (PDT) Subject: Re: [RFC PATCH 10/13] x86/mm: Add NR page bit for KVM XO To: Rick Edgecombe , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org, luto@kernel.org, peterz@infradead.org, dave.hansen@intel.com, sean.j.christopherson@intel.com, keescook@chromium.org Cc: kristen@linux.intel.com, deneen.t.dock@intel.com References: <20191003212400.31130-1-rick.p.edgecombe@intel.com> <20191003212400.31130-11-rick.p.edgecombe@intel.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: <19d7bde0-6063-c337-994f-0c75cbcfb721@redhat.com> Date: Fri, 4 Oct 2019 09:33:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191003212400.31130-11-rick.p.edgecombe@intel.com> Content-Language: en-US X-MC-Unique: EDjoEliQMsqHEYykIAcELw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/10/19 23:23, Rick Edgecombe wrote: > +/* KVM based not-readable: only valid after cpuid check */ > +#define _PAGE_BIT_NR=09=09(__pgtable_kvmxo_bit) > +#else /* defined(CONFIG_KVM_XO) && !defined(__ASSEMBLY__) */ > +#define _PAGE_BIT_NR=09=090 > +#endif /* defined(CONFIG_KVM_XO) && !defined(__ASSEMBLY__) */ Please do not #define _PAGE_BIT_NR and _PAGE_NR, so that it's clear that they are variables. Paolo