From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32735C0015E for ; Wed, 26 Jul 2023 07:36:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 961318D0003; Wed, 26 Jul 2023 03:36:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 911D96B0075; Wed, 26 Jul 2023 03:36:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D99B8D0003; Wed, 26 Jul 2023 03:36:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6FD646B0071 for ; Wed, 26 Jul 2023 03:36:38 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 504C51A01BA for ; Wed, 26 Jul 2023 07:36:38 +0000 (UTC) X-FDA: 81052955676.10.EFAF9D1 Received: from out-26.mta0.migadu.com (out-26.mta0.migadu.com [91.218.175.26]) by imf24.hostedemail.com (Postfix) with ESMTP id 5C1E218000C for ; Wed, 26 Jul 2023 07:36:36 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XkkSjxLZ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.26 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690356996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yrw1e5tQhbkMga7eJrUip2ycPtsuLn9P74mG8ros/F0=; b=LlSc8XzjrPRzC5bZqlTL4f3Z2t4P8dSKJC+6MZM2WC+pksS28g7eVZ/48B2WN2pwqKeW/a dFp3qvXVMPNULdGyHZoLJxXjmXyaw2xZD+rICwGsdl/y65SDxKLt4Wekr+cJK4V3ZeM9GJ lT3jhuGaMmqXOCb+Sgv6teJF0ZK/mIc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XkkSjxLZ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.26 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690356996; a=rsa-sha256; cv=none; b=rfPxC6Gkm8HoNHhT0yBrGKDWN5gNj9hYZRHoqcHN+/N63sy7SEhTqm5kdzgQY/oMLCU52a j8D4rRiGhdGC/TfYqo10KYILtF1cAReC0HXECxVzLNIrNDbpskZhDM55+h3CvRNmWzBctp /h60ih5C+c732YC+Ax/EQEO0726bz6E= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1690356994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yrw1e5tQhbkMga7eJrUip2ycPtsuLn9P74mG8ros/F0=; b=XkkSjxLZhEs+WTu6Lxce6yw56JkcjLLE3W9mi8l7oiUYes2Mt2Kx9x4+hwiBhDOxzRpaVC pfsRiMgi/wQngx46uSL66saqLbu8FkMymz5gIEi/n4cwHkh93N7+NRLIrXwMgbBpn3V0mr W8L4NvyZa4l7hBRrr+6H7xx0fZlpIGk= MIME-Version: 1.0 Subject: Re: [PATCH v2 29/47] vmw_balloon: dynamically allocate the vmw-balloon shrinker X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230724094354.90817-30-zhengqi.arch@bytedance.com> Date: Wed, 26 Jul 2023 15:35:42 +0800 Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <1D40C9FD-84F6-40BA-8D2C-0DF05882C933@linux.dev> References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-30-zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: 6hdwotrcmueosayaib3gj8dmp1a1gub8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5C1E218000C X-HE-Tag: 1690356996-512277 X-HE-Meta: U2FsdGVkX190aZuxTmom45BvRvlq8ziWEtRA0yJSM0mTHhg4ZjwhmGepUElzs9Lz3zTbDP/ShFuLXMeaGfgRfX5pH+sSYGgfkGQyrO6F+1RDKIZOykxYni4xbkRCojUxZnt3AefpZc8h3eFX/gRYTwmfLHzrbmbavnFLLJgPEtZAMS0Y1MjiqRNC5bKXZbsyQuG2X6MKY8Jh4MyXjPmeNqsjCdJlgZLONdUwK9xlo8vLbl4oxb9NJShRoMXOgUGHxE7lOvFZ8kfxfqgS7dZ+BOmLdxBwITQD3b8/jMB7/GpV41pdUOmwuTomoEmgr2tIOyzudCamZvmHlAQ6spgvSqRcyrL5QwcfrxTXgNJ3q2/x2EOt1Sv/y97/vs3vm8fpxynCi6brW8UUzXXp+qojOcsWbo8np6tiEVnm6kYgaW3dcggCThYRFehre8m1QAoPGx5+A/nc9go3Q28UhKyLJSBGtYvF+4a8xlMoyFRcUmGk+/pq3bZIKbqapb6bGpcozOP0dzp5q/RMuAwB5xzngndvyT8xbtSKVKbPrrxv7FquTTblek1Adm6zeHHctpJV9hOjDUE9ikU9MGTY8U3rd303MTWWup4f6xex8PcQgYk1h9sZl2vRW7c1RzVrV1FCxmP3vxQ+EfDXi0QbkG2XSoIEt1M9R2aQM5SjNbES8C4gHIs/Dzs2A6JuTXjnt7zbvQcP0Ur9fqgZMptIRdeFcDMGJIXIiKe5NN9xpQ9+8CygbpR0pzDqQ2NnhrCBygn1Gq/YOS/UdpUfm7xxwiNZ6gSBXZs4Yd8jvzAuFAf7EFDvlobqI4Z1irNg9p6/OyStMgZ+VGJhbc8DfWIKPEJSfzF8nTdRXyMbVQMoSlevNslF0T8zOKmySgnpmiJjt5C0iAK5X58u/yHjz5mrGesiME8XSm7PRNEjm6/m2pBgqwjgDXnzRai1QQ0GyvuFwPrq5j+9jVN2W3YAtayC4k3 ec/Xb3ug 8hqRu02dreoJQnmDxR7q2moVpcylPpBNjGiLHW3CkUVnXhj0zcejKBw68jkGJe2T5HCepWfuzYLiYBvMC+qUXvGjTdQcjqfHqWvk/vRSW+1n3zurT+FRhiHMurnt1dWJxA7X6ZxHnHiuHEO8OzHi1YQ+X2xhtLI3+MzfnZVWXrA4DnA6ZT0wgY4NmdfkdL4SLm9FA/MOvdlVF96F02wtyt57SvGnafhnUC1tnGLiVzBRocnI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > In preparation for implementing lockless slab shrink, use new APIs to > dynamically allocate the vmw-balloon shrinker, so that it can be freed > asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU > read-side critical section when releasing the struct vmballoon. > > And we can simply exit vmballoon_init() when registering the shrinker > fails. So the shrinker_registered indication is redundant, just remove it. > > Signed-off-by: Qi Zheng Nice cleanup. Reviewed-by: Muchun Song