From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF6C4F54AC5 for ; Tue, 24 Mar 2026 14:56:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31A9F6B0088; Tue, 24 Mar 2026 10:56:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CC316B0089; Tue, 24 Mar 2026 10:56:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BAB16B008A; Tue, 24 Mar 2026 10:56:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 078366B0088 for ; Tue, 24 Mar 2026 10:56:14 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9154DC076D for ; Tue, 24 Mar 2026 14:56:13 +0000 (UTC) X-FDA: 84581257026.26.D2E9A52 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012028.outbound.protection.outlook.com [40.93.195.28]) by imf15.hostedemail.com (Postfix) with ESMTP id A46E5A0016 for ; Tue, 24 Mar 2026 14:56:10 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=pHIkeeC8; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf15.hostedemail.com: domain of ziy@nvidia.com designates 40.93.195.28 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1774364170; a=rsa-sha256; cv=pass; b=EhA1U8NZHWwhotRCRfydQOtxLMfiPakvw/HuhRJrBW7WOietzhhA87pSDHuoIVU7FNRg+i dYmW+5O6hh3rsunwHXKjRNy4j5AHfwAgfioVp12y3u3YaRmOdpZ4eFKqU7KBxpFfmwZGGK 15RAMGDYWbEDGyrbXi5Z7M18rQ/pmK0= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=pHIkeeC8; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf15.hostedemail.com: domain of ziy@nvidia.com designates 40.93.195.28 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1774364170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vZ+ojWMYkevJfSrvpmZTmT/XiGK0/EFZYqgk7bJDrOk=; b=T7UOwfGr8d7rBkY0xL/MrpjWaG/Adb1LSn09mVpBjzgDEJhuqOjGi7GpOvBP50diyHdtdr wwcHBRJrH68WmLIsyCcslxj9ZgMN9Yew997vCGjHgN6Xn/QpStpz5wIPbBcn6qYYArYxc0 Dh5MTWjwMlWrS/kBV4SF7Ab1DCMuieM= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XnF2HKiaP0CQA3/5br6QtuMcdymv57pAV7CRQhweQsvVd/nK5P4uV/+8yzTPdisk0QGD6po/3TX+MAfMzFVcabHVKvTcEM5lN2ZFvRW22XxPpVzISdg7NltUYaAxGSJbfpjrVc3L0VB+Tt2M3sHnqZiei+pU3wT8HswoDNeU7UGWb8f+4MA1I5D95Fh1BcpbcqyO8o6Av8t+MskCRynEPF53u/UOw1rfDuyzOM03E72ZT8AZJr17Wz4MNh9FfLdtwdKTtaE8e4UNhkb+gFBkGocBmKD7ltgJNA73TVASPbGl/08ANXB0vTk9rEVFwO7DtIECIf6HCF1gzMIl+0546A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vZ+ojWMYkevJfSrvpmZTmT/XiGK0/EFZYqgk7bJDrOk=; b=bTODubsRHXdHapI1tqySxswnqgI3dKzEPX7eCbPjm8o0BwYBYLEVmHDvAOx6RYThjScykl1ci5/Gb7zTxiNHMNkj6eZvarFfA26K7q+p3UfHwFdYtxm1NRF7iTaSGzK4N9A6bcfNTywKJHbw7f7MrA99VKMNZr+Ct5Qv7oJFpplsWpciV+ZxxcZmG3DfwyUGwdvUjla7HZXuudfiJsjXjPBDVnS1DAtBGEDV1uzoj0HbDhw0SgcnYJ9PSR+CNGOjH9yj6lE971YAT6tIQuBxlVmLlJ8sb3FbW9HapwBKPGBTSBDqnjgt9PUkCkvrZ7ptzzcapt15f9jXFReAYNUiig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vZ+ojWMYkevJfSrvpmZTmT/XiGK0/EFZYqgk7bJDrOk=; b=pHIkeeC8GDOgZ4BUkwgviK0BYRFAPkx3P7flnigxmomgxnZ/6OXZjjTib5l2wjtKQWVC9EGgPIEj1jid7+s6xhxB/WcsT1ROXnmwAo6rZ+niS0av1KM1l6yMYVfZSTLetfQSpTlIqJ+l58a/wj/i9W87yaC6315Fdyf7e/hF5oiIkzqJaDqmMJUQHmPT551TzX4z7mH7R/9HASzHmvUVZ7jQi5kpPwUYDDBNraeKUSh6bh5wMO4UBO9gonOVtvZNpHD4nkfaolUethG/jeNW0xqRyIRhm4R1cyOyOZjy/qTFdNsXFb+w6vWgRNzGstLt7rDihv2D+tFjjcaKK7V7iA== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by SJ2PR12MB9191.namprd12.prod.outlook.com (2603:10b6:a03:55a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Tue, 24 Mar 2026 14:56:00 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9745.007; Tue, 24 Mar 2026 14:56:00 +0000 From: Zi Yan To: Muhammad Usama Anjum Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Uladzislau Rezki , Nick Terrell , David Sterba , Vishal Moola , linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Ryan.Roberts@arm.com, david.hildenbrand@arm.com Subject: Re: [PATCH v3 2/3] vmalloc: Optimize vfree Date: Tue, 24 Mar 2026 10:55:55 -0400 X-Mailer: MailMate (2.0r6290) Message-ID: <1D88CFF0-8A74-413F-9A6A-39E27B760AE1@nvidia.com> In-Reply-To: <20260324133538.497616-3-usama.anjum@arm.com> References: <20260324133538.497616-1-usama.anjum@arm.com> <20260324133538.497616-3-usama.anjum@arm.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BYAPR02CA0058.namprd02.prod.outlook.com (2603:10b6:a03:54::35) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|SJ2PR12MB9191:EE_ X-MS-Office365-Filtering-Correlation-Id: c733d380-87d3-4680-9a4e-08de89b5767e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: a/5GBBNiPDV8PpcrBkKroQX7mk2LqChdN350/TtH53h884DtF/ccwhJvQeMOSDjbVXySdGLyTRqnLd4eyP/4gfSkwm4SVuLCfhlZSHCX5X9Dt/hw7Y+tLOJAQoIqO8XsJNjXA77JE2Ks2eZbmk7/feYWm71EEyrE4mU1kSnTM1kWpeuFV547S0iWfGpOxvmG+pheTFk1IoWn6w8idHwDZg8nUYv2IUvjikQUXDbwHUQv+LGZ/BCe4xZKOAYbqawGS2B1ymHmepQItimeTxuiOr1Vd7VJ0i+1FUJILHCeUEKLK1x1rjkyzg++rNTbzUzrg9Bbw/OFaUSZsODFnu6IuqKloL0jKCb/ru+t8AG87hMPF9x3yoxZFRsOtBq8uRYDM527/KJX/oKqOEoT/vzzEr5eFB0UD/MExMeob5SEVRf/oMRF1qJL1d+7ZNb20tAeIES1xxlKiPWmultbzd2DloWcay5roSw6qQXqQfsBaxMhnLLNLdhkRtCUiWMfNNmsxRx+G3QdxUHcX98eOI7gOsshj022QXueLzJ7QrIcx8KIKh32bvaUUTnhNUbQ933qQGaNDcoU+AyiBtiUA2cV6nrS8JQ/QAxAfLyRpVPiQIAYbL9377I+e8Ijnxz61iAidlzCp9mNAV65vyZGv1ndGXuJmwohcvWWx2plx66G2EqQ9pF8sU60i3DuxPNlWxB7yj7KWzCxkK699i0SEMC5+Nbtrm1qoUCk9l1TTJo0blI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Koj7Ls8bipygUOfjL37Mu+s4gan+JnbKo8VPYaf+Kf8rQnggxWTT6DOO6up3?= =?us-ascii?Q?LmUcW2G2Jg8hyVrsuShKwTUNlN+XQTuKWVkOAZeDvhfoj6CDFwTuy8xi+KPN?= =?us-ascii?Q?PmAMW9Qtp3r533FG3dPN4dARYmjn+l0N6/CYIU88SZkpVZMSjlNeQvb26EY/?= =?us-ascii?Q?8LrY/tEb8nUf3Etin3GjwSh47lnKsU3NTvUKsNf4XM7xPKtOoijZT00+q43r?= =?us-ascii?Q?Q5GglT9TxGiFFMqfI5XNkXlsSlhprwXVVjlRRWFMMovuMdxyztW0l5PDZTk8?= =?us-ascii?Q?6zg6JTb5V2Z2as/JZs/PZFkA+4DWVjPzVrthZPinU0VTPlW8vVvv7m4Y9A3Y?= =?us-ascii?Q?T1CjvtymL8yW8ZyAT5wdzID5jXQIVhqz9jrJv763WJIyElPMJoZqIaXd+pEG?= =?us-ascii?Q?OvgT1SRtK52w4TURqOgjdyW9s2JyyAINYMuJV+bMFArQWJhKprG3axrOZSbY?= =?us-ascii?Q?T6Wq6z4V4R4UBBxUlGpLJSaN5dZk2eVz+IpK5uhqt0e1DBMHowZkTN2rmyEn?= =?us-ascii?Q?zDV9NQfBNIA/bY49QKY95Qy2q0sWLAS3Fqt8DagNVEYNGN6qc0Hq/ejWIWHq?= =?us-ascii?Q?/JyFQkdjRTprIYGoYo5nMAEeKhWk88Plj1Uka+ZQmgAP+rcixAw7y/53ToXY?= =?us-ascii?Q?JZJGsq1vqRbOLCVZwurQCMFlF2TlvcQ9UPb6fGbl6Vxj74sqKUwD7FiCFgVX?= =?us-ascii?Q?c+jmemDMns0F2tXkZWMFVJVqifLhxy/iWgMgIBOlXLcuc8a2Gyot4VBAQ2J5?= =?us-ascii?Q?D4/LvzhE75wNaUGOaYg+z3peOMFV36fG8UgDlmzGYEDu3wwclQ6yoOkrAjR9?= =?us-ascii?Q?uHslkTJ4iN9lGJJuV6O+z7A4BxhviNjQGAdQR+mFmA00bXpHwDHBis6p5Zb7?= =?us-ascii?Q?ZzIGrnXncadHrWmQ7zVRzD/nQfzhOqedvBy1b7OoKFHF8PEUQlVSrb/TuR8X?= =?us-ascii?Q?KQ1RC0jzc81h+1SH+M9Rw0NcOpHJFTa6Ki5HpNGR0D6lFUjXVVH4kQta/3Rh?= =?us-ascii?Q?BopSKx+wsQK7wOug5Z4Na6Y8uEfjTsqt/oWe0rDTlZMqJ723VntThLloK9S0?= =?us-ascii?Q?PvMThnmvlQXsT1J2sjvDI/xwY5GtlIj/n6clFhJ4Zgw8c2U1h1r55ene8ri6?= =?us-ascii?Q?Cu856gD6pGmtfbq/mVZLBD75mLJHsYn0CcwIvyqOVFksle9XiS0Twz2c8tCn?= =?us-ascii?Q?ohVtqpRwlW0oZ2RAxtf9iQ00DzcxSIzmIEl2XcL/B+E/QiYGlZMU0GQUP+c7?= =?us-ascii?Q?K4p8zyTBHMieTcg0GbGe6L9VEDnUOEwd6MdSL+vktWFw4S6eAwpzWk0QjnWO?= =?us-ascii?Q?S8dhM1v/33Xbj0pJDB/a8Xfj+5z6nWgNFcZQq1whhr/hyii5SGrJNaBLTWX2?= =?us-ascii?Q?S9c6ChOi/fhNkyWKP+WKT/55vrSIs6J7nuVqMdnv7hcI6aFNj4iEF4biiVwE?= =?us-ascii?Q?6vCqOwpMelgbz9Z75E9WAqQ+gBn5LP3AnaZGk7KmmZeS1firJdISFdH+iTFt?= =?us-ascii?Q?8r3m1QNufkp0auMlP1KBXmNJ6kFAd77F49mKQsjyysl17WVvWipBxAwEWsty?= =?us-ascii?Q?EvuYNqaoRehg6AOaxBsVmY3f4bnJbaf7EDBclef+J8n3wJTn89ZfjiqZRuRu?= =?us-ascii?Q?93SOp/NYRcwTgeOcth0TriA9ieR08YjhhUgpmW0TXfwI11XS7NjoT4E7MqPo?= =?us-ascii?Q?Izu92ZzVmVUs3Lnfi1HHnjZyMnUKvAjnJUlkGkg2XsLP+iqwHNHkshbd0qe5?= =?us-ascii?Q?h7hQx46f1A=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c733d380-87d3-4680-9a4e-08de89b5767e X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2026 14:56:00.6133 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: obv/PRJF0WD6ROLT/cORWo9o8tFCM9BK9mNP8fTiYVOpIQpNFFarWdfRUBbVBIyD X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9191 X-Rspamd-Queue-Id: A46E5A0016 X-Stat-Signature: i7n1psjf1nnmdbtwwqeshu6aw9m6wsgy X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1774364170-646515 X-HE-Meta: U2FsdGVkX19nwxEpTcBN1Y0hfewRdFmMoqx/jjStlcWd3R4OWATgaktOr+uMXwo2wysqEK9ovzV0Ct8adgPoCnB0OB+siBZgccb/S94W2q55fVpE321lLx3TP27sRb9wYDBzVIXsJq/3HTA3yfbh0olugjXcujBwhwN0YTECdYhm61VhRA9beVyfomMteYausuIs+WJTGBYkIq+acIT3uPJL8ooRgLdULZEQzoqims/YXsHUl9jigdjtKwiC/vgNe7EB6UQI0ott2WtrxNHw9phwxFW8r7qOrEcYT1iRVXaB/hA2lSetYNLPl3CUYpH7PzcBGPFnQBn0eHyvBjYpPGTzQiSzkYkJsVCFj7Mghc3HV03vBPDC/dXMjFw+mLHl0sJSRaWR6B6JTdsdFfbTWJ6eWQqrWDRkn1kmAyiuE5SZZToSpEx0paarlUKZIqfnIDpXM+cKne5yV/YQdXew/2Cm4lJy6zAUQslNn3WU1GmQwBtWNkT/rOh5v29JnTtOK0QRT9wgldoyyvYt7C4Zoc/c76jADd6QcSJ7p2SXnNmNhEI5pZ5efcLsHoKYBDlesUblNY82kKuspYAc3QbOsS6GSf0+UjWjhULnCaUAkTfKfiLUYbwd5bS8tSRKf2ekc8ElBTJyV4CsYbg3FjcpPJvqgYcxkgCJLCVFZQ6JbFTB9UixXeix6IARDR1tvo2Pjo+oY5YS/vcc76idtQKLyLyTVIti313NdeA0N1q6SS9vUZmcv6Yje/YM4oYrPB1ViFl1zhthlzsu5XqbtafOZcIJY3JJoBCp2ckLmBVDnBQa3w5IaKZMoK/SK1MmzaugGC+3WV55QRQ7znmv9nN2L6IgHJi7xG3GqfXUIq/LvfiiTx9tOwHzzO3UyKQl8vCizlZWzHHOn1PXvfE7yzUc95/pqw7jH8VC7X92+0YsgPJAFC6hVLRN/vxiR7YPgHoZDT1fu6FnTWxYOCJhlEU IGn7pA9y ccx1JNIF9LcXlPRaxDW1Dj0MPicZ97m5WgnRWTZROqFa+VD97XAaqeGCWFRqKIGkDcMhq2bp6p2WVQH1Z/iNyXAakNhXzpzJMxbQphxFLrNDGlSXWvyOxqq4WXOpSXdtHHTHI9omUqvLer69my2S0dIqIZyfRlY3S3qvMu4W1UCUCYKjrsYjQFmYAGnb/yymw4tFNX9ehZYvHcqGcmD+LPxAx793nq5j1/N7/NbxPPxqnhfQS2+52jwvoGixfhvbUB8hxHMpcKxjq4Rta1Wbqm4rtnAbxEdU+EfB9QqlIxIngO6zP/EX3Lha3GawMQ7dVfBQ8G+4bsiSGyhUoyOvec8/wYRHiXfHdqjZJJp3QmIdj5BKFvOnzu5h3SiiIGTOsfjBYkaFfTMJfHHQP9uvjk62yvxXpAsh68wd8OXL5frAtUDB10w1hhMLEs2+/IA5cS1fOSGoFphnGu+4ES6Ro8xR4QrFHqFuKjyGtdO7m7EOWpx9amwrwIipyQJbpXjinYP+WKuuevZesm8gypG6pOfgTPt5SynTv5jJ6 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24 Mar 2026, at 9:35, Muhammad Usama Anjum wrote: > From: Ryan Roberts > > Whenever vmalloc allocates high order pages (e.g. for a huge mapping) i= t > must immediately split_page() to order-0 so that it remains compatible > with users that want to access the underlying struct page. > Commit a06157804399 ("mm/vmalloc: request large order pages from buddy > allocator") recently made it much more likely for vmalloc to allocate > high order pages which are subsequently split to order-0. > > Unfortunately this had the side effect of causing performance > regressions for tight vmalloc/vfree loops (e.g. test_vmalloc.ko > benchmarks). See Closes: tag. This happens because the high order pages= > must be gotten from the buddy but then because they are split to > order-0, when they are freed they are freed to the order-0 pcp. > Previously allocation was for order-0 pages so they were recycled from > the pcp. > > It would be preferable if when vmalloc allocates an (e.g.) order-3 page= > that it also frees that order-3 page to the order-3 pcp, then the > regression could be removed. > > So let's do exactly that; use the new __free_contig_range() API to > batch-free contiguous ranges of pfns. This not only removes the > regression, but significantly improves performance of vfree beyond the > baseline. > > A selection of test_vmalloc benchmarks running on arm64 server class > system. mm-new is the baseline. Commit a06157804399 ("mm/vmalloc: reque= st > large order pages from buddy allocator") was added in v6.19-rc1 where w= e > see regressions. Then with this change performance is much better. (>0 > is faster, <0 is slower, (R)/(I) =3D statistically significant > Regression/Improvement): > > +-----------------+----------------------------------------------------= ------+-------------------+--------------------+ > | Benchmark | Result Class = | mm-new | this series | > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+ > | micromm/vmalloc | fix_align_alloc_test: p:1, h:0, l:500000 (usec) = | 1331843.33 | (I) 67.17% | > | | fix_size_alloc_test: p:1, h:0, l:500000 (usec) = | 415907.33 | -5.14% | > | | fix_size_alloc_test: p:4, h:0, l:500000 (usec) = | 755448.00 | (I) 53.55% | > | | fix_size_alloc_test: p:16, h:0, l:500000 (usec) = | 1591331.33 | (I) 57.26% | > | | fix_size_alloc_test: p:16, h:1, l:500000 (usec) = | 1594345.67 | (I) 68.46% | > | | fix_size_alloc_test: p:64, h:0, l:100000 (usec) = | 1071826.00 | (I) 79.27% | > | | fix_size_alloc_test: p:64, h:1, l:100000 (usec) = | 1018385.00 | (I) 84.17% | > | | fix_size_alloc_test: p:256, h:0, l:100000 (usec) = | 3970899.67 | (I) 77.01% | > | | fix_size_alloc_test: p:256, h:1, l:100000 (usec) = | 3821788.67 | (I) 89.44% | > | | fix_size_alloc_test: p:512, h:0, l:100000 (usec) = | 7795968.00 | (I) 82.67% | > | | fix_size_alloc_test: p:512, h:1, l:100000 (usec) = | 6530169.67 | (I) 118.09% | > | | full_fit_alloc_test: p:1, h:0, l:500000 (usec) = | 626808.33 | -0.98% | > | | kvfree_rcu_1_arg_vmalloc_test: p:1, h:0, l:500000 (= usec) | 532145.67 | -1.68% | > | | kvfree_rcu_2_arg_vmalloc_test: p:1, h:0, l:500000 (= usec) | 537032.67 | -0.96% | > | | long_busy_list_alloc_test: p:1, h:0, l:500000 (usec= ) | 8805069.00 | (I) 74.58% | > | | pcpu_alloc_test: p:1, h:0, l:500000 (usec) = | 500824.67 | 4.35% | > | | random_size_align_alloc_test: p:1, h:0, l:500000 (u= sec) | 1637554.67 | (I) 76.99% | > | | random_size_alloc_test: p:1, h:0, l:500000 (usec) = | 4556288.67 | (I) 72.23% | > | | vm_map_ram_test: p:1, h:0, l:500000 (usec) = | 107371.00 | -0.70% | > +-----------------+----------------------------------------------------= ------+-------------------+--------------------+ > > Fixes: a06157804399 ("mm/vmalloc: request large order pages from buddy = allocator") > Closes: https://lore.kernel.org/all/66919a28-bc81-49c9-b68f-dd7c73395a0= d@arm.com/ > Signed-off-by: Ryan Roberts > Co-developed-by: Muhammad Usama Anjum > Signed-off-by: Muhammad Usama Anjum > --- > Changes since v2: > - Remove BUG_ON in favour of simple implementation as this has never > been seen to output any bug in the past as well > - Move the free loop to separate function, free_pages_bulk() > - Update stats, lruvec_stat in separate loop > > Changes since v1: > - Rebase on mm-new > - Rerun benchmarks > > Made-with: Cursor > --- > include/linux/gfp.h | 2 ++ > mm/page_alloc.c | 23 +++++++++++++++++++++++ > mm/vmalloc.c | 16 +++++----------- > 3 files changed, 30 insertions(+), 11 deletions(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 7c1f9da7c8e56..71f9097ab99a0 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -239,6 +239,8 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp, in= t preferred_nid, > struct page **page_array); > #define __alloc_pages_bulk(...) alloc_hooks(alloc_pages_bulk_noprof(= __VA_ARGS__)) > > +void free_pages_bulk(struct page **page_array, unsigned long nr_pages)= ; > + > unsigned long alloc_pages_bulk_mempolicy_noprof(gfp_t gfp, > unsigned long nr_pages, > struct page **page_array); > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index eedce9a30eb7e..250cc07e547b8 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5175,6 +5175,29 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp,= int preferred_nid, > } > EXPORT_SYMBOL_GPL(alloc_pages_bulk_noprof); > > +void free_pages_bulk(struct page **page_array, unsigned long nr_pages)= > +{ > + unsigned long start_pfn =3D 0, pfn; > + unsigned long i, nr_contig =3D 0; > + > + for (i =3D 0; i < nr_pages; i++) { > + pfn =3D page_to_pfn(page_array[i]); > + if (!nr_contig) { > + start_pfn =3D pfn; > + nr_contig =3D 1; > + } else if (start_pfn + nr_contig !=3D pfn) { > + __free_contig_range(start_pfn, nr_contig); > + start_pfn =3D pfn; > + nr_contig =3D 1; > + cond_resched(); > + } else { > + nr_contig++; > + } > + } > + if (nr_contig) > + __free_contig_range(start_pfn, nr_contig); > +} free_pages_bulk() assumes pages in page_array are sorted in PFN ascending= order. I think it is worth documenting it, since without sorting, it can degrade= back to the original implementation. > + > /* > * This is the 'heart' of the zoned buddy allocator. > */ > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index c607307c657a6..e9b3d6451e48b 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3459,19 +3459,13 @@ void vfree(const void *addr) > > if (unlikely(vm->flags & VM_FLUSH_RESET_PERMS)) > vm_reset_perms(vm); > - for (i =3D 0; i < vm->nr_pages; i++) { > - struct page *page =3D vm->pages[i]; > > - BUG_ON(!page); > - /* > - * High-order allocs for huge vmallocs are split, so > - * can be freed as an array of order-0 allocations > - */ > - if (!(vm->flags & VM_MAP_PUT_PAGES)) > - mod_lruvec_page_state(page, NR_VMALLOC, -1); > - __free_page(page); > - cond_resched(); > + if (!(vm->flags & VM_MAP_PUT_PAGES)) { > + for (i =3D 0; i < vm->nr_pages; i++) > + mod_lruvec_page_state(vm->pages[i], NR_VMALLOC, -1); > } > + free_pages_bulk(vm->pages, vm->nr_pages); > + stats is updated before any page is freed. It is better to mention it in the commit message. > kvfree(vm->pages); > kfree(vm); > } > -- = > 2.47.3 Otherwise, LGTM. Acked-by: Zi Yan Best Regards, Yan, Zi