From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC295C3DA59 for ; Wed, 17 Jul 2024 03:25:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59F6E6B0092; Tue, 16 Jul 2024 23:25:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54EDA6B0099; Tue, 16 Jul 2024 23:25:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EF8C6B009A; Tue, 16 Jul 2024 23:25:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1A8116B0092 for ; Tue, 16 Jul 2024 23:25:51 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7F26D1207BA for ; Wed, 17 Jul 2024 03:25:50 +0000 (UTC) X-FDA: 82347805260.18.E252C08 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) by imf25.hostedemail.com (Postfix) with ESMTP id 0693CA0008 for ; Wed, 17 Jul 2024 03:25:47 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lVJYZm4Z; spf=pass (imf25.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721186729; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C7rABMgw9SKgYCYqxvHlAjIajNrNS26PeT9VmPMwiTE=; b=0aU3L2aGCWb2TpWaRzkvnr0q9slGBB36R+YGNK2XyAIqumokygkUxZ9va0TXLg7/kKnMc5 fZtEKi8jfhY0IpXzLB/PI4PZVlCh0PZVAWhOB4QER+NGWAmYN+f18PAlFqUbLr5PS9c4V4 uqUZS/Lk9SgyAimRW9mQ87Sfdpha8/Y= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lVJYZm4Z; spf=pass (imf25.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721186729; a=rsa-sha256; cv=none; b=jJX4mZPfjEzEYEtiQzhl0HlE4VcSxJpLUiLdtuIRkjRP2v+yAxihqHxVI45z7b3GmPAORT g5ubMpi32a8xsWL7gBNMsjePPzvD+XREDvsjOYiVlwMVSuUA72OxJkiVl8aA5QEEiAyGwg YqMvDLrY+I3ZKUcrr3xCwY1r+Wc0UUI= X-Envelope-To: kasong@tencent.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721186746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C7rABMgw9SKgYCYqxvHlAjIajNrNS26PeT9VmPMwiTE=; b=lVJYZm4Zu9iFy4E/h6DGTOXUuAcrgDKxXEtBpXu0B64h2vgLeW016GTnpB43+hjiXXjAZd SQdNdihkFKp9gbZbkJzIOSq8X7DrLry/onk2/g40pGbFZotmgQ0g5xEWD8Jc/HvH50kGBv Iyh73pLsXciRe9E2rUfKjNdTc9GooQo= X-Envelope-To: linux-mm@kvack.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: willy@infradead.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: longman@redhat.com X-Envelope-To: shakeelb@google.com X-Envelope-To: nphamcs@gmail.com X-Envelope-To: mhocko@suse.com X-Envelope-To: zhouchengming@bytedance.com X-Envelope-To: zhengqi.arch@bytedance.com X-Envelope-To: chrisl@kernel.org X-Envelope-To: yosryahmed@google.com X-Envelope-To: ying.huang@intel.com Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: Re: [PATCH 1/7] mm/swap, workingset: make anon workingset nodes memcg aware X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240624175313.47329-2-ryncsn@gmail.com> Date: Wed, 17 Jul 2024 11:25:09 +0800 Cc: Linux Memory Management List , Andrew Morton , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Waiman Long , Shakeel Butt , Nhat Pham , Michal Hocko , Chengming Zhou , Qi Zheng , Chris Li , Yosry Ahmed , "Huang, Ying" Content-Transfer-Encoding: 7bit Message-Id: <1ED4A154-FD17-4689-BAA3-380AFEEAF58E@linux.dev> References: <20240624175313.47329-1-ryncsn@gmail.com> <20240624175313.47329-2-ryncsn@gmail.com> To: Kairui Song X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0693CA0008 X-Stat-Signature: 47tkgkix8qk8mokay8am96qftfpg1rez X-HE-Tag: 1721186747-318586 X-HE-Meta: U2FsdGVkX1/Nq+84Dz0BJje6ErEsIGs3n3c03NpRhh/h4x+Jm+lX1bLhqrVH6GCreBFApQxmJmWpMax7GolTqmHJPf76f2RP1bkfH3OGjbmMo2yDQy+DJMu3Ni21O8K19kaE1X1/7LoZLzC6u4+CrWopw4lvl/tpjEBwKK7bRgD+lxKPxbge1ventbvwHYKbZOgLhBuQiKmduvmqIhv30pTLC9uc4P6hwrUnK48fAWX0cWe9H9/cZuFK+V23PbYPMdx8+GHq+JpA0TUwbZDJLaVykqnotpvMQKP/vMnVFR3RhvCUmWqN95vuJkfDZxQFPH6ir6oDhYrinkgrdQHXdDheWuwhAIBJ9rR24VXGUL5NY2B6mlpFLja6A7w1s8HzjHKvVEC6QYDZKZ7yo7xpo6tNX/64e58FhycAGa/d1/eblH4T2qwyQhzVxN30bheiF7m/nv0B7CvFDhosjUS/KzEjPYmdNkYB1hxTGCMFYzmWr2OvYhvYMgj69GG/PZVOhVvvF9/mYYPbW9FJjzCYlVf46kEJuoWJfET9YVDjvynjRfpeOQm04nKhYFWu95xay415JHf0M6JXy0A0IzRdM5cSdC0PPETQA+9UvNJ5DNSj8h2ISj8pI8gSj7JA63FUQfQllhCqt6Dqzfdjn5UbUz05xZNY5HGxlxiRdEi5XAwTphnGcUvc+xUsf/BZTKpwUI90Yytitb+IPFTGQ84ff5rxMDT+sKlXKNtknd1Glykkl8epE/lk5XhMV+sZyav3fdbDBlOlFgiziP7R7z9HpfnNbJStUYoFo2dkZwNcgCKAyChUNaU7F2h2zefCNeW43c4gU0IQnLJ1i+dt9HIAaJ7EudxLt45DMRyKqbBUwbty3FjvWxtozsZT1gGF2J1Ylqz4oBn2Nqq2KAwgs6+Hn2+OveL6JoUaokVq0Lyqm9vUc1YGWoL/3cyivEPfRGY7boEDjJvT3VxUVqyEAwF YGRSjEhn dg0TJ5EXWN10k4AmCJ3b5zF2WXtPUx1j9XnD279z856qZGqkLkOSyXy5LblbXeSvj2/jQDYfkXbhRuT0J19jp0wdmGSyLVdlla6an7gqFZgZd8glwQ2dY7KKtKkqc0DlBSjhl3gcApNSt1uqd4ytu2ACo8i3PVQ4x0oeaM2Wn5XzcOeCiVpp5dQyWfUE4JExVuCyIYX9xD2OLvqwSsghgWN0vxjVcq/Xm1nLBaqgIvzG1FDw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Jun 25, 2024, at 01:53, Kairui Song wrote: > > From: Kairui Song > > Currently, the (shadow) nodes of the swap cache are not accounted to > their corresponding memory cgroup, instead, they are all accounted > to the root cgroup. This leads to inaccurate accounting and > ineffective reclaiming. > > This issue is similar to commit 7b785645e8f1 ("mm: fix page cache > convergence regression"), where page cache shadow nodes were incorrectly > accounted. That was due to the accidental dropping of the accounting > flag during the XArray conversion in commit a28334862993 > ("page cache: Finish XArray conversion"). > > However, this fix has a different cause. Swap cache shadow nodes were > never accounted even before the XArray conversion, since they did not > exist until commit 3852f6768ede ("mm/swapcache: support to handle the > shadow entries"), which was years after the XArray conversion. Without > shadow nodes, swap cache nodes can only use a very small amount of memory > and so reclaiming is not very important. > > But now with shadow nodes, if a cgroup swaps out a large amount of > memory, it could take up a lot of memory. > > This can be easily fixed by adding proper flags and LRU setters. > > Signed-off-by: Kairui Song I haven't looked at the details of this patch yet, but I think it is not related to this series, it could be as an individual patch (If it is a real problem, I think it will be quickly and easily merged). Thanks.