From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1029ECAAD3 for ; Thu, 15 Sep 2022 08:59:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 415AE8D0002; Thu, 15 Sep 2022 04:59:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C59F6B0074; Thu, 15 Sep 2022 04:59:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28DF28D0002; Thu, 15 Sep 2022 04:59:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 164626B0073 for ; Thu, 15 Sep 2022 04:59:55 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E481B160C86 for ; Thu, 15 Sep 2022 08:59:54 +0000 (UTC) X-FDA: 79913722308.06.A7BF5CC Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf01.hostedemail.com (Postfix) with ESMTP id 30A59400A5 for ; Thu, 15 Sep 2022 08:59:54 +0000 (UTC) Received: by mail-pg1-f179.google.com with SMTP id q9so7601144pgq.8 for ; Thu, 15 Sep 2022 01:59:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=LgyjDSHm06cPee7hqq0YhgTi9iCJukSRg0rhaRDNcHk=; b=k802BZHa8wSP8oWRKKhwaS/QEvdEmorr/BJsgin2xU/GMV/U3D3TxEQRI8N4E8Vnk4 46oPJUFOxzU25feYoHbEzj8Fj4YzDFNnrlQHkOmQbIEK2R3xAxwpLGxIAqJSfsczyF38 2VruW5l75z+1ixZbEeik4ubbKDOEtq05R3zZiZN2wvKrR9Gf42vAFAi7WjsJqXu13TCX S4VaRz8XUOnMRLZoL+Jg2mpv4ynjm+sub3RymnXCpqfBzL7OubceQuJTaDlCxdvmrA11 UnTJAZQkb3k98HFqvioX0XlwF31r53+0vcFdZA9TcA+BSdYAYBSlYLZUgQvkuwprmUT0 1pJA== X-Gm-Message-State: ACgBeo2tSW3MqR3nbdGy701zVusH25ITn4RP+bEgAMs+jjfAk38YIhli 4mLS8VbNaRLIQk2KEiclm6Y= X-Google-Smtp-Source: AA6agR4WU7ZFHbHVFtlrqh6Z/nov+94pXR2gXasc4E3LWh/IVzcVIhhv4YrnTj6lp0euM6VzNvlMaw== X-Received: by 2002:a63:ff59:0:b0:439:db5:5da9 with SMTP id s25-20020a63ff59000000b004390db55da9mr15350857pgk.88.1663232393120; Thu, 15 Sep 2022 01:59:53 -0700 (PDT) Received: from [192.168.123.231] (144.34.241.68.16clouds.com. [144.34.241.68]) by smtp.gmail.com with ESMTPSA id a23-20020aa79717000000b0053e3112e84bsm11908800pfg.50.2022.09.15.01.59.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Sep 2022 01:59:52 -0700 (PDT) Message-ID: <1a2ac6fb-1a02-de99-1b4e-18360bd34d55@kylinos.cn> Date: Thu, 15 Sep 2022 16:59:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] mm/filemap: Make folio_put_wait_locked static Content-Language: en-US To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, k2ci , linux-fsdevel@vger.kernel.org References: <20220914015836.3193197-1-sunke@kylinos.cn> <44af62e3-8f51-bf0a-509e-4a5fdbf62b29@kylinos.cn> From: Ke Sun In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663232394; a=rsa-sha256; cv=none; b=TKv+jIlBsdEKi35v0DciiUqUQQC1p+dYPbmN+89X5v21VViv7EUYW/9mCawgWCnJSWMw6X chNw8dRlhUgtoX/BesRPEhoIoGXUJSrXK7qLZbQ6GNL3IdiQL3LXd1Cl25oAF0spHc0d0D xht4xldZimGvO/ezMtrN7G89I5HwRFs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of sk.alvin.x@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=sk.alvin.x@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663232394; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LgyjDSHm06cPee7hqq0YhgTi9iCJukSRg0rhaRDNcHk=; b=cUAFbhh9gKvtWheNf7owlQLvuly9VjGyubiQsRXYwSMBwMgvU6IZTaKUk8utwaMCBZo70M 4gz0/abwaCTszvcWT3JkjL2JoEb3wBEFX0Jtz9YKKnmS8dLRBLSCZmt5tz6Y0hrP1xBFBu 0RHpjWDddTQkSY0a01B1Zr4iSIMuEJg= X-Rspam-User: X-Rspamd-Queue-Id: 30A59400A5 X-Rspamd-Server: rspam05 X-Stat-Signature: znsz9khxk9x3kyrtt9nxtcfa9148mbkz Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of sk.alvin.x@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=sk.alvin.x@gmail.com; dmarc=none X-HE-Tag: 1663232394-998494 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/15 15:30, Matthew Wilcox wrote: > On Thu, Sep 15, 2022 at 08:45:33AM +0800, Ke Sun wrote: >> Ping. > Don't be rude. I'm at a conference this week and on holiday next week. > This is hardly an urgent patch. So sorry to bother you. Some duplicate emails were sent due to issues with mailbox app settings. >> On 2022/9/14 09:58, Ke Sun wrote: >>> It's only used in mm/filemap.c, since commit >>> ("mm/migrate.c: rework migration_entry_wait() to not take a pageref"). >>> >>> Make it static. >>> >>> Cc: Andrew Morton >>> Cc: linux-mm@kvack.org >>> Cc: linux-kernel@vger.kernel.org >>> Reported-by: k2ci >>> Signed-off-by: Ke Sun >>> --- >>> include/linux/pagemap.h | 1 - >>> mm/filemap.c | 2 +- >>> 2 files changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h >>> index 0178b2040ea3..82880993dd1a 100644 >>> --- a/include/linux/pagemap.h >>> +++ b/include/linux/pagemap.h >>> @@ -1042,7 +1042,6 @@ static inline int >>> wait_on_page_locked_killable(struct page *page) >>> return folio_wait_locked_killable(page_folio(page)); >>> } >>> -int folio_put_wait_locked(struct folio *folio, int state); >>> void wait_on_page_writeback(struct page *page); >>> void folio_wait_writeback(struct folio *folio); >>> int folio_wait_writeback_killable(struct folio *folio); >>> diff --git a/mm/filemap.c b/mm/filemap.c >>> index 15800334147b..ade9b7bfe7fc 100644 >>> --- a/mm/filemap.c >>> +++ b/mm/filemap.c >>> @@ -1467,7 +1467,7 @@ EXPORT_SYMBOL(folio_wait_bit_killable); >>> * >>> * Return: 0 if the folio was unlocked or -EINTR if interrupted by a >>> signal. >>> */ >>> -int folio_put_wait_locked(struct folio *folio, int state) >>> +static int folio_put_wait_locked(struct folio *folio, int state) >>> { >>> return folio_wait_bit_common(folio, PG_locked, state, DROP); >>> }