From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D02C5475B for ; Fri, 1 Mar 2024 11:24:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BBE36B0072; Fri, 1 Mar 2024 06:24:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 744926B0075; Fri, 1 Mar 2024 06:24:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E4EA6B0078; Fri, 1 Mar 2024 06:24:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4EB5E6B0072 for ; Fri, 1 Mar 2024 06:24:03 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CFCF9A1334 for ; Fri, 1 Mar 2024 11:24:02 +0000 (UTC) X-FDA: 81848235924.14.3A9153A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id A96D91A0010 for ; Fri, 1 Mar 2024 11:24:00 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="WNd85e/C"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709292240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CdFm75SI612rzG5LSQdmLHwZqtK6Mkr5dUxOJrUAiEs=; b=X1y/QeIW3HIYUxniEbteT/scccpr2imchO1BvHumyomTjkgEhslweZUa95fMIvpQjy9jqp e+HuBAferFkEzVOhpmWzBWRVCSGj+JeMFJ0o6ZslTN97CQvIQlD78dFRl/CUY+h1MWxN0D lggkCZPaEEuOeqh2otBEGyPMcBCVR70= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="WNd85e/C"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709292240; a=rsa-sha256; cv=none; b=qzcAXX/CWzRhiyj622ZD0/PJ12+U+6ovovVgNIx5anLA4g91vVgQiPtNyQu580/iyTLqrW mca/fwmGRyWskPItyH111Z4G4dTdcD8uoSCSOCz0tzGrFG5i0yAFDJQClVgfs7+TdZvLeb IhRpI922PAYtIBJgRG1hvIquukfGBZ4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709292239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CdFm75SI612rzG5LSQdmLHwZqtK6Mkr5dUxOJrUAiEs=; b=WNd85e/Cj/a88EGf8lIom06ImNNibEk+OMGqT5HHW7IboTbjIuUMUwFoQKDlwf86GPp10o p+f94LvmPYQo1lvg0Vm0sp0N5VVNt164u+H4kLRkSDQFSD4P9PSo9kJmJQKb4ycaE+9Z+o L2M2JtKyoHb0oW4J35B/MMMNESMpxHI= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-312-IQK3gsMaPiuJq3wIOu_XDg-1; Fri, 01 Mar 2024 06:23:58 -0500 X-MC-Unique: IQK3gsMaPiuJq3wIOu_XDg-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-513332823cfso269292e87.3 for ; Fri, 01 Mar 2024 03:23:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709292237; x=1709897037; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CdFm75SI612rzG5LSQdmLHwZqtK6Mkr5dUxOJrUAiEs=; b=l6V+sHqRv8lLQOf0KVmrz9XnPCDw5N3fnSRzdsBM+6ZnfLc3+XY93DCJKbXseE/QJF V5RAWtjITlkCg1PrdaGP3g8EOZq/vLL+v39r5ZEjHXgSgYoB7tCmpaq+rAa1CywdcTaJ nk2FJXZLh4siqDNcpytMf3h97hNpn2wXvOJ2KqUOqCQK5dCOvubEAG2+6iyBegXJ2sOt 2MG4mDHNhBqyw5cWqMs1LGTIsQnQocuMp/WK3Z4s65UD7iKlE1N3vAmQMnHHrIGPqjVF zq3RCIEmVbpW6A8/I5mQlLpxP+iLMHvCsLtqk2f6U3cIBZdIuPMWxKb21hpGDvqDqp9t nwPg== X-Gm-Message-State: AOJu0YxtYDRTEcdiPZyBIVtBbiMHxV09Re8rmsTUiAq0FjWk4k/DwVwo fJoQSQGgfsm+TQYErd8BmLUFbiSRnsrEy89CgxOUgWtAPezVh93kQUvwEwwWfCdoxgeRh7cVMkA bCuTsJ5lP2MF9LmhYE0/lNFEpt8VO+IaKyWuDpOcW6zVSM18v X-Received: by 2002:ac2:5dea:0:b0:513:2f14:6ccd with SMTP id z10-20020ac25dea000000b005132f146ccdmr893154lfq.39.1709292236790; Fri, 01 Mar 2024 03:23:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IEOUYW4K+NeCQBIawpEcO/nN+46G4ApOq74P9B11pK0cXfghREYdIgne8EroXB2D9n9oAfVkw== X-Received: by 2002:ac2:5dea:0:b0:513:2f14:6ccd with SMTP id z10-20020ac25dea000000b005132f146ccdmr893142lfq.39.1709292236355; Fri, 01 Mar 2024 03:23:56 -0800 (PST) Received: from ?IPV6:2003:cb:c713:3200:77d:8652:169f:b5f7? (p200300cbc7133200077d8652169fb5f7.dip0.t-ipconnect.de. [2003:cb:c713:3200:77d:8652:169f:b5f7]) by smtp.gmail.com with ESMTPSA id bx5-20020a5d5b05000000b0033e103eaf5bsm4120422wrb.115.2024.03.01.03.23.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Mar 2024 03:23:55 -0800 (PST) Message-ID: <1a31af4f-d15c-43c7-9dbf-ae5398b88673@redhat.com> Date: Fri, 1 Mar 2024 12:23:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] mm: Separate out FOLIO_FLAGS from PAGEFLAGS To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20240227192337.757313-1-willy@infradead.org> <20240227192337.757313-2-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240227192337.757313-2-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: riz5fre5wp59coxmxzmq79fjm4xkdhfi X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A96D91A0010 X-HE-Tag: 1709292240-759431 X-HE-Meta: U2FsdGVkX19g78KXVy/hGv1taMDGCHUdtY3b7LKzqNQ32+FZsGQ7UxCZtM2Yhmj/ck9CmTczYS/+9ZPh4pVXw3DWF2qyeiF1jlZTpMJCVIEkFJISryJlIwnPJwk0yle9nhUuLQR1EAz8IYI0kjcug6RDzqLOBy/I+NjOrPne9Vy/IwHo+Y8VSZSlD7MtVxicJ6bC/ZsRWeD7kQ9qWgoI54bJZPOokJ6bZCJBtmoy5DHZEhN6Qt58oPYTzeb8GR4PUJEqziSbYAQD6a5WgvvZDvngjzZHBjjDhyq3kGanJNPXhELocYR6RxBXg0szAfwscQL/P70JQ+ZG9gibDnucOlqrxjGhFn3/higZuhSrP6W+A/H9VI+KSH6GgGZoCfdRhPNzvRxsBg5inwx+zSltppFsNUmSzMqVyVMe25Gv8aDd1xRgcU2s6y+OnJZXqC7hR1E5/tNIdCHUDalPho2Fhd+OoGFvrkFp8gNbug9ha0WJMbQ73/HMMO5qUYQ/YH2XdX715ZxeMuo5k12gHrsrhZiNIoK+zcbQbh1QlrhJ5ytseiez+5e/Iy63gftfZBUlGIyy3hq0a7k6W/OD4CS+5sX29P48sRRGbGGNdqi67cjoEPPG0PmeqNN7t8uyQVLDoWqztVi+WwS7tEAUFTyCRDpnGKoIWQQpD1hUUWSS3jI/WiOsZyx1tJdUrIVa0JHiSJXWPQo/BovpTio8FT7z18Se4hezbN9zfNe1uAwHzEOKj8TnhnxWdp0V6s5x5u0kvnJWI4aHyTB8f5z1GUwOElraflYPfDSRCxQTcs2FsL4GACySzSjcR5gVxHWLiqtvEzZVm9Dj7JR9Pgoc4/jWvZgaPQGmS419DQrwYgaCid9hW6RuhkGR8k6t9NZTmgUKeKA0bwAdlIAXRdBYxVc8aI0E+KL4QACVkBLm0NFa4FIGQhfMSYpF95EVbD5+/qfPaKY1/qqFJf481iHh1Ue 8T4sfjE4 iHLEd+P+iFyil7QSkE9+R4v5Q4fY3BEv/OV7en6Y6nfe5mgswHWlTenSl9aTqo4+E3R91c6oO0a2yUoBjI2MLuppcgchDamrr54Hv1rV9bLXaUeZc+Yl6hg6KHP34EvkZyphY80e5/kFVpnH0qb9oIHf09aXGwhfvY5skuP0ozT83xhYwKfT90X2JIYJ0df5nqPCdhlhVkLIpDLNmdOX/goQo/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.02.24 20:23, Matthew Wilcox (Oracle) wrote: > We've progressed far enough with the folio transition that some flags > are now no longer checked on pages, but only on folios. To prevent > new users appearing, prepare to only define the folio versions of the > flag test/set/clear. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/page-flags.h | 63 ++++++++++++++++++++++++++------------ > 1 file changed, 43 insertions(+), 20 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 735cddc13d20..95ab75d0b39c 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -367,54 +367,77 @@ static unsigned long *folio_flags(struct folio *folio, unsigned n) > #define FOLIO_PF_NO_COMPOUND 0 > #define FOLIO_PF_SECOND 1 > > +#define FOLIO_HEAD_PAGE 0 > +#define FOLIO_SECOND_PAGE 1 > + > /* > * Macros to create function definitions for page flags > */ > +#define FOLIO_TEST_FLAG(name, page) \ > +static __always_inline bool folio_test_##name(struct folio *folio) \ > +{ return test_bit(PG_##name, folio_flags(folio, page)); } > + > +#define FOLIO_SET_FLAG(name, page) \ > +static __always_inline void folio_set_##name(struct folio *folio) \ > +{ set_bit(PG_##name, folio_flags(folio, page)); } > + > +#define FOLIO_CLEAR_FLAG(name, page) \ > +static __always_inline void folio_clear_##name(struct folio *folio) \ > +{ clear_bit(PG_##name, folio_flags(folio, page)); } > + > +#define __FOLIO_SET_FLAG(name, page) \ > +static __always_inline void __folio_set_##name(struct folio *folio) \ > +{ __set_bit(PG_##name, folio_flags(folio, page)); } > + > +#define __FOLIO_CLEAR_FLAG(name, page) \ > +static __always_inline void __folio_clear_##name(struct folio *folio) \ > +{ __clear_bit(PG_##name, folio_flags(folio, page)); } > + > +#define FOLIO_TEST_SET_FLAG(name, page) \ > +static __always_inline bool folio_test_set_##name(struct folio *folio) \ > +{ return test_and_set_bit(PG_##name, folio_flags(folio, page)); } > + > +#define FOLIO_TEST_CLEAR_FLAG(name, page) \ > +static __always_inline bool folio_test_clear_##name(struct folio *folio) \ > +{ return test_and_clear_bit(PG_##name, folio_flags(folio, page)); } > + > +#define FOLIO_FLAG(name, page) \ > +FOLIO_TEST_FLAG(name, page) \ > +FOLIO_SET_FLAG(name, page) \ > +FOLIO_CLEAR_FLAG(name, page) > + > #define TESTPAGEFLAG(uname, lname, policy) \ > -static __always_inline bool folio_test_##lname(struct folio *folio) \ > -{ return test_bit(PG_##lname, folio_flags(folio, FOLIO_##policy)); } \ > +FOLIO_TEST_FLAG(lname, FOLIO_##policy) \ > static __always_inline int Page##uname(struct page *page) \ > { return test_bit(PG_##lname, &policy(page, 0)->flags); } > > #define SETPAGEFLAG(uname, lname, policy) \ > -static __always_inline \ > -void folio_set_##lname(struct folio *folio) \ > -{ set_bit(PG_##lname, folio_flags(folio, FOLIO_##policy)); } \ > +FOLIO_SET_FLAG(lname, FOLIO_##policy) \ > static __always_inline void SetPage##uname(struct page *page) \ > { set_bit(PG_##lname, &policy(page, 1)->flags); } > > #define CLEARPAGEFLAG(uname, lname, policy) \ > -static __always_inline \ > -void folio_clear_##lname(struct folio *folio) \ > -{ clear_bit(PG_##lname, folio_flags(folio, FOLIO_##policy)); } \ > +FOLIO_CLEAR_FLAG(lname, FOLIO_##policy) \ > static __always_inline void ClearPage##uname(struct page *page) \ > { clear_bit(PG_##lname, &policy(page, 1)->flags); } > > #define __SETPAGEFLAG(uname, lname, policy) \ > -static __always_inline \ > -void __folio_set_##lname(struct folio *folio) \ > -{ __set_bit(PG_##lname, folio_flags(folio, FOLIO_##policy)); } \ > +__FOLIO_SET_FLAG(lname, FOLIO_##policy) \ > static __always_inline void __SetPage##uname(struct page *page) \ > { __set_bit(PG_##lname, &policy(page, 1)->flags); } > > #define __CLEARPAGEFLAG(uname, lname, policy) \ > -static __always_inline \ > -void __folio_clear_##lname(struct folio *folio) \ > -{ __clear_bit(PG_##lname, folio_flags(folio, FOLIO_##policy)); } \ > +__FOLIO_CLEAR_FLAG(lname, FOLIO_##policy) \ > static __always_inline void __ClearPage##uname(struct page *page) \ > { __clear_bit(PG_##lname, &policy(page, 1)->flags); } > > #define TESTSETFLAG(uname, lname, policy) \ > -static __always_inline \ > -bool folio_test_set_##lname(struct folio *folio) \ > -{ return test_and_set_bit(PG_##lname, folio_flags(folio, FOLIO_##policy)); } \ > +FOLIO_TEST_SET_FLAG(lname, FOLIO_##policy) \ > static __always_inline int TestSetPage##uname(struct page *page) \ > { return test_and_set_bit(PG_##lname, &policy(page, 1)->flags); } > > #define TESTCLEARFLAG(uname, lname, policy) \ > -static __always_inline \ > -bool folio_test_clear_##lname(struct folio *folio) \ > -{ return test_and_clear_bit(PG_##lname, folio_flags(folio, FOLIO_##policy)); } \ > +FOLIO_TEST_CLEAR_FLAG(lname, FOLIO_##policy) \ > static __always_inline int TestClearPage##uname(struct page *page) \ > { return test_and_clear_bit(PG_##lname, &policy(page, 1)->flags); } > Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb