From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
Received: from mail-pf0-f198.google.com (mail-pf0-f198.google.com [209.85.192.198])
	by kanga.kvack.org (Postfix) with ESMTP id A9DF56B0005
	for <linux-mm@kvack.org>; Tue, 30 Jan 2018 18:54:48 -0500 (EST)
Received: by mail-pf0-f198.google.com with SMTP id m22so12171539pfg.15
        for <linux-mm@kvack.org>; Tue, 30 Jan 2018 15:54:48 -0800 (PST)
Received: from mga01.intel.com (mga01.intel.com. [192.55.52.88])
        by mx.google.com with ESMTPS id s7-v6si3051399plp.57.2018.01.30.15.54.47
        for <linux-mm@kvack.org>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Tue, 30 Jan 2018 15:54:47 -0800 (PST)
Subject: Re: [PATCH] mm/swap_slots: use conditional compilation for
 swap_slots.c
References: <c2a47015-0b5a-d0d9-8bc7-9984c049df20@infradead.org>
From: Tim Chen <tim.c.chen@linux.intel.com>
Message-ID: <1aa4baf5-7d56-84f9-e66d-476acaaec330@linux.intel.com>
Date: Tue, 30 Jan 2018 15:54:45 -0800
MIME-Version: 1.0
In-Reply-To: <c2a47015-0b5a-d0d9-8bc7-9984c049df20@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: owner-linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>
To: Randy Dunlap <rdunlap@infradead.org>, Linux MM <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>

On 01/30/2018 03:14 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> For mm/swap_slots.c, use the traditional Linux method of conditional
> compilation and linking instead of always compiling it by using
> #ifdef CONFIG_SWAP and #endif for the entire source file (excluding
> header files).
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Tim Chen <tim.c.chen@linux.intel.com>
> ---
>  mm/Makefile     |    4 ++--
>  mm/swap_slots.c |    4 ----
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> Tim, is there some reason that this is done as it currently is?

Rearranging code the way you have proposed makes sense.
You can add my ack.

Thanks.

Tim

> 
> --- lnx-415.orig/mm/Makefile
> +++ lnx-415/mm/Makefile
> @@ -37,7 +37,7 @@ obj-y			:= filemap.o mempool.o oom_kill.
>  			   readahead.o swap.o truncate.o vmscan.o shmem.o \
>  			   util.o mmzone.o vmstat.o backing-dev.o \
>  			   mm_init.o mmu_context.o percpu.o slab_common.o \
> -			   compaction.o vmacache.o swap_slots.o \
> +			   compaction.o vmacache.o \
>  			   interval_tree.o list_lru.o workingset.o \
>  			   debug.o $(mmu-y)
>  
> @@ -55,7 +55,7 @@ ifdef CONFIG_MMU
>  endif
>  obj-$(CONFIG_HAVE_MEMBLOCK) += memblock.o
>  
> -obj-$(CONFIG_SWAP)	+= page_io.o swap_state.o swapfile.o
> +obj-$(CONFIG_SWAP)	+= page_io.o swap_state.o swapfile.o swap_slots.o
>  obj-$(CONFIG_FRONTSWAP)	+= frontswap.o
>  obj-$(CONFIG_ZSWAP)	+= zswap.o
>  obj-$(CONFIG_HAS_DMA)	+= dmapool.o
> --- lnx-415.orig/mm/swap_slots.c
> +++ lnx-415/mm/swap_slots.c
> @@ -34,8 +34,6 @@
>  #include <linux/mutex.h>
>  #include <linux/mm.h>
>  
> -#ifdef CONFIG_SWAP
> -
>  static DEFINE_PER_CPU(struct swap_slots_cache, swp_slots);
>  static bool	swap_slot_cache_active;
>  bool	swap_slot_cache_enabled;
> @@ -356,5 +354,3 @@ repeat:
>  
>  	return entry;
>  }
> -
> -#endif /* CONFIG_SWAP */
> 
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>