From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13857C36010 for ; Fri, 4 Apr 2025 17:25:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 624156B0022; Fri, 4 Apr 2025 13:25:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5ABDC6B0023; Fri, 4 Apr 2025 13:25:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44DC06B0025; Fri, 4 Apr 2025 13:25:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 23A836B0022 for ; Fri, 4 Apr 2025 13:25:40 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CEE67160663 for ; Fri, 4 Apr 2025 17:25:39 +0000 (UTC) X-FDA: 83297038398.01.9657E2F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 760B9C0013 for ; Fri, 4 Apr 2025 17:25:37 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z+AVct5s; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743787537; a=rsa-sha256; cv=none; b=FJ7EIKxEPLqsYCKSUMlwagJP4m8WFIgjgTh9kUY7WIPcjfplVJTrqnYPeC33mI8812IQa1 5ALwdbN/H36fUB5DaeaSdvcdxz8lAT+5Tb8x4+4sVAhNoiIwtsiiwLKM6ixGRGDIk8RpA3 jMKDelT8fuEkaYahjluFho46Ebz5u+c= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z+AVct5s; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743787537; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zY1OdvQqmeKzz5CfMBTTTFp4WcoqAgk+p41C7P+KQBs=; b=pM44zH2ZDuDWX2P6XYvIt0XMb4np049EnmyO7OrXI9tpwP/dk4/QRpK1YQjPHdUUUrS5sK Q138mtEkDhL8xES9WHBD2JFgUKySl1DS0WVRKiBWoTCc+jxqDb+JUk9CFJ/NgJkENyI8hx PyFHuubi5B8e6R1RrljiYAILEXg3MNQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743787536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zY1OdvQqmeKzz5CfMBTTTFp4WcoqAgk+p41C7P+KQBs=; b=Z+AVct5s9URF6i9nDm+/GyP9PESXVy0zxt7HlRXExEu6BdE995eWhtUHPE8MIgXsDBqsHm 3t1iuXUnrbjt6rlJIFSvLjvCb4Q8HFo/YGOSJzdXn6Eq0NomObLaq4oFdmLyz6RZ59vPEB RDweDkjBrDK9JR/D+fdVa3uQQ+/zEc0= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-aY1xOKv2N065a6n6LL36RQ-1; Fri, 04 Apr 2025 13:25:35 -0400 X-MC-Unique: aY1xOKv2N065a6n6LL36RQ-1 X-Mimecast-MFC-AGG-ID: aY1xOKv2N065a6n6LL36RQ_1743787535 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4768656f608so48795891cf.1 for ; Fri, 04 Apr 2025 10:25:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743787535; x=1744392335; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zY1OdvQqmeKzz5CfMBTTTFp4WcoqAgk+p41C7P+KQBs=; b=R+jpb47BTEmON3mwayV9oykEyJn+4/Y/wLMIAPNqYd1M7pMJ0Qnjb/Wqf50ILlGTOH vimEVdwZshlanh6wNNJlvy2qu12mLlse4NpmcaDUaU9X0v+xOsJQ0u376bwphr09l/22 YFbSSzj9CFunk2iqUB/JD+vI0/VAhW9a4TD2aagXZXfzicOQQ32LI8d16vsDyMW8/5q1 0mftkA0+P2meI+W2lDjngAAonBtLeg6QAPFjQBIxaYWIjQYuOoNP5blSFK0H2zGSK7Pz AhHm47Y8jEtrh3bNCK01U4u+sK+C5mx4L5m4b+6oyrlAnpL8S5b+3PohJh48ulzgyD52 nFDg== X-Forwarded-Encrypted: i=1; AJvYcCVXKMBeFVr5cqeZl7sHLjviMA3+5IvFPRHOVh9AJfUG4BhwdaQr3iQNcya5wRVIUUbMSt33v8MMog==@kvack.org X-Gm-Message-State: AOJu0YxW0XuHv9RquOmJIE2K/MaA+IZZQymYCPTbbU5HK0mvmqjmMhTO lMeT3UMhXFnGkrXXsaKKGC/AXoltzL6vAg7+1KNhiqC3GF5LMVs6ORzTz4dqXQmpz5Ih4jkftXF ti2g0Pv9g/6LJNuBGSdPfqYk/meyX/R5syjecc3Gjeed9eUsp X-Gm-Gg: ASbGncu6fjx+IJkXuJD6bsJywHz3hpEhL+E/CKBXY7MYoJOD0XZ0ki2+0PxaY+sCed2 R+SVbaZoqs959RN8D9CZ8ZJA30XyFX8uiZVc2M5utmj5ognB4Ix08t6HlVTtSjocJUuIKrVxhNE eMJIhXsFXkg+2W5mLKIK9U5EEOw3OnF1y7z4OXQDV2ghqO6BPbUsJCujyJAWklJMyU2IUuKm9we dkCQsUFVXhy0att/ymf0RHM3LyZVAYjslpq7jhHVFf0FQDa2QFkahUQpBkqNoyZb23S82WYDxs7 gQd7aMmQy0dtGcGiMFkZ58jZQFO1rhCvQ1FjotuqW32hKsYJi3ymMNQpF9bqbQ== X-Received: by 2002:a05:622a:24c:b0:478:de14:135a with SMTP id d75a77b69052e-4792595adafmr51651991cf.20.1743787534886; Fri, 04 Apr 2025 10:25:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEPaEDXj6BQIt1pawQwBSb2n8E48wuGD6upHv6D0WAjJO96YQubjDzEqlaf96Y8LIMcvLc1vg== X-Received: by 2002:a05:622a:24c:b0:478:de14:135a with SMTP id d75a77b69052e-4792595adafmr51651691cf.20.1743787534569; Fri, 04 Apr 2025 10:25:34 -0700 (PDT) Received: from ?IPV6:2601:188:c100:5710:315f:57b3:b997:5fca? ([2601:188:c100:5710:315f:57b3:b997:5fca]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4791b0883f1sm25312231cf.42.2025.04.04.10.25.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Apr 2025 10:25:34 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <1ac51e8e-8dc0-4cd8-9414-f28125061bb3@redhat.com> Date: Fri, 4 Apr 2025 13:25:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] memcg: Don't generate low/min events if either low/min or elow/emin is 0 To: Tejun Heo Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20250404012435.656045-1-longman@redhat.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GyJfo1_VkktJvemycRND00Z5ScFX2PX1GV0P453hre0_1743787535 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 760B9C0013 X-Stat-Signature: wk1mkcrwpyipi41gsc846ibu51etuihk X-HE-Tag: 1743787537-28458 X-HE-Meta: U2FsdGVkX19EaabpApJrH8/Kyw/xlrzWPYUXIx2Jimz9WjG11YE2DpalLButPffrwf5EfkXB2jyiJwfwrZVB6Q1tkZNXga/pc/BuD/6udWZs6tuS/knotIgpWeI/7dBR0olrJP3AECR8nipYZfb56U/BS98iiLlbPwdXeHgt1iYK8ODhqqn2UBYYo+Iv04983ro/ewQRTegwDWmDBBpqi1DKGgvjCPf99N7P9lM+v+obtPntoeM0lJx+izfCR/e8GMTBBKlvLTxsDmmNmTPd3wkDarTCaM8nPDK7DqKgllYJbfzol5uWbAISITr9ffV/ejvn2AHgPNjX+0p+JMhRoW5n/F/RwBwgj8rBpo4Oy1kVkHjgypoc+dJ6pnDOEv3G9v529hKz2nJQvAg8DMoozKdxu+CTNGB/TIcvqoua5Ntlbxt19zpge1hFPsgHVeFL7Ppae8ZRSaEhPR3sqtrLN7ktTCSQ5y5YfzJG5qniigdVlQR/DaYL0n7m1K1W+YkD/iz2lguRmxgxx8ccrAYfmkPHl1z/usFZkz4OOvXMl1ab5gIgRDo2NQ8SccLiWVJlhPXgAzze2gia6vupvVrHKnSZZuJEb6r2NyPn0EMGHD30vHz0H83Ye8rOpu63BHBC6unLUqSN+CY5sxShFgVHL0NnpkzbGECnrMcq/SZrS8zYA9md+ijd1NE+GzK7j1PNt7fVA/EzO94SJCD522e09EE/QxBqUITK2CgxAS0hre+3lgRqQfP72Q+QJFX4qDLqn/HZpFdQYM+eZwS5VLZ3Wvy1KmtWJon8MNIhJVs/H4FU8gPesVMqEH+QmyNhl3HXgmRgir8LpLviVS7eMtymLXhnB0bQ5HpeYWmBKWySGeWrz/G/N7e04P+DzYoEavHIQwD6Ffn/44Hq5jC2JfN0wxHNaGHCBc2P0lKVEpDqO5SaJ+6SBxFHf6yIqztu6g2O87Z9Xv4J8SNemgSEPh2 TFRo1U+3 sjg9WYu9TVnlD9WrAXQomCPs9CpYUisMfbzKsmHgpHI1oOOd0tU1ACPns/8Bsif4DrI2jbNwCx80IBYhl+W02zoiGARvGRzyL5+i32RnK6Qd+L0cdqzdg1IhMWlVbWghXwUpJ1pgEdMdKPeulUeAaxoRyrVp6aIuuUUgH8tGy1prv2gQ23dPfh6Tx+ts9v+lpOLb2B47sMbgAEw4ZxmYOt3s97shbL7QP01z/D8DA1xXQTPSX5hhxenDAamvtB77KRcbvJcc1E8nvOqbS3QyuJhrRtGDi4DMGdlJob++Bw/CHoBI3wzKFeYcnb0c0RmOlLMkraYC/1XaHQvujjQbjjIb9oc2u4WnRDJ2tbOqpacHBlJI5E/QCx/SHq21CsaOzu9s7F2Fye2ba8PJ/rvCgsYw11iNYF0z6QuS22C7pTwR9XDXri/3UFRHHAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/4/25 1:12 PM, Tejun Heo wrote: > Hello, > > On Thu, Apr 03, 2025 at 09:24:34PM -0400, Waiman Long wrote: > ... >> The simple and naive fix of changing the operator to ">", however, >> changes the memory reclaim behavior which can lead to other failures >> as low events are needed to facilitate memory reclaim. So we can't do >> that without some relatively riskier changes in memory reclaim. > I'm doubtful using ">" would change reclaim behavior in a meaningful way and > that'd be more straightforward. What do mm people think? I haven't looked deeply into why that is the case, but test_memcg_low/min tests had other failures when I made this change. Cheers, Longman > > Thanks. >