From: Vlastimil Babka <vbabka@suse.cz>
To: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@techsingularity.net>, Zi Yan <ziy@nvidia.com>,
"Huang, Ying" <ying.huang@intel.com>,
David Hildenbrand <david@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] mm: page_alloc: optimize free_unref_folios()
Date: Mon, 25 Mar 2024 16:56:58 +0100 [thread overview]
Message-ID: <1ad38cac-e90d-4d9a-bf5e-afbcf6ca5bc5@suse.cz> (raw)
In-Reply-To: <20240320180429.678181-3-hannes@cmpxchg.org>
On 3/20/24 7:02 PM, Johannes Weiner wrote:
> Move direct freeing of isolated pages to the lock-breaking block in
> the second loop. This saves an unnecessary migratetype reassessment.
>
> Minor comment and local variable scoping cleanups.
>
> Suggested-by: Vlastimil Babka <vbabka@suse.cz>
> Tested-by: "Huang, Ying" <ying.huang@intel.com>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
next prev parent reply other threads:[~2024-03-25 15:57 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 18:02 [PATCH V4 00/10] mm: page_alloc: freelist migratetype hygiene Johannes Weiner
2024-03-20 18:02 ` [PATCH 01/10] mm: page_alloc: remove pcppage migratetype caching Johannes Weiner
2024-03-20 18:02 ` [PATCH 02/10] mm: page_alloc: optimize free_unref_folios() Johannes Weiner
2024-03-25 15:56 ` Vlastimil Babka [this message]
2024-03-20 18:02 ` [PATCH 03/10] mm: page_alloc: fix up block types when merging compatible blocks Johannes Weiner
2024-03-20 18:02 ` [PATCH 04/10] mm: page_alloc: move free pages when converting block during isolation Johannes Weiner
2024-03-20 18:02 ` [PATCH 05/10] mm: page_alloc: fix move_freepages_block() range error Johannes Weiner
2024-03-25 16:22 ` Vlastimil Babka
2024-03-20 18:02 ` [PATCH 06/10] mm: page_alloc: fix freelist movement during block conversion Johannes Weiner
2024-03-26 11:28 ` Vlastimil Babka
2024-03-26 12:34 ` Johannes Weiner
2024-04-05 12:11 ` Baolin Wang
2024-04-05 16:56 ` Johannes Weiner
2024-04-07 6:58 ` Baolin Wang
2024-04-08 7:24 ` Vlastimil Babka
2024-04-09 6:21 ` Vlastimil Babka
2024-03-20 18:02 ` [PATCH 07/10] mm: page_alloc: close migratetype race between freeing and stealing Johannes Weiner
2024-03-26 15:25 ` Vlastimil Babka
2024-03-20 18:02 ` [PATCH 08/10] mm: page_alloc: set migratetype inside move_freepages() Johannes Weiner
2024-03-26 15:40 ` Vlastimil Babka
2024-03-20 18:02 ` [PATCH 09/10] mm: page_isolation: prepare for hygienic freelists Johannes Weiner
2024-03-21 13:13 ` kernel test robot
2024-03-21 14:24 ` Johannes Weiner
2024-03-21 15:03 ` Zi Yan
2024-03-27 8:06 ` Vlastimil Babka
2024-03-20 18:02 ` [PATCH 10/10] mm: page_alloc: consolidate free page accounting Johannes Weiner
2024-03-27 8:54 ` Vlastimil Babka
2024-03-27 14:32 ` Johannes Weiner
2024-03-27 18:57 ` [PATCH 1/3] mm: page_alloc: consolidate free page accounting fix Johannes Weiner
2024-03-27 18:58 ` [PATCH 2/3] mm: page_alloc: consolidate free page accounting fix 2 Johannes Weiner
2024-03-27 19:01 ` [PATCH 3/3] mm: page_alloc: batch vmstat updates in expand() Johannes Weiner
2024-03-27 20:35 ` Vlastimil Babka
2024-04-07 10:19 ` [PATCH 10/10] mm: page_alloc: consolidate free page accounting Baolin Wang
2024-04-08 7:38 ` Vlastimil Babka
2024-04-08 9:13 ` Baolin Wang
2024-04-08 14:23 ` Johannes Weiner
2024-04-09 6:23 ` Vlastimil Babka
2024-04-09 7:48 ` [PATCH] mm: page_alloc: consolidate free page accounting fix 3 Baolin Wang
2024-04-09 21:15 ` kernel test robot
2024-04-09 22:36 ` Johannes Weiner
2024-04-09 21:25 ` kernel test robot
2024-04-09 7:56 ` [PATCH 10/10] mm: page_alloc: consolidate free page accounting Baolin Wang
2024-04-09 8:41 ` Vlastimil Babka
2024-04-09 9:31 ` Baolin Wang
2024-04-09 14:46 ` Zi Yan
2024-04-10 8:49 ` Baolin Wang
2024-03-27 9:30 ` [PATCH V4 00/10] mm: page_alloc: freelist migratetype hygiene Vlastimil Babka
2024-03-27 13:10 ` Zi Yan
2024-03-27 14:29 ` Johannes Weiner
2024-04-08 9:30 ` Baolin Wang
2024-04-08 14:24 ` Johannes Weiner
2024-05-11 5:14 ` Yu Zhao
2024-05-13 16:03 ` Johannes Weiner
2024-05-13 18:10 ` Yu Zhao
2024-05-13 19:04 ` Johannes Weiner
2024-06-05 4:53 ` Yu Zhao
2024-06-10 15:28 ` Johannes Weiner
2024-06-12 18:52 ` Yu Zhao
2024-06-13 15:39 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ad38cac-e90d-4d9a-bf5e-afbcf6ca5bc5@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=ying.huang@intel.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).