From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A91E6C55182 for ; Mon, 3 Aug 2026 13:27:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C9B86B00AA; Mon, 3 Aug 2026 09:27:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97A2E6B00B4; Mon, 3 Aug 2026 09:27:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8689E6B00AE; Mon, 3 Aug 2026 09:27:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 63F726B00A6 for ; Mon, 3 Aug 2026 09:27:54 -0400 (EDT) Received: from smtpin01.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 480EF120623 for ; Mon, 3 Aug 2026 10:58:00 +0000 (UTC) X-FDA: 85059658320.01.70EBFEF Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf04.hostedemail.com (Postfix) with ESMTP id 95C1F40008 for ; Mon, 3 Aug 2026 10:57:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=keGSn+No; spf=pass (imf04.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1785754678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZHWedN9HTiKNPKM2UeIn5hc0h14AOA6NJD1WFD6iHwU=; b=pBf+l9I8V864R1jYLFSFiYdG9a+1XSvmofx2ZkqQ6SaBRgeREmCs4Nrwl0HlNfeTAWFYSl 3LvUWjhGuaMDIeENoElXYPIY6quAJKtSrcsHr2TvticIrn9D3RJvc2DkvZjD7Hm0fzyZFW TRX3Cbi+G5uRTo41eyv4gsAyllb/8Zc= ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1785754678; b=yVhPvaYBVYkcxqpazO+/FPjBWvnvIK/BpPgX4919FhZvgrgvnbJZzitUe4SZ4bwVBnFFYF q55XSpELpWp1aPzIUPFRcgCtXRqY24DWJevvVVQunYHvo2F/Y/lhlZafg7Zs5M7rPU3Jsr pHDo8qvbH+BBp38WhAlNlr6Qbo4Ffek= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=keGSn+No; spf=pass (imf04.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 577CE60A78; Mon, 3 Aug 2026 10:57:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 443621F000E9; Mon, 3 Aug 2026 10:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785754676; bh=ZHWedN9HTiKNPKM2UeIn5hc0h14AOA6NJD1WFD6iHwU=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=keGSn+NocOSPaRF0FVAdR3BQyhO2iffHD6rtxrlDVMdlUtRFcGBkOFho19tBDB+FW R5dx6Ra5WZQV+RDiW/Aj+ygex6v8mnmevdMI+QmJ6dSh4YgpttnDWEzkH1PVECHzf8 4zKv+sdm/MDPMaY8QmSet4+S+C4XVhtFOslg1qjvZ865TZHjK7QaTUU0Sjat7ejHXI 8oj1l+WiAiEqD7MoOWw7VcT1OZ00u1FsMHaJCQfe4o46EuVeon0aTs7KUcYLbQdL8X 0JUTEgFTgOcmOVt5/m6rc+lBfIQ3qL2eBxNM0D1b24A4v3Zse2s2fagfnSQ1MKKJwu 6vmEPJM+Ot1VA== Message-ID: <1b48cf7d-8906-43d4-a85d-5cfad10a12ac@kernel.org> Date: Mon, 3 Aug 2026 12:57:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/15] mm/rmap: track whether the page VMA mapped pgoff is anonymous To: "Lorenzo Stoakes (ARM)" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , "Matthew Wilcox (Oracle)" , Jan Kara , Miaohe Lin , Naoya Horiguchi , Rik van Riel , Harry Yoo , Lance Yang , Kees Cook , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Usama Arif , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Peter Xu , Xu Xin , Chengming Zhou , Arnd Bergmann , Greg Kroah-Hartman Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20260729-b4-scalable-cow-virt-pgoff-v3-0-e8ecfefea812@kernel.org> <20260729-b4-scalable-cow-virt-pgoff-v3-7-e8ecfefea812@kernel.org> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20260729-b4-scalable-cow-virt-pgoff-v3-7-e8ecfefea812@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 95C1F40008 X-Stat-Signature: 49j4ks5m4t3yk8m95kpmfj6mk9eyec4p X-Rspam-User: X-HE-Tag: 1785754678-39702 X-HE-Meta: U2FsdGVkX1+AyAOHbF8XrJ+bTyR8bhLYbkptg5yPUh2IlBmNoxwq9DnKr8rj52Jk30ydACiauBJn2FWf3c3qZ3se6JbohSd6dftaJv+/6pJB5sydh2HCKhWK2OFexW0vT+Ayfb+k65Skh8l0vihwVOx+tT9aAC8WJvChArmf76Brouk2Lbxc9U7UYPpVISOLaOBAiRnIGR4oIhgsqZJMOK1nsRJOQo9MEPxq9dQZmtoS0kxn6gllBHbY+/ywABOOXiulhce1OCJ3w8Ao50F5k8jH8RFCKkJ49mdJIGYEuSNKiepwfcphRgjmNBQylmlKC8Zlp0VrE5qYV2miUyJIKDuEvdQqm8FSB4LdPvu+I6hME8Oew5j251PgtgfUs+pzhIeHRNKpJkD8U+VWPuogOCauAzb23WFibvlUFPIms0zEa80qbbVlcqhCyKHS0cSKPt0CSrpJ6xN8FqC0ZzuvnE6cxn0BwISF/WvK16NNVOo38QZAFEFC1aCUVRRDbdTlsr7ChoVGe/JjTPfJK7UhDaa6DxJonYHHBz9DWdUkgrWHeBA1+ainSxhF4FicH1yVSJP7fSC1DDSXcfvrN+S4ItMv3suSafqZ+rmU7JIGMY3iaSria2A3o0BHIMUZToG4WKm6r6VPChYThLYLzdxSZxGkE7BUWWwMfB2mYmm3F5cT+DWpfqUS0B/eqj3x4admnyTNwxcL75pHYtxakoIVmWJVnwXpRNePWSYZGReTgnLizyjSQINBgBGbp0PSGXRCykx4QJFDv6aabjB/PGNjYwWngrMrwa6oFWPzf0plHE59sU6AnGvELbpkxemIJCfAevEx3/jBzI78VRPFWeTLAV4lBpbEEHuOYgWnjDofFYX9MfDpdme90ZHoQP80q1lXqEbpl4yRYQ05WYXrX02H8WNFig0HH2RPZ5BCXU1BPPMGQ/iuqA0ERfFcSE/0XIs3A+ri6lGCs+JxZDsNfVe 89vXLUPk U7ilQHH5oJqbAawk2FWeDUbYTb47u8zis7en026YfyBIx7SWlusX+IXjG2Wrl0EOpmVirrQ/OlrtLhZrxV9dFIBJl8PXEvcljJS6nHCMKzLXjYh1VWfUx0VbJ9JQGv5VrGMwrQ7kdab2aMdxL2eGJ0Je63C/1f/9TBtLyLHGav0K4+niHJm7fBIsOoEwvBVpvMMQwImYG8JWl+qXn/F7RRXbmzA3I+KT3/mH6C4bmHFsPioOxaPOsGcveD1OK9i29xY69oB8rNRT2x4ODtCvZwnlfbPTkWNnY9hw/zAJnIVeE0w/fcsHhgX1bI+z1j9z6ApkZSGE6yWyC6Kg= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > /* > - * Then at what user virtual address will none of the range be found in vma? > + * At what user virtual address will none of the range be found in vma? > * Assumes that vma_address() already returned a good starting address. > */ > static inline unsigned long vma_address_end(struct page_vma_mapped_walk *pvmw) > { > - struct vm_area_struct *vma = pvmw->vma; > - pgoff_t pgoff; > + const struct vm_area_struct *vma = pvmw->vma; > + const pgoff_t pgoff = pvmw->pgoff; > + pgoff_t pgoff_vma_start; > unsigned long address; > + pgoff_t pgoff_end; > > /* Common case, plus ->pgoff is invalid for KSM */ > if (pvmw->nr_pages == 1) > return pvmw->address + PAGE_SIZE; > > - pgoff = pvmw->pgoff + pvmw->nr_pages; > + pgoff_vma_start = vma_start_pgoff(vma); > + pgoff_end = pgoff + pvmw->nr_pages; > address = vma->vm_start + > - ((pgoff - vma_start_pgoff(vma)) << PAGE_SHIFT); > + ((pgoff_end - pgoff_vma_start) << PAGE_SHIFT); > /* Check for address beyond vma (or wrapped through 0?) */ > if (address < vma->vm_start || address > vma->vm_end) > address = vma->vm_end; Am I wrong or are all all changes here completely irrelevant for this patch? You mention "This is necessary in order to determine the correct VMA page offset in vma_address_end() when pvmw->nr_pages > 1." But I don't spot an effective change here. -- Cheers, David