From: "Gladyshev Ilya" <ilya.gladyshev@linux.dev>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: ivgorbunov@me.com, Liam.Howlett@oracle.com, apopple@nvidia.com,
artem.kuzin@huawei.com, baolin.wang@linux.alibaba.com,
david@kernel.org, foxido@foxido.dev, harry.yoo@oracle.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
lorenzo.stoakes@oracle.com, mhocko@suse.com,
muchun.song@linux.dev, rppt@kernel.org, surenb@google.com,
torvalds@linuxfoundation.org, vbabka@suse.cz,
willy@infradead.org, yuzhao@google.com, ziy@nvidia.com,
pfalcato@suse.de, kirill@shutemov.name, ilya.gladyshev@linux.dev
Subject: Re: [PATCH v4 0/2] mm: improve folio refcount scalability
Date: Tue, 09 Jun 2026 19:02:25 +0000 [thread overview]
Message-ID: <1b6509a832dba9a7e24ddcdc23fb75247b267c78@linux.dev> (raw)
In-Reply-To: <20260608154734.8e4115fde4e2e14a3b6892fb@linux-foundation.org>
>
> On Mon, 08 Jun 2026 21:53:01 +0000 "Gladyshev Ilya" <ilya.gladyshev@linux.dev> wrote:
>
> >
> > This patch optimizes small file read performance and overall folio refcount
> > scalability by refactoring page_ref_add_unless [core of folio_try_get].
> > This is alternative approach to previous attempts to fix small read
> > performance by avoiding refcount bumps [1][2].
> >
> Thanks. Nice numbers.
>
> AI review had some things to say:
> https://sashiko.dev/#/patchset/df26082871b4c65b2bd38d409026237c08572836@linux.dev
Will look into it, thanks
> I'm not sure we want all those new VM_BUG_ON_PAGE() calls in the long
> term. They look like development-time assistance. Perhaps you could
> make those a standalone patch at tail-of-series so we can keep it in
> linux-next for a couple of months then throw it away before any
> upstreaming?
They are cheap and can catch bugs that are very difficult to debug. So
I'd like to keep them, if possible. Maybe change to WARN_ONCE, as David
suggested.
next prev parent reply other threads:[~2026-06-09 19:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 21:53 [PATCH v4 0/2] mm: improve folio refcount scalability Gladyshev Ilya
2026-06-08 21:54 ` [PATCH v4 1/2] mm: drop page refcount zero state semantics ilya.gladyshev
2026-06-08 21:54 ` [PATCH v4 2/2] mm: implement page refcount locking via dedicated bit Gladyshev Ilya
2026-06-08 22:47 ` [PATCH v4 0/2] mm: improve folio refcount scalability Andrew Morton
2026-06-09 10:28 ` David Hildenbrand (Arm)
2026-06-09 19:02 ` Gladyshev Ilya [this message]
2026-06-09 21:02 ` Pedro Falcato
2026-06-20 18:19 ` ilya.gladyshev
2026-06-21 1:40 ` Zi Yan
2026-06-21 4:46 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b6509a832dba9a7e24ddcdc23fb75247b267c78@linux.dev \
--to=ilya.gladyshev@linux.dev \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=artem.kuzin@huawei.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=foxido@foxido.dev \
--cc=harry.yoo@oracle.com \
--cc=ivgorbunov@me.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=torvalds@linuxfoundation.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox