From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AA04C5B543 for ; Tue, 10 Jun 2025 13:14:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B3DB6B008A; Tue, 10 Jun 2025 09:14:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05D4F6B008C; Tue, 10 Jun 2025 09:14:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E67636B0092; Tue, 10 Jun 2025 09:14:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C588C6B008A for ; Tue, 10 Jun 2025 09:14:56 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 43E5B1D0B49 for ; Tue, 10 Jun 2025 13:14:55 +0000 (UTC) X-FDA: 83539536150.10.AED88F5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id A059C14000C for ; Tue, 10 Jun 2025 13:14:52 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UZZ95Xm+; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749561292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3ouH/PJFEkAjFGDBxmHkInwDz0FSY52fc2pNnFWKOY8=; b=AZgqcsYakqcpuy3XOL+hb9+Gy7oCKrI3V+eghBWhWJO2cmM3uFoCw2C1U5OY71MXO/xAOp C66vplsr9XqohZchyluvKxPDaxwHz1cPzSKkLl93ic3Z/U+bxDVq+/M05nTkW93AgLwDmE YkYq52w5aUf+R+TzIcyKnqJ3DP3D6X4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UZZ95Xm+; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749561292; a=rsa-sha256; cv=none; b=f0xZSB07jgrBKH6q/NK0JcneZehUBOyam1oGLVhU9HZWONJ7FvmTNmDVw6VrRKSLhlrf7F 5540aREDrcLNmXYRJh8d5H6j/LojipItlRKTw1MmDNh6bZsPp2Egb6I5f3yYAK2xvn+F2h PTLTNThnabZL0j1wrMUjIeB7vNOhXE4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749561292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3ouH/PJFEkAjFGDBxmHkInwDz0FSY52fc2pNnFWKOY8=; b=UZZ95Xm+7aeai12GysQs8tkTsn0aP8T9yLYHBH350Yc4Mpj9QVrmpK3MnXyt0phMLHRysp f6slVN5+sHHcUh8lzy/64IrWfACeDCVIekYIIcbcIEuVhYI2RT860OkGc7Jv0eadkVhHp4 94y4d4EMDHlPBi1Ar0Dt9eNBMzUhebs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-451-h9Iw6M0PN1KpoC4FRjJyCg-1; Tue, 10 Jun 2025 09:14:50 -0400 X-MC-Unique: h9Iw6M0PN1KpoC4FRjJyCg-1 X-Mimecast-MFC-AGG-ID: h9Iw6M0PN1KpoC4FRjJyCg_1749561290 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-450eaae2934so48981095e9.2 for ; Tue, 10 Jun 2025 06:14:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749561290; x=1750166090; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=3ouH/PJFEkAjFGDBxmHkInwDz0FSY52fc2pNnFWKOY8=; b=cnYItmhnc7GphYMui7klHAfsWE0Myb04NWS24U8+qkF1N7Isf6OuXhQnG7KUa/1duZ CVF9ajWA9pjsf7QxQ9a1zSrikMwsgcfzv0CNJh3yIM2NQYOZoqiFMCVadHByzE1NpabK NifXAD4kMHTp2LXbiAndCSHcoboPUVC1DeY3qwX1oOPDVFrzuJ/dto816WF5RQaqK201 vP/UyfjvERJcwJTf4NS0aEwF6ure8uKHmRFJaZRkmPMZ4GgeWp9/L7fDK4wO4mdONgMm yNn5LQcILMPojzqshiAt83RvikX1PMMTvxuCKkd5aLuay4vp8l/fIMTROFRTMFqzW8es 9l6A== X-Forwarded-Encrypted: i=1; AJvYcCUk3jeBuWTXyZm8JV5Y+P/rhVj/INJDLU0JEFNTnCrjZ35XBjyE6ODp740cputr/ia5JSlJSzFABw==@kvack.org X-Gm-Message-State: AOJu0Yzp/KF6+YzMgdTu9zAH3wscvYhj2qSeeKmb4ij2qzNuMnaZbBLA w/7l7LupUISDPbucUQWm3kYwA3WN5rOKs1vZPJpSCJEdl5j2/8LN8cZ5igicmgzBch8wwpFsJ4j q3E+G8FV3hrmDhFqOZ6IafDR2OXPvzvd4sYTKd6S9Eth2kv7j7SZF X-Gm-Gg: ASbGncueypDMkjmgvlBwFcUt+mg5Yc8VPayJlNrK+plJltHUwliIXs2rDUicgdNaI87 m+NW4sFs5h6KeMRGSqK8FglWWk/27Skvtoge2XOsLy+VDBKuevK37tLozpF1ZuEhXt9yZqXeANX //TiI72mzbEWSqtmtVcf145v7Wi1fn7hNp1A2VX/0+HkOoCs7MGI/yzQa/cP7+lZdHek3IySsHX 9g7514Y4GcDk+ffnEhtISOKJh4GB5SPJwKmW2gHPwLntU9JAoQtNCE4oB5pHO/uQ+CZbqu1xmdr vNN8zkMuP7ObW1s0LGZwJzZD4uLBr+E1PWhYjOYw9mC7RzQjLsWw7mQ= X-Received: by 2002:a05:600c:8b6e:b0:450:d422:2092 with SMTP id 5b1f17b1804b1-452014557d1mr149407245e9.8.1749561289776; Tue, 10 Jun 2025 06:14:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbxtZldNzSnPZLU/kGR9eWXkVvoxMrfRnzlaElJKdZcYo4jd1SgsAP7wqzt6fVFzT3iNngtQ== X-Received: by 2002:a05:600c:8b6e:b0:450:d422:2092 with SMTP id 5b1f17b1804b1-452014557d1mr149406935e9.8.1749561289346; Tue, 10 Jun 2025 06:14:49 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452137290b9sm141807225e9.34.2025.06.10.06.14.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jun 2025 06:14:48 -0700 (PDT) Message-ID: <1b94d8ce-ab6c-417d-af4e-cd49bf297b60@redhat.com> Date: Tue, 10 Jun 2025 15:14:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: pageattr: Use walk_page_range_novma() to change memory permissions To: Dev Jain , akpm@linux-foundation.org, catalin.marinas@arm.com, will@kernel.org Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, steven.price@arm.com, gshan@redhat.com, linux-arm-kernel@lists.infradead.org, yang@os.amperecomputing.com, ryan.roberts@arm.com, anshuman.khandual@arm.com References: <20250610114401.7097-1-dev.jain@arm.com> <20250610114401.7097-3-dev.jain@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250610114401.7097-3-dev.jain@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: shqGn0ZTBBZX-8SDrraIeYRSp5FzmbdPwsF9ChHIQm8_1749561290 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A059C14000C X-Stat-Signature: zcmay6ft8op5e3pehpt1t1t7pmcpy8kb X-Rspam-User: X-HE-Tag: 1749561292-218518 X-HE-Meta: U2FsdGVkX1/RAkg1F8yAZWuJ04WIhWz4lz+jYXV6mlUWtPFiR6tuWJ9SMkR61iZpiDMbLq5C4DXEEjgcb9wfe9LSiYBKQQNw8iMJpevxDC7K/MnLDSHPCwyTAO6gMMDKz3JyvIGjupV7+QKXexTAJBdoRK+NHtzDIsDGR4goO3oFCkhp30FzYByscsGp6Hj53otc7RyeRzICOU7pDIUWfwRMqtYMOWkUkl8eRE8vudQ8AItDR21N2hQYvLPDdCmmPOujB+4G1xOBkqMgnjkPIUH/w1rXfCh7y40rlfB0aukAFH8sbzM3zkHOG4tOxz88yZqHGNrn+XFDRe8M12h+Cib8pO20dgQGkeiTu6b01mngSpT2rTcRu1h6amLSRBRUw3gWvT4zuvJq1MlnedRmIo7M930HwaHealol73cvRDk5yAQWakp+Smr3ScQL+Al8NABcYyTuU6tsIfjnVTnNNsGt/++cHMtqZA/1ckSWp9JtonDfXNVrBgcuAeVeTwT4uUqTtO4IJtgZQFJtDO9UY737XAG/5YMKnvTXn8RmVQpdzoB2Bw8eTWgaDfOvdIKKoDt0GAnjxu6CtrFbCCX+tKqSo6YV5a4y2y7FA2qJ+Y0mtqCsC95UKXBAUmKcM7OgJrQ6deL1rNO0oonFFkz2xOjCmEjNVjZVGonSDSHI24rXJIj3lhU1BIFJc97y73cm/dyV8rMLpMtgnhpt8NlvKs2TzO+ZuInK/OMlX76q56jTaxLef1fIiAr61PpTHQ4AiV/Ds4v3RDk/+4M+VUcUH+z4cEeGRPEE1HjEUFkKJII02ynKwuZBe10IzcULsf4AhiUY0p2Y4dHPopfE9vEGlcGWlbU6c5JQA0GZiA1704KF5RYut8WtjKkHX55JXTo67kh7t3huef/nXXYDIRj59wgbxZC2nyArc5mko2aXBAU1SE1bnvkkqn9hwSHHkcWJWTSdYZODyOWwt55B/sU /ovcRSkB 0mN+sqsYPhTw3a6P+xLQJTgDVz8JOV5pRxfeTf+EusaLexVx9/yq4rOkkKMDMcOqANEIm2OnsieZfox+tbvsPYJayOqa5jzwDDFAinuka+kKRojFjwg7BaL+DS/TsFkwLu+gon6OA8hWFAxICht+6yZ0EtQiyqGgIJ5A6dfhjK4w2u3R1RmqOaO0wmhtoeu0wAx3t8fWB47SlIh1PDfliAqnRHtUdNOTZI8Ia+MeAi90V94f+92/FUIX6zFuP/3/MRnKGEJuqKtS4PYRY/qiSkxVmHsN831gjaiEzdzY+/1FzOXWIAiz7csql6O38bWJK/93G4AsTXoPq3IpUphqQfHEIfbVlj22x1988hod8Ho/0Qm66dlyROUjUBnJw5IkuJ+NQ5M9tlPz9QeC0fJCSGNgaUJf/BFfzeML58TBlSwGo/zxqUUy/jcY6l8cmKhx2PD8ETrK66J0FK50DrCvxcFYyfGaaHKQvmDhpOIFnHHgQZBohHWL3bZvaPruF4FTdr+pcGb29LsUWTwrcDESPbS+D5xjWEJ/ARi3cylJtHG1afz8qq3CrazNMvrZGPzTEG+nN8ddyZu8Xhd+65hT6VXAWvxRPJNi+DN/Y7ocWnvF1alc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.06.25 13:44, Dev Jain wrote: Subject seems outdated: walk_kernel_page_table_range() > Since apply_to_page_range does not support operations on block mappings, > use the generic pagewalk API to enable changing permissions for kernel > block mappings. This paves the path for enabling huge mappings by default > on kernel space mappings, thus leading to more efficient TLB usage. > > We only require that the start and end of a given range lie on leaf mapping > boundaries. Return EINVAL in case a partial block mapping is detected; add > a corresponding comment in ___change_memory_common() to warn that > eliminating such a condition is the responsibility of the caller. > > apply_to_page_range ultimately uses the lazy MMU hooks at the pte level > function (apply_to_pte_range) - we want to use this functionality after > this patch too. Ryan says: > "The only reason we traditionally confine the lazy mmu mode to a single > page table is because we want to enclose it within the PTL. But that > requirement doesn't stand for kernel mappings. As long as the walker can > guarantee that it doesn't allocate any memory (because with certain debug > settings that can cause lazy mmu nesting) or try to sleep then I think we > can just bracket the entire call." > Therefore, wrap the call to walk_kernel_page_table_range() with the > lazy MMU helpers. > > Signed-off-by: Dev Jain > --- > arch/arm64/mm/pageattr.c | 158 +++++++++++++++++++++++++++++++-------- > 1 file changed, 126 insertions(+), 32 deletions(-) > > diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c > index 04d4a8f676db..2c118c0922ef 100644 > --- a/arch/arm64/mm/pageattr.c > +++ b/arch/arm64/mm/pageattr.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -20,6 +21,100 @@ struct page_change_data { > pgprot_t clear_mask; > }; > The general idea looks sane to me. -- Cheers, David / dhildenb