From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A797C433F5 for ; Mon, 27 Sep 2021 17:34:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D684F60F4A for ; Mon, 27 Sep 2021 17:34:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D684F60F4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 565546B006C; Mon, 27 Sep 2021 13:34:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 514C66B0071; Mon, 27 Sep 2021 13:34:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DB546B0072; Mon, 27 Sep 2021 13:34:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id 309886B006C for ; Mon, 27 Sep 2021 13:34:08 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D842382499A8 for ; Mon, 27 Sep 2021 17:34:07 +0000 (UTC) X-FDA: 78634051734.19.ED309AA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 7AA4E20019D3 for ; Mon, 27 Sep 2021 17:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632764047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VGALT2fxCpmPpY+7KVSQkrZnOp9lkNjd+JdjPKf4UQA=; b=DdOvoJa/KAW9ebIVgjaksf/n6uGbBjg+Q6LkVPD9ZmyDmouZ9kcYvV32EIpB2QB75z5kHq Xv1/4et6LSFrWKAURZn8t6/0R7cHyj+pXdLxehNRFIo5W16hWEWsuvEhRvIRszA8NmnJJu ivXc58qzgW+WEpD1LFFcx3VHEl+Aqp0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-9oLToiTCMxWOpz2prqqJ9A-1; Mon, 27 Sep 2021 13:34:05 -0400 X-MC-Unique: 9oLToiTCMxWOpz2prqqJ9A-1 Received: by mail-wm1-f71.google.com with SMTP id x10-20020a7bc76a000000b002f8cba3fd65so495683wmk.2 for ; Mon, 27 Sep 2021 10:34:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=VGALT2fxCpmPpY+7KVSQkrZnOp9lkNjd+JdjPKf4UQA=; b=bkBRNGBhQmK4lP5SWjCC4TWgzQYrWX7YvQsezadcMWJgrMfTkQIp/Bqyu/lXXvgQYa bbwMOoy50N3LEw8PreZl0GSsUX+sX8WE5sgXATVOTxNfBz6nVupGPj0soBzmHGAyByY5 q9mYaLsPO8InVPntBALT6rhAa634BK0yavV0RW/DefjuYxbLHSw5dn/i3JXELnciAXCs 1QEgQdHQLxyPFP1T9MbQkKDk5hi3fZmqe7ZdYOWT0vbaf+VWi+sJ52HeUMlSh7Djo3gW NXpFZJWW2wEhDIDMHZbnmenyTZYRkxPQ4aBhJPR+/Rwt//eHIfZOKRndcsEQ2WEL96Je xZzg== X-Gm-Message-State: AOAM5338uTN388mzDqAUXJ4EvdkteFyKvtQ1umzB+ihXiUuuqKFO359+ RCNNUulFkPQ6qe2ZbEClQF2k39dERX3+oqvZmhmGL3xVzaeQT7NVPaNp6ESMPyV7Y9O1ap82fdj FUhUF5MWw1Eg= X-Received: by 2002:a7b:ca45:: with SMTP id m5mr303849wml.104.1632764044564; Mon, 27 Sep 2021 10:34:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxFQPFgP0cvYwAaKpVOANDrVGsVbbDWtlyDelOIxzvbsD6mtpCVJttOjDtlebYZSOAscAoqQ== X-Received: by 2002:a7b:ca45:: with SMTP id m5mr303828wml.104.1632764044352; Mon, 27 Sep 2021 10:34:04 -0700 (PDT) Received: from [192.168.3.132] (p5b0c654d.dip0.t-ipconnect.de. [91.12.101.77]) by smtp.gmail.com with ESMTPSA id r6sm547676wrp.41.2021.09.27.10.34.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 10:34:03 -0700 (PDT) To: Georgi Djakov , Chris Goldsworthy , Catalin Marinas , Will Deacon , Andrew Morton Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sudarshan Rajagopalan References: <595d09279824faf1f54961cef52b745609b05d97.1632437225.git.quic_cgoldswo@quicinc.com> <4f4f6e93-ddc2-c9bb-ef47-4a40f2c3d0d7@quicinc.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [RFC] arm64: mm: update max_pfn after memory hotplug Message-ID: <1b9c4377-0a6b-b7d4-7a6b-a69f9469bb70@redhat.com> Date: Mon, 27 Sep 2021 19:34:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <4f4f6e93-ddc2-c9bb-ef47-4a40f2c3d0d7@quicinc.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7AA4E20019D3 X-Stat-Signature: s586w7cp3by6igdfsygmkxejp3w4x64p Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="DdOvoJa/"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf26.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1632764047-453059 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.09.21 19:22, Georgi Djakov wrote: > On 9/24/2021 1:54 AM, Chris Goldsworthy wrote: >> From: Sudarshan Rajagopalan >> >> After new memory blocks have been hotplugged, max_pfn and max_low_pfn >> needs updating to reflect on new PFNs being hot added to system. >> >> Signed-off-by: Sudarshan Rajagopalan >> Signed-off-by: Chris Goldsworthy >=20 > Thanks for the patch, Chris! >=20 > With this patch, the data in /proc/kpageflags appears to be correct and > memory tools like procrank work again on arm64 platforms. >=20 > Tested-by: Georgi Djakov >=20 > Maybe we should add fixes tag, as it has been broken since the followin= g > commit: > Fixes: abec749facff ("fs/proc/page.c: allow inspection of last section > and fix end detection") Are you sure that that commit broke it? I recall that we would naturally run into the limit, because count =3D min_t(size_t, count, (max_pfn * KPMSIZE) - src); wouldn't really do what you would expect either. But you could=20 force-read beyond max_pfn, yes, because the count computation was just=20 weird. I think the real issue is not properly adjusting max_pfn in the first=20 place when we introduced memoruy hotplug on arm64. --=20 Thanks, David / dhildenb