From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44D55D2126D for ; Thu, 17 Oct 2024 10:01:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD9826B0089; Thu, 17 Oct 2024 06:01:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C61C36B0098; Thu, 17 Oct 2024 06:01:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADC226B0099; Thu, 17 Oct 2024 06:01:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8C6186B0089 for ; Thu, 17 Oct 2024 06:01:07 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 418B01211FF for ; Thu, 17 Oct 2024 10:00:57 +0000 (UTC) X-FDA: 82682650638.06.EB19E35 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 4B4D780014 for ; Thu, 17 Oct 2024 10:00:46 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S5X/rnV4"; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729159120; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MNXpYWC/snVv/RcQcy4Z6FTQ4rOQoP2EVP5TGZ+dUTk=; b=Z0UqOxzFmcPHRZNv2Rfbn4niKy5Th/F1Oi+c84Q8uhsoUWYD2OYKjYKgINg42XhQpilRGp xAx331+f6XReKk1UgehYzqIc9mt88e76upzExBK9NEy9rCGjtLWVQneUYaO9/IXFL4gAk3 bDsVQEsVuARNjqD8V2h+kmDwpyr4abw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729159120; a=rsa-sha256; cv=none; b=t7kj9XXkntCioMfF4siczjW9P7Y/CS3TTzL+QSG1d0yYVyym/SIDY8xOr0AX79lpEBt7hQ QQbpNb/V+VdVZA2exA1uTfrVSKhs76TnNYv8z27k+JVcYIehddNT5G+I62Dt9DvIEjviBs IeR8qD0EkxjVMqndGYy+iXUkJPZQvRk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S5X/rnV4"; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729159264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MNXpYWC/snVv/RcQcy4Z6FTQ4rOQoP2EVP5TGZ+dUTk=; b=S5X/rnV4bmPFrm4k0MwkkpglkjYvzbswldx0LhYsmZd797+mqmIG2+yIZdS0KFVW7xieEZ m//QGKT07DNslOx6fE11aCpJwoh9WQsaTC6xXz9azpZusskaA036aUTu/JUtkF9hVa7u6M sY23pqLJTbeRXvehialjbGNaDx7gwxc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-tOasE8XeNPW0QRSOYsS1KA-1; Thu, 17 Oct 2024 06:01:02 -0400 X-MC-Unique: tOasE8XeNPW0QRSOYsS1KA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42ac185e26cso6038995e9.3 for ; Thu, 17 Oct 2024 03:01:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729159261; x=1729764061; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MNXpYWC/snVv/RcQcy4Z6FTQ4rOQoP2EVP5TGZ+dUTk=; b=h16abwaciouo5KpuMpmR1lDiQgZdHx3G4lq4f7d9i8OZJbE0Guv2QDDYSXXljJxF1P fFE+93zOIqvlwy2Sl1XfleNRBNK51sJ9oTlf9oHz9+MqjjxYnZm5oRlnf4vEjRVD53Vg Ci9QUHlF9oLc5sWSGnZpkycUusTCVBPovL4ck8u054tDzc1zyfWghVnUlIDkWUQ+Yu1j s8UR/z3rsZcTg0u0Iudd/KTov9ZZHQ5qxUWjprjbUtcz7QtBwVMvLWqTwjsRdTelpro1 S2/yL9+6wiAbk6GfF80sk7XZvrYaMf5QDKe/dLPUxNU0Lx8nIw3pr7sUDsJWwe6Po5td qI8A== X-Forwarded-Encrypted: i=1; AJvYcCWSnI9ZSUwc/TNb/hSJHEDHh12ELUDNi1KMKdpI/hSkacuT0mzmFIXBTwwZ2vEwqzjX03VZOwtBEg==@kvack.org X-Gm-Message-State: AOJu0YzQRK1RsSUhcCrvtoer+KlPMqo7haNzmOImPcK2HUJvWc6HexWA CZ//7nBEVxnpVcXvwaGR8HyKCOGibrj+J8tlEDXmwlzwA6QPsSv1Q41xc8v65Mq4VPsNRIzfDqq HQiifxKrA03JjDNFoi5N2nZDvnkbPcSawfk4o15ER/HSgK5AA X-Received: by 2002:adf:f803:0:b0:37d:43f1:57fc with SMTP id ffacd0b85a97d-37d86d84f81mr3888599f8f.58.1729159260968; Thu, 17 Oct 2024 03:01:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEeAsN2x2tkKcYuYJ2ZGm7ZZUGgpQNN57Jt9VpZjjuVf5PjflWwSWuvgSY7iIq2nRYvpheTJQ== X-Received: by 2002:adf:f803:0:b0:37d:43f1:57fc with SMTP id ffacd0b85a97d-37d86d84f81mr3888571f8f.58.1729159260463; Thu, 17 Oct 2024 03:01:00 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:7600:62cc:24c1:9dbe:a2f5? (p200300cbc705760062cc24c19dbea2f5.dip0.t-ipconnect.de. [2003:cb:c705:7600:62cc:24c1:9dbe:a2f5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d7fa7a2a8sm6734586f8f.3.2024.10.17.03.00.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 03:01:00 -0700 (PDT) Message-ID: <1c7ef09e-9ba2-488e-a249-4db3f65e077d@redhat.com> Date: Thu, 17 Oct 2024 12:00:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] s390/physmem_info: query diag500(STORAGE LIMIT) to support QEMU/KVM memory devices To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Andrew Morton , Jonathan Corbet , Mario Casquero References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-5-david@redhat.com> <04d5169f-3289-4aac-abca-90b20ad4e9c9@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4B4D780014 X-Stat-Signature: xr98p65y8h1jj5gz4pcio55yem13161z X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729159246-394567 X-HE-Meta: U2FsdGVkX197Hp2ZVkQ66lUYm05bqAZW8sCyEhh1+UKQWw84+oIoyIAqYxJG+y2Mbx1A1DCi3G9coTbjZFXhPTboVJXwLvLvOn+hCYoCibT+zT7W0WkcZRBbTSmSq6tX1lR146CqHDTyO9FwezyhVroYVLyKrRZy1onuFq6PjrMZlNlDshffbfw/9JCger7s/1l+4RkL8wMpr0gBW1sp3iq6MebV8fdsLvxLUM4lX/z4s1TOHzdFEgcg518wy4u66U46z3j7kE1F4/ULNFZFW+cs+Co4rVsBmmxXMT/W+q/U1Q733uZwxox2dQCsmLiMh49v464T24g3XdhSyElPCtJo4qLKGEedZPWw6tKSGCAw0rjJB8LMT65W4K0w6IDsfldLPjAD4+aFhgBpprQ7xLTpXFAZ5jrsa9a/5RQjQDtDqtHZQzN0SGkgd1W215lfk3AWf7JhHfikPVVByGhvRr1nV2Ka8O07Akz5MCmmufT6TuUEZlBZq1pZErHTaZrQvg9q1/cdkVK0JthJ6Wgy+DryNNlkkym0F4JFmlJ1oS5wcqvGeNp115tPHx+x6N0K8f842sqXXSG8bkf3jDxxkX8X1cFImghoxKVDztv1kyWvkKzo8XnpQTnsMle7VdheBNB2s8LZT/70bcj1yT1WbPYZK974wIXdBBFHq1Y6YQLnZNxFZJcepcCGHi3/EwhPBvoREv8dPRFgymwFBhphSD59HWDtTrH2APNXsX24xZmx3z76kuBzldqtOduZF+RAVavNoYczNZ+BwpnG0W0BgBN606HQ0dkZTyg9axMDwHOwYI5uv++nodXarZv1AWewkoP8LpehjX/Clh79BZqJafTtb4zVcSY2AnfloLl0nnpPl7gtxvf6Pki6eCUGUQqOWVq1ZdJ5sFtB6He/LcJx5T3JvTcV1qTpWjBa3Nd+kebPUtu6Y7TOKsjF9fAuh7q8B9fvgFZuAa0JRzQcoVX /Y1NnknP vFQBcX+JfZ/kA70wtMZdST/E97GcDGfq/QnPAVEHifIek+robsUw3lrNrtBeZ2KMgQrhIDnQm7DGyNUk5BAmXylel0VK7YlwmiBQjrhYqEj5c8S7fk3PVX3fcc8apC1QBzMHgNAmwDhJp3nk2BWgaSpAUSWVAlc3gbpmdUyIXx5/F4kHcz3jOQZiqc0tS8zLgJCGysDzaiGHTznRTHwqUzUjRLOlMWV1pa9UqJrMEqAQGwwbOt+DTmIQopAOQPkOFyBaDliaRkJw5Vhw/iFENweZhl/rmI0iPdsgBax/sxNHM8PH5pjw+wRq2oMqLJrilSa6k4whZ57r2d9+kqrnhlKh+vYwb1ap0yOE6sQ9SvH4BYxfmXSPiKqVHtc3S1LpRySJZyAKPwHP34jKadKhV0djzy9CW/M+N0m3dFKl1xD7d22g98m4KWSuO/8MQSQWaGory X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.10.24 11:53, Alexander Gordeev wrote: >>> Why search_mem_end() is not tried in case sclp_early_get_memsize() failed? >> >> Patch #3 documents that: >> >> + The storage limit does not indicate currently usable storage, it may >> + include holes, standby storage and areas reserved for other means, such >> + as memory hotplug or virtio-mem devices. Other interfaces for detecting >> + actually usable storage, such as SCLP, must be used in conjunction with >> + this subfunction. > > Yes, I read this and that exactly what causes my confusion. In this wording it > sounds like SCLP *or* other methods are fine to use. But then you use SCLP or > DIAGNOSE 260, but not memory scanning. So I am still confused ;) Well, DIAGNOSE 260 is z/VM only and DIAG 500 is KVM only. So there are currently not really any other reasonable ways besides SCLP. > >> If SCLP would fail, something would be seriously wrong and we should just crash >> instead of trying to fallback to the legacy way of scanning. > > But what is wrong with the legacy way of scanning? Missing to detect holes and starting to use them, detecting and using device memory without negotiating with the device ... it all falls to pieces. > >>>> + case MEM_DETECT_DIAG500_STOR_LIMIT: >>>> + return "diag500 storage limit"; >>> >>> AFAIU you want to always override MEM_DETECT_DIAG500_STOR_LIMIT method >>> with an online memory detection method. In that case this code is dead. >> >> Not in the above case, pathological case above where something went wrong >> during sclp_early_get_memsize(). In that scenario, die_oom() would indicate >> that there are no memory ranges but that "diag500 storage limit" worked. >> >> Does that make sense? > > Yes, I get your approach. Thanks, please let me know if I should make it clearer in the description, of if you think we can improve the code. -- Cheers, David / dhildenb