From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA15EC54E58 for ; Thu, 21 Mar 2024 01:47:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D8B26B0083; Wed, 20 Mar 2024 21:47:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 289346B0085; Wed, 20 Mar 2024 21:47:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 151646B0087; Wed, 20 Mar 2024 21:47:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0272F6B0083 for ; Wed, 20 Mar 2024 21:47:33 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BCDEE14036B for ; Thu, 21 Mar 2024 01:47:33 +0000 (UTC) X-FDA: 81919359186.10.436845E Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf28.hostedemail.com (Postfix) with ESMTP id D43F9C000A for ; Thu, 21 Mar 2024 01:47:31 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RUubZDzW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710985651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uwwXtXCvbSQVnkT5BGfOsi+2LxDqXEltVUJKwHfmTtQ=; b=QMfm/ShZjQIXYKk4ztO8IJ621z4XImwy2B0cM/y1LtTl8ntv7eiAevOAi6v86mL3CEBfeN poXlBWc+f1wRkzN7QgoKdLTS2vcGHTt63ulcmQXrVjRf43tSgCuYN7An9DIyyMb9FZEJe9 a2sheXTurb+ambUAMu1iWZrR6j6NixE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RUubZDzW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710985651; a=rsa-sha256; cv=none; b=Me26XNmDpOPIJwcG6HGiWEz8DtNsiUTf5PRQxeffXurEouGRmJglta3xIOt4bTzNRoA7Wp 5kuvxqWux/6HV2aP3LouuFxcSmcQg3UuI6lKdLhg5yNp7QkMiiy/VEcF7GrgqaRdCXJ/JY LpJlQKW/s0JLP6Bx2dPZYtLqmPgqMz8= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1de0f92e649so3111755ad.0 for ; Wed, 20 Mar 2024 18:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710985651; x=1711590451; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uwwXtXCvbSQVnkT5BGfOsi+2LxDqXEltVUJKwHfmTtQ=; b=RUubZDzW/LXH/jhnM7qhZqZUhWL2/ImltTHXKyxfTomo7fuklIfZybp18KNxXn7N1L N8V0uZ9hJKlPI0sGPyH3zZ0r6BzXQB85Ho8laCcA/xxhiiaDKYdW0RCmlPCQBMV/X7Um tKGCOS8WR/fnnvgf7gNIQEUmGrWvtmdMEw8edPmUpMWxVKP44BqIZ5ONI6eet6VrmLlL jw2e5xZPo02fRqWPJEOGNzWJ7FlAZ8IwAd+skpZzg7FR0B28mofV8TyfsWum/lmwfCLD kYaRkRJ4w5DwIRRPcpoRP2WkmAfoIn0XcbkrkbsUvuFfIQCitpR6O62NHRMmMT/OizUG j1aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710985651; x=1711590451; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uwwXtXCvbSQVnkT5BGfOsi+2LxDqXEltVUJKwHfmTtQ=; b=j6O/vja7zfYTQshlD+GPadqEgm3DpHYN1MPFutC5FFWYmY39Gp4j487lJAuRXW0v9V DhmJCPwl4Rj8wHvmhCsIZeT+knef0K3v344YARYLBJHQol3mPV9Do23cKQ72HF0O/g2v /5BU5ExWBJDKMORvLjUZXc2Y1IUwiJ6vCharYSDfWvNcVZoj9Pga11lZE7BKnfVBZvbZ IB99MzvNXnlDmqAgt95KuVtweaA45msTmplApfl+ZhSFoaqiY17MBXaDiuqnCtduNo+N yPcii+WetnWjC+k0jHxUaAY7v3DEqZshYlCyfdTArLz57yeuUYWUpuLIoOskfdeyJPjx aTfQ== X-Forwarded-Encrypted: i=1; AJvYcCUsxSw6wULsb4B/3xmo7EM22hVTFiP6TX3jKWpcJUiIKVa3IzBH7SYefm6iblJZ9rRllzt+UIRkOs35rC7pHi3hR6g= X-Gm-Message-State: AOJu0Yz6UJEpYKLu3MJxGAiSmaWMyUkQlo0fkl+6cSilZcRmSMWmi/oe DmhyJnCMijDVqt+PXVy+SL43LuJ8RX1ThHZ0JiVQg1KPYmEA77bx X-Google-Smtp-Source: AGHT+IETbDCXSfnyDw4E7ZxgsR0AeuF9hqGIzboQZu3z4KQzKauZvY+l6Tsh2CopSifk1TuSpOFVUA== X-Received: by 2002:a17:903:1cc:b0:1de:f569:cf41 with SMTP id e12-20020a17090301cc00b001def569cf41mr21259195plh.26.1710985650634; Wed, 20 Mar 2024 18:47:30 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.25]) by smtp.gmail.com with ESMTPSA id z5-20020a170903018500b001ddc83fda95sm6121927plg.186.2024.03.20.18.47.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Mar 2024 18:47:30 -0700 (PDT) Message-ID: <1c8e6fbc-ef1b-49fb-9d3e-b163a58cee10@gmail.com> Date: Thu, 21 Mar 2024 09:47:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/11] mm/ksm: Convert stable_tree_search to use folio Content-Language: en-US To: Matthew Wilcox , alexs@kernel.org Cc: Izik Eidus , Andrea Arcangeli , Hugh Dickins , Chris Wright , kasong@tencent.com, Andrew Morton , "open list:MEMORY MANAGEMENT" , open list References: <20240320074049.4130552-1-alexs@kernel.org> <20240320074049.4130552-10-alexs@kernel.org> From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 1898jzpe7t5ikixutiid7946i3j3t7fk X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D43F9C000A X-HE-Tag: 1710985651-174788 X-HE-Meta: U2FsdGVkX19Yr4ccE/NgsIl1G+mE8bM1LyEuMFKP/mlQLMxb8D+B34FEb1MRdsB3t1BELHIilzIpLhl7RZby5Ilcl+kh31X2TJxa8twUylmhXpI7icWVUZXa4HIeLftarSLQi91qnWyjE+k0DkeyljlcwjFJKTV+9gvN5q+NqkZoTW3jJqyXZApqQvEXOsetTloLFHtNI+MvMdBTAyETtuP6YabnFpHLv160uAFB0ZbI/8dpYK+sg46OUAHKv99t1/Nc0gI42nNTgGI2LcaYCcc2mDTW9WSJBFFD0oiLb4Jk/8I/kJeGx4Z4jIhvSBI/+495dqIejAJubXAx4FiobP6iB3BijkkSxeQphBA06JNihxx9JH4tQv/rN8ymtBOh35jFgYXw/3ccVjdXceoG2Zd0SJ4TjBm2n0678Fs70Fnpy673eWWt7DPOBghwlMuU+ZPR9O1+JjblTPr0L7pRCRLfkfY9yawFYhCbvcGlzCuetF4jwuUQzCjeRXXe4woAdPQOd1CXg5qdeBO/yfHIP/RliIaId4D0cetlekUFBsW6KhNy1egq9NzPsppO9sg3CntEcIGV9xPQLNk4bAmueqegn2h3h3CP+p/PzZJqw43VVDplwhorcNwL2jCKfW3qf1D1nmk6nOpnLWWqJh37eA893X34DD7iWNaAlNjXAuCQmHVB8bGAS0Nl6sExAuKTkwRN+s3E2l8kPB5UbVhxZLApoSDz3JhsMJaZ5obrrMqxMraSd7LUybd2ex9FY55LPrdYMioOejTzS17Zhwe415z+LkCvnytJg3XsaKIN5VPNUig71M1/R6N/k+w2DPgfN9SuusD8CuSDtTXnP3rFwQlq2i9tMzH46VhOSYLuPEtlRhoFdpDA53tldC+FRamgl0PcvgM/R1Ye7DNUYvDkgQ62SS3QRSm8jBPGTQeaog/t88GAyamx/eLmsIapkvlQba7dmLEEu1GfkuInEN9 hxRvEMrM VKdkQtsnDENrWrZC428V8QUUMeLnpsl6F6MLi64bOA8+adynshEFsj9eJACVX7lxm49ZOVrdS90SLM3l5f081A3uJXVFnJh05E79RoHM9Gt5tlnoLZsYK3d8gWh9Ky5cBZcpQMvp7vOUHHxRTZVDO87E5ImsdnFZtEZnIBYZ8Eh9MNHE/XuXRJr3Ud+KcxUQKR0NKvOve2RL7LGioG/v3DC22lTrb+bVGcKuA/WXwxM8FWfnoQDI9LYYmXvM/HM32lFoDmX21NBThCG4kZDh2Z0iJQlj2keQTEqMh2xR8yUaHKxwfI1bFCYOQt8DBGWphp9lPJ5oe4xRPh3kXq9qR4fq6w6I76cUQ3WaIpOATsKdmC+W5mqGZ/cEnPQfVilbERB9PkL59t9c3MIhUxATnnigKjUKoFf/BSoVuRcdfpbb80u66camJsbMLxwCBkYMhQeG2ZnKGPoqEdnTL37zh2SAcMcbb+wZ6I3pCwcA38o21VY5W0WBMvgA+c455znpeF5StpSw0bsv9OeM6sJ1FO2Lz025SHmgaK8lq12uz3PfI4LH4iRDsBWIgNkU2X+JZr7qA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/20/24 11:26 PM, Matthew Wilcox wrote: > On Wed, Mar 20, 2024 at 03:40:45PM +0800, alexs@kernel.org wrote: >> @@ -1820,28 +1820,30 @@ static struct page *stable_tree_search(struct page *page) >> struct rb_node *parent; >> struct ksm_stable_node *stable_node, *stable_node_dup, *stable_node_any; >> struct ksm_stable_node *page_node; >> + struct folio *folio; >> >> - page_node = page_stable_node(page); >> + folio = (struct folio *)page; > > These casts make me nervous. Remember that we're heading towards a > future where struct page and struct folio don't point to the same > memory, and part of that will be finding all these casts and removing > them. Please, unless there's a good reason, just use page_folio(). > Hi willy, Thanks a lot for all comments. Yes，all of them are very right. I will rewrite and send the patchset. Best Regards! Alex