From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC48E81DED for ; Fri, 6 Oct 2023 12:33:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC8AA8E0019; Fri, 6 Oct 2023 08:33:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C780B8E000B; Fri, 6 Oct 2023 08:33:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B402D8E0019; Fri, 6 Oct 2023 08:33:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A72E48E000B for ; Fri, 6 Oct 2023 08:33:51 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 711F9C06E0 for ; Fri, 6 Oct 2023 12:33:51 +0000 (UTC) X-FDA: 81314978262.15.AAF420A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id C364C160012 for ; Fri, 6 Oct 2023 12:33:48 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HgoGF5E0; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696595628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kp2picVzpjCiZ5thzoNnS4NIffKCsvdoirWsfiXrjmU=; b=Zmwzjil7/qj9v/UjIzpJ4dj2sinIKL1NyPVsYlu3PvQJCNoQK2cuUXG1JXHV2+ZKAHZGi0 /6uNB3Rp1a2bka5J02xlFGnGiSN8TJKFofUSA01uxuqmjX5y5m6GCkVyhV/0kYiLO571dj m+bHrJbwKemNt28lIs+Rt8MNEbO2QcY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696595628; a=rsa-sha256; cv=none; b=hB0Ioc343Dzo1O06Jlq8ZXgzScd0xmeJuhOM87iS6Pglm0xWzFIsK5CrWIZowiyXgT7YNN vOvQ/QbhzBLLRMd9iEpxhiFmWcfTZmNxz73ULMqW/a9tJoXdmJ6WzMI2X9jzNIRbkO5Vx8 NeUs6V+V9lO6/YSJLMy5HtvB1h0IjLc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HgoGF5E0; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696595628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kp2picVzpjCiZ5thzoNnS4NIffKCsvdoirWsfiXrjmU=; b=HgoGF5E0EROBMo3P9BpKEIJYxLHWveBimoNcl5r7N4VjkdSd37cP49cAeHZM0gYUfdUY2R 0fyWD3i4o8sArVT+bMYY0tdbr2JVzKiFg+F6jypORh4WNa0HbcupnI8aUN7jLnfA4PJJ94 7Go9lsUSs0YYm4xIxErIBS2v9sxendk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-ioDVNHf8NaKVYOTfzEBMqw-1; Fri, 06 Oct 2023 08:33:30 -0400 X-MC-Unique: ioDVNHf8NaKVYOTfzEBMqw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4068bf75d0dso14601915e9.3 for ; Fri, 06 Oct 2023 05:33:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696595609; x=1697200409; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kp2picVzpjCiZ5thzoNnS4NIffKCsvdoirWsfiXrjmU=; b=GWwVnLfMOhQqAkOxExXWxW/DIVEwaxvRB9lSD5fIQDUZ9k4I39oUEqAHFbI0AUZRwS g69MWMEJISoX/JUCEZcBZGzgnnz6fnqFbFvwTKSY38lDXh27AlTE03RiDZHoLzOoRFgM 400pTt6rhwIa93qYQAit681hZ2NzuHvWFK4k3o1Wohk2WMpJRoRdLQrxPdGBw6kaRW8t 3iDfbcRP4s0g8OejQpR3KkZokrjBL3ZjBCVuzKrrpyBXDw1+NCaOvN0YhjON7eaZafrJ qvJNsLuvel8Llv4XZj2r5uKJSrXayxmLY72dBTCKxrBLAXuD1Q9UlXOrUskS/dTJCY6F cPrw== X-Gm-Message-State: AOJu0Yy9JYL7s2LXw8SblwTww2egz89IAFOfNkPcFUUukiAOaSjz+8Ug 8UBhRjDl/c2qcJZhVcJT9e4Ev1ITO16hoIbZQOV41eO2F+e5V95HKDvg4rgwE0IsmW6HAMzhyX0 gEV0cU8T6X3EcbwWviR0= X-Received: by 2002:a7b:c84d:0:b0:3fa:934c:8356 with SMTP id c13-20020a7bc84d000000b003fa934c8356mr7567177wml.10.1696595609208; Fri, 06 Oct 2023 05:33:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+qbujoqL35rM+01e93eyEax/eUnX6DN6O6MIW9k5Yq00U138jBSP0b8qR2JxHr3nONKt2Og== X-Received: by 2002:a7b:c84d:0:b0:3fa:934c:8356 with SMTP id c13-20020a7bc84d000000b003fa934c8356mr7567153wml.10.1696595608689; Fri, 06 Oct 2023 05:33:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c715:ee00:4e24:cf8e:3de0:8819? (p200300cbc715ee004e24cf8e3de08819.dip0.t-ipconnect.de. [2003:cb:c715:ee00:4e24:cf8e:3de0:8819]) by smtp.gmail.com with ESMTPSA id y4-20020a05600c364400b0040472ad9a3dsm3666144wmq.14.2023.10.06.05.33.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 05:33:28 -0700 (PDT) Message-ID: <1d606139-9fff-a00e-c09b-587a8b6736f2@redhat.com> Date: Fri, 6 Oct 2023 14:33:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4 1/2] mm/memory_hotplug: split memmap_on_memory requests across memblocks To: "Verma, Vishal L" , "Williams, Dan J" , "Jiang, Dave" , "osalvador@suse.de" , "akpm@linux-foundation.org" Cc: "dave.hansen@linux.intel.com" , "Huang, Ying" , "linux-mm@kvack.org" , "aneesh.kumar@linux.ibm.com" , "linux-kernel@vger.kernel.org" , "linux-cxl@vger.kernel.org" , "Hocko, Michal" , "nvdimm@lists.linux.dev" , "jmoyer@redhat.com" , "Jonathan.Cameron@Huawei.com" References: <20230928-vv-kmem_memmap-v4-0-6ff73fec519a@intel.com> <20230928-vv-kmem_memmap-v4-1-6ff73fec519a@intel.com> <7893b6a37a429e2f06f2b65009f044208f904b32.camel@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <7893b6a37a429e2f06f2b65009f044208f904b32.camel@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C364C160012 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 5fgm7zirebjp168knirr98i5pos39fin X-HE-Tag: 1696595628-748245 X-HE-Meta: U2FsdGVkX19dV5Ef+11phAlUjm0WW8u+1F/jR6/Q5+bOFFXSnWALsZ8MF/rZ+wupkPlz7P46l3Yqn7CUrwNYMh4SKzNM4KZ0sGyu/b1h3ZFsnHv7fLbywFDPGTaNS3DPR9YTLBIW04m6clbGcAe9f9gQh0FjxqjqTX6wg7AA6b4FM8ej5wMztaRFEoL8u3pbLlOpbHAf44DLtBo3R7cwUong6ghVdcUR79qZ5RNXYw3dU8sjlwpXuZ7yFge1pRYeZRVKSUe/XVaCOcIlCRUyOL0WM1eJe1Ds8OeDwm4DqpTsiSKqFkqgcegV2emKfa6I+YiqvTmDLYkLqcqnro9S0GG4y5sc2mT0ajhpYXFEKV3wuDheHxFH0jFK1Gdq9uQfk9BOjweGgOBT6fu3P2LGyiPtakU18wb4o4ndxZva+BpFjQOINfa45B6zTemvXBT6/pMdrxWBBGKwTpon0KdaFs42N3qxndKTWBIK6JHM4wqguGD7yP12rx0YphqKaecXlm9sKcldEaxMOi7gHX5PSQRJSr1a0/UH7cVk574VqK83tkghJ1wy+3j3rnMoCqGTWOXbaE5AmbROSbRI6Mc2qvA5t64j5kKhLpqJc6IBikKfuWQx8GC/vrxsLzFkpXB50F4BW4TkMpEuBAj7UzssFY0NsdvUV8tC9gO2IVuoe7IPfm7Vvpjx+pQYXZmaZs3PgMqsJWgz0O6dKp45cS8/rYWN+dTykZVco3pOnDomHoMBCnPm5gv9Ypd/KAB6wraZ0itVMdbzLRql7iQNskL8xncSYsrYGCD71ddKVmR/uzQpcTza6UKq6BynjtGOYVUt5XlAwCCXKIdoe7YRRO2E+/TqyT8NURJY3lUkDUkjdSnqB3U9VQeKQvKHuiiquGcnqdTXEK2yXMYEPRbCR7VAN+kPyGM9BdSUtyHl6gf7rtT05UQ3IrYPUhH5hNL8IHi2iuS3758blNqqdxXdGR8 PRFgeCVE ANBchZnyiFEZ7eWvLejr45PsBFeCsJWl3d6pTiMr2fTyNws+onXUnzFnSrjgLR+OuWHwDiEeoAwYROoBn5fG/EjtdUWEQCGfSN8xyuMO+1Zb9qu/37z/gxEWJR10/8kf3EZxPnLRpKH9exTRHi5mQHVY93fBLzVq81M0qvp1I2KHzNVkFHDtNhGmEnkWF5cPlgRE/gdIymH3tsD/c9o1MGGfsx7lQ7utUdAcr6q/qY5i8Va/LGtGtYrzNleQP4RoyqJsDpyjAGEFo8DRRaHVitACY534IfdHY0KsUIYamX3iQRjKBdCneIkPmVwLfi/Pd7lKRrYtga7d4wqn692XKjr0eciCC1cSvSv+DEAa2eg2zy5aqu4ch1PvZ6PesALIZco1DWQ5a3ZlacvQRqRakenBjqi3tydadq7n5Oh57/Zed4ig0v5SuDxc+36QV2721yrQHDVwQ/zu82/Ww2ghyChZZrg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.10.23 22:03, Verma, Vishal L wrote: > On Mon, 2023-10-02 at 11:28 +0200, David Hildenbrand wrote: >> >>> + >>> +static int __ref try_remove_memory(u64 start, u64 size) >>> +{ >>> +       int rc, nid = NUMA_NO_NODE; >>> + >>> +       BUG_ON(check_hotplug_memory_range(start, size)); >>> + >>> +       /* >>> +        * All memory blocks must be offlined before removing memory.  Check >>> +        * whether all memory blocks in question are offline and return error >>> +        * if this is not the case. >>> +        * >>> +        * While at it, determine the nid. Note that if we'd have mixed nodes, >>> +        * we'd only try to offline the last determined one -- which is good >>> +        * enough for the cases we care about. >>> +        */ >>> +       rc = walk_memory_blocks(start, size, &nid, check_memblock_offlined_cb); >>> +       if (rc) >>> +               return rc; >>> + >>> +       /* >>> +        * For memmap_on_memory, the altmaps could have been added on >>> +        * a per-memblock basis. Loop through the entire range if so, >>> +        * and remove each memblock and its altmap. >>> +        */ >>> +       if (mhp_memmap_on_memory()) { >>> +               unsigned long memblock_size = memory_block_size_bytes(); >>> +               u64 cur_start; >>> + >>> +               for (cur_start = start; cur_start < start + size; >>> +                    cur_start += memblock_size) >>> +                       __try_remove_memory(nid, cur_start, memblock_size); >>> +       } else { >>> +               __try_remove_memory(nid, start, size); >>> +       } >>> + >>>         return 0; >>>   } >> >> Why is the firmware, memblock and nid handling not kept in this outer >> function? >> >> We really shouldn't be doing per memory block what needs to be done per >> memblock: remove_memory_block_devices() and arch_remove_memory(). > > > Ah yes makes sense since we only do create_memory_block_devices() and > arch_add_memory() in the per memory block inner loop during addition. > > How should the locking work in this case though? Sorry, I had to process a family NMI the last couple of days. > > The original code holds the mem_hotplug_begin() lock over > arch_remove_memory() and all of the nid and memblock stuff. Should I > just hold the lock and release it in the inner loop for each memory > block, and then also acquire and release it separately for the memblock > and nid stuff in the outer function? I think we have to hold it over the whole operation. I saw that you sent a v5, I'll comment there. -- Cheers, David / dhildenb