From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75D29C49361 for ; Wed, 16 Jun 2021 18:53:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EB4E6613BD for ; Wed, 16 Jun 2021 18:53:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB4E6613BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 559406B0036; Wed, 16 Jun 2021 14:53:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52FF46B006C; Wed, 16 Jun 2021 14:53:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F79E6B0070; Wed, 16 Jun 2021 14:53:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 0C6136B0036 for ; Wed, 16 Jun 2021 14:53:00 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 937CD8778 for ; Wed, 16 Jun 2021 18:53:00 +0000 (UTC) X-FDA: 78260484120.35.2DC1FFA Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf12.hostedemail.com (Postfix) with ESMTP id 240CF371 for ; Wed, 16 Jun 2021 18:52:46 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id E38DA613B4; Wed, 16 Jun 2021 18:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623869579; bh=Yqry3gXTN7L5llHGJ5LYioszkeOqgnImNugNlvlJamM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ZdUJ7KXNhkuKNAUX1x7Dbc4PeUFd1RBBDmKso0XmPrKjdsmddGAwUrigYr/JM82Wg QZYY1HboE2uqd3aDHbef4mKiID3gsuvm5EVze2dABZvbyZheNWkpSQusDL9vvTKeTZ llgpyzsvBgZGHBlVCUTvm9DEzi6Hvbi5dJZInB6zEXy5rjMxcXqZdGesyqHMQpTlGH 9vnvX5X6f8YAkbV0xff+6rjr3kuqkpugsrxF/ZBh7JF/BjFyZohG2TevhZq78dCe75 ZbfCX4ngCfJiMjfS5mqXkORZczgWyrHbvJC4IDDJol6JXrj9FBaLWKtCUNktRtFrtB Ewqj3p90Zv/OQ== Subject: Re: [PATCH 8/8] membarrier: Rewrite sync_core_before_usermode() and improve documentation To: Nicholas Piggin , x86@kernel.org Cc: Andrew Morton , Benjamin Herrenschmidt , Catalin Marinas , Dave Hansen , linux-arm-kernel@lists.infradead.org, LKML , linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Mathieu Desnoyers , Michael Ellerman , Paul Mackerras , Peter Zijlstra , stable@vger.kernel.org, Will Deacon References: <07a8b963002cb955b7516e61bad19514a3acaa82.1623813516.git.luto@kernel.org> <1623818343.eko1v01gvr.astroid@bobo.none> From: Andy Lutomirski Message-ID: <1e248763-9372-6e4e-5dea-cda999000aeb@kernel.org> Date: Wed, 16 Jun 2021 11:52:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1623818343.eko1v01gvr.astroid@bobo.none> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZdUJ7KXN; spf=pass (imf12.hostedemail.com: domain of luto@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=luto@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: foiex3uj7shgj4gw67tt4xknpef5pd3k X-Rspamd-Queue-Id: 240CF371 X-Rspamd-Server: rspam06 X-HE-Tag: 1623869566-924963 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/15/21 9:45 PM, Nicholas Piggin wrote: > Excerpts from Andy Lutomirski's message of June 16, 2021 1:21 pm: >> The old sync_core_before_usermode() comments suggested that a non-icache-syncing >> return-to-usermode instruction is x86-specific and that all other >> architectures automatically notice cross-modified code on return to >> userspace. >> +/* >> + * XXX: can a powerpc person put an appropriate comment here? >> + */ >> +static inline void membarrier_sync_core_before_usermode(void) >> +{ >> +} >> + >> +#endif /* _ASM_POWERPC_SYNC_CORE_H */ > > powerpc's can just go in asm/membarrier.h $ ls arch/powerpc/include/asm/membarrier.h ls: cannot access 'arch/powerpc/include/asm/membarrier.h': No such file or directory > > /* > * The RFI family of instructions are context synchronising, and > * that is how we return to userspace, so nothing is required here. > */ Thanks!