From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEC31C54F51 for ; Wed, 29 Jul 2026 14:33:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57F886B00FB; Wed, 29 Jul 2026 10:32:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 556D56B00FD; Wed, 29 Jul 2026 10:32:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F8276B00FE; Wed, 29 Jul 2026 10:32:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1CEA26B00FB for ; Wed, 29 Jul 2026 10:32:58 -0400 (EDT) Received: from smtpin22.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 781351A065E for ; Wed, 29 Jul 2026 09:45:00 +0000 (UTC) X-FDA: 85041330360.22.B453FA6 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf04.hostedemail.com (Postfix) with ESMTP id 9ED374000E for ; Wed, 29 Jul 2026 09:44:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=KecLasxf; spf=pass (imf04.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1785318298; b=MV7yxMDWK3b1Ei88/wBCTxxZrbjm6PmMtjX468u/Hm3L0pLXAXgSbv0RbCIRaDBUyfolSX ueWhsYpcq31i77+klJ8qKWMcyBFTLwTM+oSzPG9UfWMTZdDCrjKJqj/hvoHRsoulTzPhJA 9UxG/F1oeXyUvyAleYEMAj69Uc4Q9Rc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=KecLasxf; spf=pass (imf04.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1785318298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o2Jbn0t4bTPOCnmw0BAUoprtr6tk/QSrIN1zfNVRZUg=; b=KPxXFRXyZBuZdFnHmVqKsmx2Ur+XLk7YvmuKrCzhqwYPtsLyDca9xawRXP6Q6vz3T6r/5i YE5GQCUxp5ef24vr5btPphm48l3rE09hfpCKKRjsxhs1PUYW8wxJNViaFYg67+aCFWlA6k hPhBMkZAz3EMJ85QP5QELbFai8/+cyU= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id CCAEA417EF; Wed, 29 Jul 2026 09:44:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47D7D1F000E9; Wed, 29 Jul 2026 09:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785318297; bh=o2Jbn0t4bTPOCnmw0BAUoprtr6tk/QSrIN1zfNVRZUg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=KecLasxf4+A9rNhq2lWbIxcCV4zw+pYetw7ylrWYXWwR0afC/RJ1Ls+gwFq6ZddgU T2DYYWpwdN3Upj396izMTeiO0u82iHiSOxo9t5v/mz8bm0sjI5TMfQlO34u9GXD8UA tmTIIVsh1iBY8r3gLIWnABrTehlGhtBupHS3a9mgEWHYkFe+J+Z92eCHh22tmL+56T H3jj6R5TPRKn6Yg57aX2KOQFw5EXqiR1v+0RPH2IZgl3AbR2KmjOxf1g19kej+aGwZ dEhgOO/Ps6NgS0J/dpUImWY5gYVwCUy5r0V39MSWtbw0Y5yfaniCRxL3VhVnrxaKF3 9eysW8D6FEEKA== Message-ID: <1e2e464b-07db-4fa2-8e38-2d73a9eaea07@kernel.org> Date: Wed, 29 Jul 2026 11:44:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] mm/khugepaged: fix outdated comments To: Nico Pache , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Usama Arif , Andrew Morton , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jonathan Corbet , Shuah Khan References: <20260715025941.1571316-1-npache@redhat.com> <20260715025941.1571316-5-npache@redhat.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20260715025941.1571316-5-npache@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9ED374000E X-Stat-Signature: bygettdy7td7y3txxe78zkp4mtc3k68i X-Rspam-User: X-HE-Tag: 1785318298-434675 X-HE-Meta: U2FsdGVkX18bnGrPcHLiyIFbnpnfxiLs1E84b+fspV0KzzlUGruWe39eW1aeZD+3LWkTdhhsXDx6B8SGPfAen31F1FCVqmeE+bPAL7BQbX0Cl8pKHQ8TzSUtrIHfNKRgJH6kGZDF+r9W2dn/MI58oX17WxgOdVY0RJ1ihbuWINMGbXGoSdDo/wgTXTL4NJvHwneAm1ntP0qmxZ5L456HqgpBNl1IEckEbAJKa1wydJJuJYyd10z8wDkzAVUPemofX3s5HQl9dTU5K0UnVd3KNZS+kPZvw55noDXHbeWmCzEe3dHvlSzsWdTOdC3MX6xcYyGVrTjOstaDjFMjWrrque0Nz1rgIdG8SsfBKw9G/ZgdD02fs5XZexpnwXb5qgs4+XZkiN/FjzGlxNxejdemXfpytw2E36yPs/AyP9rX12km5v1u5lC+HUNrGXCSmuE5/sVgNvU6xMvLQw6k9mmH3Rv/FfG3XSgnWcV9qs9VKIk6x8jGKOFyzEiI6/U1k3vmJJnJODEy+swy9l9hnhzNnDIFemM/iOOZxeUC9ak12K+Fnh814XuX1nylaf1iffDtK/JixBQoyv9Nn5VOjGjKxZBvj2zWjOnUUgopPCTigxNxSl1LD1Buy3+o+5k6Ne/RVhYjGZHk/Mk5FR5nC7Nzvb1ng6P0bO/KNGLKSpIxbLLHs95xagP2T2GZ4UBpKpXmi81PIB0/rd9gK+d7lEkHgeq4ng8vBRuh1PrcvklHontpJOcyblwVaS1JqeC90PJT6iPFqgORkY1oD+0I2/zD4/qP4m5YxVyfHA2scjkhQkyeIHebxW9EO/IEE9zWocCtja6OTp0M3ijBIYMG96ksO01IVMxMpIqwjaeV9BzTSFo+dV6RO8dJVBSwxzxou/Z5+Jx0ySfI+8/o+04acDpcn1y4KDt3cTZ5R/KLy3OPqllU4PJWGTTZJQ57YD9dYrXhPP1AuI2fxv/y6OGUMCY /aqSGzxu aQFwxCUZVTFVb+FklaGLPVf04qE5VpSTWsx82AXGLbezYpvrn9NkKUb1+gHgYfKH6PjJSSA9ieaKEInXq82ds+vMKBxYIxfAoJOoeTStCs4uB6UoeobfwZqA2j8/15hHNHQwdBc0vY4lRSwgPl8Q5B8qA8Ul5KilQPRJL+JrGjF35o+H5o0MkuIuAyBwa0J4vVvhp26DMMNUEUDRnZsKsj3IS8CQrevN1AD6moQZMG9WRd4zk+OusWbGJBzMsIO/Txc+G Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > * UFFDIO_MOVE is prevented to race as well thanks to the > * mmap_lock. > @@ -1643,7 +1643,8 @@ static enum scan_result collapse_scan_pmd(struct mm_struct *mm, > > /* > * If PMD is the only enabled order, enforce max_ptes_none, otherwise > - * scan all pages to populate the bitmap for mTHP collapse. > + * scan all pages to populate the bitmap for mTHP collapse. The bitmap > + * is then checked again in mthp_collapse() for each attempted order. Why use () here but not in the other cases above? (e.g., collapse_scan_pmd) -- Cheers, David