From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17954C3DA5D for ; Thu, 25 Jul 2024 13:09:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A13D66B0096; Thu, 25 Jul 2024 09:09:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C3976B0098; Thu, 25 Jul 2024 09:09:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83D766B0099; Thu, 25 Jul 2024 09:09:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 66ED06B0096 for ; Thu, 25 Jul 2024 09:09:46 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 07FD0A4FC9 for ; Thu, 25 Jul 2024 13:09:46 +0000 (UTC) X-FDA: 82378307172.15.641E6DB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id A3AC6C002A for ; Thu, 25 Jul 2024 13:09:43 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eflSgiIa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721912982; a=rsa-sha256; cv=none; b=njSN2Zvb/mMj1SsdgD6CwZVVIt2+ZwzTLwRKDm2eQCn3kTfR8p/xaB5ULegldyzRgLafLg jxwE/W6p2M4LDaTWwgkRRytF6YfFnlnpVnm7qDHKe6UzW7sPXihgvjBlneQHLToMGrLO9t nJ3fVoZX5fe46AA/HSkkSFsrgW044TA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eflSgiIa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721912982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TtOL4ge7LeZL6vEgVOWedkEsRl+7qXAM8fQrH4fh/Bc=; b=CV7gdE3zAxulh5hTFljLRrIPF1dzCK4q0VQ7j0e1qYpv8pb4BnHybBtGTrcTcGgTmawuL3 1/pah75ADfC84l0LfOMC73K7zIvRDGDALIzBAHSaEBh55hHDB8MBx8snV9NgVL2EDlz70A WvhmQeaua/oaXrlBSDYQk03lL3amlFU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721912983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TtOL4ge7LeZL6vEgVOWedkEsRl+7qXAM8fQrH4fh/Bc=; b=eflSgiIasX9zf2XYOYrIj8+HCs/FImQORZDEhtohDKGPRjzrv3Ak1lr4z1NqqZAUH3/u0E pY27Ff4Pm6vD/EPvCPsln+3TdwI7p/8G0ZuUGePFgZ+Op4Tp6lBSV+5W46W4MeLQ/yQCSG R5D2jIs/OD1DmDiOfoH/SKM4s2XEOog= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-rlCb3974PjanTx1HSGqH-w-1; Thu, 25 Jul 2024 09:09:41 -0400 X-MC-Unique: rlCb3974PjanTx1HSGqH-w-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3679ab94cdbso552349f8f.3 for ; Thu, 25 Jul 2024 06:09:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721912980; x=1722517780; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=TtOL4ge7LeZL6vEgVOWedkEsRl+7qXAM8fQrH4fh/Bc=; b=ET4WDTQSYdMuiN/N/uhEnWcjHkq9Fo1Y+OIJ0EomjiWMrLjHJ6VIgBGm4dcJFZ+0Q7 JIMCuD/hqF3L5JyCI90WBKoPWVeO+TL3qqhSy78aLP8EvSHiW/lnd8iLxDOIbN/p1Efs GSxMBBnr4uWGoc2Ew+qIy2vJ/+DyYg3Aw+PlhwHLgU95ic6A6L4DIuIs7GTwV+Qv3zBr ihaMG33zwM6qa4spQHWE5mwTz5tZOz30fZoj27VsDRaM8nkEqYb4Aso6u7iU/2K79pD7 52FztLffM1sXc5dsTyPgmWJvh7BBcc+o9LKhBUihEKnqlLjV28nnFSxuivyKBZTQkatf 0X+Q== X-Forwarded-Encrypted: i=1; AJvYcCUJphBffaN4oLKLRb0WcTufe397rWQs61YAaAedptLNcDyU40d2HyrKE8qNEJxbdiFMitTVK9TkTaV5lWJmMiRNZso= X-Gm-Message-State: AOJu0YzcAnH0qqUJrNJ1hUpqno1yr4Y/f015mY8QJfPsRfxktQJ2NrZV 6BOUMZiYnyUKzZMpEBMG5+m9z+UMGY28nYbxIsysD5F1pbjZWTYQbsoZvr6RSThk1QrIGUdtRF0 47IKscpnac0ktHtslQN3JUzih/9fsb1N2ol4FCOpKWyyOF9aK X-Received: by 2002:a05:6000:1188:b0:368:38ea:7178 with SMTP id ffacd0b85a97d-36b3638c4d6mr1870773f8f.16.1721912980629; Thu, 25 Jul 2024 06:09:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8NDa10kpkcToYFbS1tE2a7on0sb7S8z4RiI1z2H9XjU5MrwnKVnco4DUKatDCSByAaPKQtA== X-Received: by 2002:a05:6000:1188:b0:368:38ea:7178 with SMTP id ffacd0b85a97d-36b3638c4d6mr1870751f8f.16.1721912980170; Thu, 25 Jul 2024 06:09:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:2c00:5f6:3120:375a:3e4? (p200300cbc7062c0005f63120375a03e4.dip0.t-ipconnect.de. [2003:cb:c706:2c00:5f6:3120:375a:3e4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42805730d92sm35144785e9.3.2024.07.25.06.09.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jul 2024 06:09:39 -0700 (PDT) Message-ID: <1e635cfd-d461-4e56-95b8-c6ea512f64ca@redhat.com> Date: Thu, 25 Jul 2024 15:09:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] mm: shmem: move shmem_huge_global_enabled() into shmem_allowable_huge_orders() To: Baolin Wang , Ryan Roberts , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, 21cnbao@gmail.com, ziy@nvidia.com, ioworker0@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <16dad33282617ecb90a3f466b35273b10be68d21.1720755678.git.baolin.wang@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: A3AC6C002A X-Rspamd-Server: rspam01 X-Stat-Signature: 1umnsi37akk4gyn3gkmuepp3goq1w48f X-HE-Tag: 1721912983-620333 X-HE-Meta: U2FsdGVkX1/bvrbDzw996FFhrmqregWtkeSPxzhpgpfMgZXxIZXEDrnk0uQwctZQBYccRKpEbEiWsg8HuY11uQhx509T3x7jFocRjJEW3f8D6u1hpCj45lvP3atSucGs3O3GyQMV/K9okrHK9Xb2iriLywucw4zKE1xSf6Zwug92sX7djbcFIZiTYxkgHQODtaa6mcQ2oJEw/qZTsSKXSXzOYT3Fs95J8EjZu4ruqtQXsQeoLSxnpeYNskRaYF+fSUPWVgYRRbgJKrx7CHpk9y8gFho59vSHuz7363JnP8OB8qk0I7LDnyp4WaKGliQFnNMFbvfnrDalJTNNqnLmZE9Jure+bSa12MNZAnOwB6NW0m6xDUr3pbMv3j0H3tI9yfW9We0yJj+Q1lQ2pFzfrY+KEVp4D5je9AkCsMxEZiPtKH5KsKq/f9848cGOojDhSpGf2X+61gvXjGB1S9EVjz2PGDM+nvffTRAuHtQCM4FbKSVCZHqVe61/pWMDFEHj2ogX8CyOoulsaDZInyTLGrYKGdoPUqDn/WA5HW0UkAFGgCYjMOMMvBCOiAJi3j00pjFRqyLzTvBjYIer+3940CBRSGvY40S6my5YLCoDzRO19ppmYdBU5tbFNzLZfvY/0xyQk33kHRTQadbFKH1OoC1eMlYs0+Xit6GMCpcDaQq+aScAkhIbDbP2fXDypEsEc6JLBFkxxbiZV80FqSCyMOvsJR8BFAmY+HBMCMAfbIQI3NwiOASQrjJKU0C8NZ4LW1sJ6P2Xw9gacsxmg8M7Vp7N6c63H5efyhNqwWk+Gl3F9QH1/nzjERVYbZZhgyyBmldmXEyxjvF5GhVDHdAh1rQ4TPfNk2FC5neO2ppot8gENCFaZHTt+Z1gSvTJTlx7fqmQ4tjBIip43y69QoWpHmsGNbWBBOzd6ZnxFJe3GG6XI6HbJGFuDU2k1UhC91AGMiVhbF148LbefOOhTDL wd8sGlRf 3mtJ62jDQb91mu2nDO87ni+Trk1Cdu4eqMSU3Z0IEcfnjxVdkbsGsuEqiwli0Uo1YhnTI1nt2VXpde2GLct8xnEVtkeYQnZVSuavo+X8ixhFdvmCSH1DpUboq/2QjhPJz7uOgYacUSBSJX9H4eBIjqEJJvYQf/2Q+cO8TLD8p3wIxRhbFkyHQwIJirxZYG42/ltgmtZuFQaw12+x4HJcOfXKUeOHyY1D/+aqOZNHtV1HFCR5cljLmc5XeWZu4dZrG/7fxzwb2YtWCRP211Z65A9zRs3X3uGTu0AXNM0Lk2tyYnrLcRZjj5tu/8lp7PBCU5EO+bDuQjGlRn3pEg/AsUA6paZZx+D2IM1AcaFNasMgBPQ37HDEIKr5auwCOGCGmqWTzc/73KrHO23UV1/VtxMvcB2Ze4xgx0kWTMiu2LlWdvdmaaE7LrflX2GGEFcl+IyKc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>> /* >>> @@ -1625,27 +1632,39 @@ static gfp_t limit_gfp_mask(gfp_t huge_gfp, gfp_t limit_gfp) >>> #ifdef CONFIG_TRANSPARENT_HUGEPAGE >>> unsigned long shmem_allowable_huge_orders(struct inode *inode, >>> struct vm_area_struct *vma, pgoff_t index, >>> - bool global_huge) >>> + bool shmem_huge_force) >>> { >>> unsigned long mask = READ_ONCE(huge_shmem_orders_always); >>> unsigned long within_size_orders = READ_ONCE(huge_shmem_orders_within_size); >>> - unsigned long vm_flags = vma->vm_flags; >>> + unsigned long vm_flags = vma ? vma->vm_flags : 0; >>> + struct mm_struct *fault_mm = vma ? vma->vm_mm : NULL; >> >> nit: rather than deriving the fault_mm here, I wonder if its cleaner to just >> pass vma to shmem_huge_global_enabled()? shmem_huge_global_enabled() is just >> using it as a guard to access vm_flags, which you can just as easily do by >> testing the vma for non-NULL. And you can access mm flags with vma->vm_mm->flags >> after testing the vma too. > > Make sense to me, and will do in next version. Feel free to add my Acked-by: David Hildenbrand -- Cheers, David / dhildenb