From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A43C4167B for ; Mon, 27 Nov 2023 13:59:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0C826B02D9; Mon, 27 Nov 2023 08:59:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BBC766B02DB; Mon, 27 Nov 2023 08:59:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A846B6B02DF; Mon, 27 Nov 2023 08:59:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 98CEC6B02D9 for ; Mon, 27 Nov 2023 08:59:44 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 70512140238 for ; Mon, 27 Nov 2023 13:59:44 +0000 (UTC) X-FDA: 81503892288.12.0FA3F22 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 125CC8001F for ; Mon, 27 Nov 2023 13:59:41 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ITUnIAA0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701093582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F6iHAQJhJSgIR9+9PmD4GxCuxLQWQlMZEVby058fSFs=; b=vCeL4iF+RWReE/SotDGhwqA3JdpG8Pg8ZdABI5Q9xQdLXqqftrKNoa1ax/wNcA/h3vwfM3 dW1/P/3QEN+cTs3gHI2Gt9IpbixieSSB3yJfzaWY3ljTp5gP1m4XNEzXxt9QpCRYpwmNYT zIKK4w7aF2dadxGIogH5NejTthSTpYM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ITUnIAA0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701093582; a=rsa-sha256; cv=none; b=qiHyqZ+2YAEOAmCcL37aG0j89lmbU4eLe1NebxsVGk4HwQNOR4UKP48X4VCINBYESI+k6F A4A9R/852DnfbzkW0t3fYZyfy2olnUBwRMU/CSffFocmHyprCNxMmRA0Vx0X097xsuydjm 2oyyHtRwQyAMxsqvPmyaNS1ss077KO4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701093581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=F6iHAQJhJSgIR9+9PmD4GxCuxLQWQlMZEVby058fSFs=; b=ITUnIAA019ED9B1EWFXJVyk0QU6RN4I9G3wO4lX135mmd85SuzS2a9sCQ+wnuTSG+IoZBW 3Heu6qGPxCWZZkQxQv/TVCpqePM9vQCx1vBX8bRE2Q07ZOjvRZaFSOVmuYdi+4U2hWJANE uH4okD4ZAf0qdLj/V3toP1wWV9E5Xms= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-A7KlJIUaNBW4d28xQeER6A-1; Mon, 27 Nov 2023 08:59:40 -0500 X-MC-Unique: A7KlJIUaNBW4d28xQeER6A-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40b2c0df444so23245945e9.2 for ; Mon, 27 Nov 2023 05:59:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701093579; x=1701698379; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F6iHAQJhJSgIR9+9PmD4GxCuxLQWQlMZEVby058fSFs=; b=KoXgXEtAVCe/HaesTGQAyWFVL1UBGEkzrxQgsw6f3HtvRtmNg+cOR+O6q/CVkBdBpw 2ngXrqdWyB5TMkZtmKZmB7RbkVZZdrPAPTHT2W0ZXcqgS6QemwQBzeR3Ov3Xs4vIwA7n MmAYYDCr/J0/ljwYbfqCACSRpRhQQQZzxRFZLrdWOGCecCITrp2VkrAHGf0PHmGpf3wD QCtMP+f3uEiwo/tClyfqgT2FE1FeHEcHQzpOZ6wP3B81qT87u2ULh5WzFaY46przP9ug TTohzDJZWqYcnvaeTAnXSrzYsgnu9xeSYBsyS3yM0PRnJOD0MvtMtjnrVtrcHfxjhunC P3LA== X-Gm-Message-State: AOJu0YzwXtEY9ts+53e6wuElX3ckx/gFpLnoklQ6nDTF2sw1317uKd+g iZU18o47w4U0MbHwugz/A/uyPVIZH8V/2GPbmgvHbF0tjdC9kU1EjddGk3CQwSSZiu8GDpyhCBI bHR5dLYZOH5Q= X-Received: by 2002:a05:6000:8a:b0:333:11c:3bfb with SMTP id m10-20020a056000008a00b00333011c3bfbmr1732131wrx.6.1701093578822; Mon, 27 Nov 2023 05:59:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IFlmgU+jFcrR/STk61bMTXs2kG3jybNUVhFmo5dvEGgFWUlZB9Yk4K5ba/n/BHcVMk455t0Zg== X-Received: by 2002:a05:6000:8a:b0:333:11c:3bfb with SMTP id m10-20020a056000008a00b00333011c3bfbmr1732116wrx.6.1701093578472; Mon, 27 Nov 2023 05:59:38 -0800 (PST) Received: from ?IPV6:2003:cb:c745:2a00:d74a:a8c5:20b6:3ec3? (p200300cbc7452a00d74aa8c520b63ec3.dip0.t-ipconnect.de. [2003:cb:c745:2a00:d74a:a8c5:20b6:3ec3]) by smtp.gmail.com with ESMTPSA id t4-20020a0560001a4400b0032d9337e7d1sm12076944wry.11.2023.11.27.05.59.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Nov 2023 05:59:38 -0800 (PST) Message-ID: <1ebb9a53-63ee-430c-ba65-8e48eff6d25c@redhat.com> Date: Mon, 27 Nov 2023 14:59:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH v7 09/10] selftests/mm/cow: Generalize do_run_with_thp() helper To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231122162950.3854897-1-ryan.roberts@arm.com> <20231122162950.3854897-10-ryan.roberts@arm.com> <15c288aa-feab-4d3a-af33-b87481eaffe3@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <15c288aa-feab-4d3a-af33-b87481eaffe3@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 125CC8001F X-Stat-Signature: zdqm3yktqc3ebf5gxpsgxaaq63aqffde X-Rspam-User: X-HE-Tag: 1701093581-562048 X-HE-Meta: U2FsdGVkX1+vS6pHjyw77tRLy6KRSmrJLBP73gZUcJCByiVY8abFmMVNadJ6P7Q3ZUK8NYu8U6f+XrbRRQ4coa+8REqyuqm0M7/8kLKtIvs0I4Ar/xv/eadv2hrOQDrk1ikvCvqFWDzR02CdtyUegDd5AAKb544iVDE+sJnJVEzA2fh3w+IckaDETKXN4OITFFBgEJu/SVxVrnVQX08+Jzed1DIw0EgjuXbxfNaFhgw5Y0HvY781yuYVTGUG7D1w7hmXY8FSI2/rS2cMzoss4k1NVPqXxCTJffuQOUBV9E3KdYq74mFMNKWV58BFvjS73v0CtGmFa08qRFcuUmkkI0BTQLcqOLMjrhZJFMAq4/fI9MBcFE0WQ0Ffq2ZvCZ3zk33aQOju41eSi9nv+scjrevLNc7dTb5CI1c902BRLBM2VctDTX6QPyWPlAasE2x+sWKo/CNButIJOp5wDaDgRQPzgQNZ8FUua6iiYT1ZWJxQ6pkSfmzuptQXEMH0hwSrQuuKVT7YhBSIT3s2ExXyzBHFxEDsguds4Bw71a8ue6Ac3ePJLIlOJFAGmMIctJ/Xazkz4IqEQiNFzTu6yGau/3ioL8geQ8f8bV1YJ4obgbrDmmmiUaUC1tiILKgF/36PhsMTRDdEiYNAq58VSjN4LHf9VJUKFZp18SdQHnaIeS4nunigI5XDVOXPZyf7gMjI70o6nOdtc9OXqsHriwjQmQqINfd2HIJ1F7Sm1YsHC/yo9L7tCbnokUDGeFI2D6szGhzFPIqMncaOL7hnnY0Oz2wShC+0zyhxHwu9aWEVgRAQAR4l6WDh/fLIhljznFziwvr0iMCwsUKdqulegKKPMWgTZlnU5hYpFSBERFB9IXJonCw6yTj2irnEjFmKnS1m5b5/rLHTbnfGhNudkSoDR3eysVBTmm89G2/aVn4yKI9gWxMJl0qgu/sQXE0PansM3JpV7Qnj8BjmxrPJ7wM YOaiTesL T6N7HWDZW1B2SMYbNP48swKn7dhbQeuRYNHAHPuT0EzjN2nKHj5ywAT7jgY9Q5z6S8b1yXvox45nLRziCs3pOb/DEigLNrL5W1Oa14LyIf2R4ESTmJIbpSGwWtkOYPGCXnTwWjN4wZ7trUGH4XPlVJ3u/NmN0Uu4/AgkkFf3P9EC2XCUueJYxdkVcVJsmKHsCMHm9IiEb/T/x9tndZirFNKBdMnaPJsxrO83Z3tmf8nzZ+l5gyon4fFFKauZdvIY6guxdUYX4mgDY9TvejKJnWAuX8o+S9HqO6mkPxQ6/z2ZE3jtvhxtc9Yjp9VjTOTUeLiheIohjpZqs87q9YTKtVPIx7Oe7YXmM6jRRzMvJASO1BDrQfmxXD/jSbbKzp4eG51PytElybskyzRmnjIqlbWGAIHd4azigRDzMu0CMocvCyhlLBIbJ+ZqeysBmGUAYLS4heiK8El+PW9HEVWujzfVSgeh5nhPDqkOTKSK1iVLbPHVLvIlNOsuAxqntYc0F9GGzndzaWzK5Erz3PkNp0ZYX7poHsPM7HMvl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >>> +    pmdsize = read_pmd_pagesize(); >>> +    if (pmdsize) >>> +        ksft_print_msg("[INFO] detected PMD-mapped THP size: %zu KiB\n", >> >> Maybe simply: "detected PMD size". Zes, we read it via the THP interface, but >> that shouldn't matter much. > > Err, just want to clarify what you are suggesting. With the current patch you > will see something like: Not with this patch, but with the other ones, yes :) > > [INFO] detected PMD-mapped THP size: 2048 KiB > [INFO] detected small-sized THP size: 64 KiB > [INFO] detected small-sized THP size: 128 KiB > ... > [INFO] detected small-sized THP size: 1024 KiB > > > Are you suggesting something like this: > > [INFO] detected PMD size: 2048 KiB > [INFO] detected THP size: 64 KiB > [INFO] detected THP size: 128 KiB > ... > [INFO] detected THP size: 2048 KiB > Yes. If you'd detect that 2M is actually disabled, you could still log the PMD size only. So for this patch only as a preparation [INFO] detected PMD size: 2048 KiB [INFO] detected THP size: 2048 KiB Just a thought. -- Cheers, David / dhildenb