From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04217C4338F for ; Wed, 25 Aug 2021 08:38:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 863D061176 for ; Wed, 25 Aug 2021 08:38:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 863D061176 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0FBBA6B006C; Wed, 25 Aug 2021 04:38:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D38F8D0002; Wed, 25 Aug 2021 04:38:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDDB48D0001; Wed, 25 Aug 2021 04:38:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id D5C0A6B006C for ; Wed, 25 Aug 2021 04:38:27 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6B3FF180255BB for ; Wed, 25 Aug 2021 08:38:27 +0000 (UTC) X-FDA: 78512951454.04.D952FB7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf07.hostedemail.com (Postfix) with ESMTP id F024E10000B9 for ; Wed, 25 Aug 2021 08:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629880706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WbFTSPWjWmdzFcIoM8QePiF1gcVWuKexFnmCVr4uGQE=; b=bIzSmrx2FO6UQ0vXhZyInZgIdhg5SP2ww6ThG7BgoFHhQm7Mu31yUsbxbiXgtWB/nroet8 y1R/6n8luPHWpCnrCQAWJhwfbC1YqvBmzqPWdgiqV81W+d0CoYRxOGAdciBVuZg2f24KW6 3N7n2j7XThu1dSqMVERChKosx/a+Y64= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-351-gQTVUxoDOQm9tVaFDmE3eA-1; Wed, 25 Aug 2021 04:38:25 -0400 X-MC-Unique: gQTVUxoDOQm9tVaFDmE3eA-1 Received: by mail-wm1-f69.google.com with SMTP id k5-20020a7bc3050000b02901e081f69d80so5034404wmj.8 for ; Wed, 25 Aug 2021 01:38:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=WbFTSPWjWmdzFcIoM8QePiF1gcVWuKexFnmCVr4uGQE=; b=QQDwWcloSrjhstQLNFcyhJBqCg/BE0dZ36jV5Y1ZJHS1WeNMYMNn2xzfi/fN4EK0bg NPYJsK28PRPTrDYwyxvvztORpI2kugDZJtbA0NTn2pkf0+gTdu2eA88296u8or+xh6Hl BWGtwoggHiFpXjl26gWwIRz6Zj/L3/SH8UlUfsZivDBsUfckSAGHcFKPE235P0TpGMIi OYCFjsBwefEskTca04y+5flRnSW6+/I6rysMZ4fq7vugioWIq7zP6wElx8y1FwCAyJXK s/J4TUTtAuS6x1vJ+s+Ya3l541KXilx7ycwCkYa4s3uxAhx698LdW8Wjv0rRDgTvaKlR GxdA== X-Gm-Message-State: AOAM530eJtRMX8mvQuQmppykDgetR3GTPcQYIwjhxIIuVBElWvTJu3LJ OgsL+8vuInsIzVHxkVAGc5KIaD58pNUrh2qrsxCd8phb9Yq+D1lIr9KE2U3rz2Q1PFFSVdOhLhM SdOmlmlJE/sc= X-Received: by 2002:a5d:638d:: with SMTP id p13mr18169065wru.223.1629880704168; Wed, 25 Aug 2021 01:38:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcxTSu+f6NvOxxXz2pL83gdFnm8n+Qoid7x4qixIQ0UMcFDx3pvvfVfrHZGLq8X6L0hbzG7Q== X-Received: by 2002:a5d:638d:: with SMTP id p13mr18169059wru.223.1629880704006; Wed, 25 Aug 2021 01:38:24 -0700 (PDT) Received: from [192.168.3.132] (p4ff23d6b.dip0.t-ipconnect.de. [79.242.61.107]) by smtp.gmail.com with ESMTPSA id 17sm4555894wmj.20.2021.08.25.01.38.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Aug 2021 01:38:23 -0700 (PDT) To: Dave Hansen , Mike Rapoport , linux-mm@kvack.org Cc: Andrew Morton , Andy Lutomirski , Dave Hansen , Ira Weiny , Kees Cook , Mike Rapoport , Peter Zijlstra , Rick Edgecombe , Vlastimil Babka , x86@kernel.org, linux-kernel@vger.kernel.org References: <20210823132513.15836-1-rppt@kernel.org> <20210823132513.15836-5-rppt@kernel.org> <1cccc2b6-8b5b-4aee-483d-f10e64a248a5@intel.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [RFC PATCH 4/4] x86/mm: write protect (most) page tables Message-ID: <1ec0d015-90fa-e2f4-c9ef-e63ec43a46b3@redhat.com> Date: Wed, 25 Aug 2021 10:38:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1cccc2b6-8b5b-4aee-483d-f10e64a248a5@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Queue-Id: F024E10000B9 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bIzSmrx2; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf07.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam01 X-Stat-Signature: 49f8e6ruj7z5ooy8mb6f8txgdojq563s X-HE-Tag: 1629880706-829383 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.08.21 01:50, Dave Hansen wrote: > On 8/23/21 6:25 AM, Mike Rapoport wrote: >> void ___pte_free_tlb(struct mmu_gather *tlb, struct page *pte) >> { >> + enable_pgtable_write(page_address(pte)); >> pgtable_pte_page_dtor(pte); >> paravirt_release_pte(page_to_pfn(pte)); >> paravirt_tlb_remove_table(tlb, pte); >> @@ -69,6 +73,7 @@ void ___pmd_free_tlb(struct mmu_gather *tlb, pmd_t *= pmd) >> #ifdef CONFIG_X86_PAE >> tlb->need_flush_all =3D 1; >> #endif >> + enable_pgtable_write(pmd); >> pgtable_pmd_page_dtor(page); >> paravirt_tlb_remove_table(tlb, page); >> } >=20 > I would expected this to have leveraged the pte_offset_map/unmap() code > to enable/disable write access. Granted, it would enable write access > even when only a read is needed, but that could be trivially fixed with > having a variant like: For write access you actually want pte_offset_map_locked(), but it's=20 also used for stable read access sometimes (exclude any writers). >=20 > pte_offset_map_write() > pte_offset_unmap_write() >=20 > in addition to the existing (presumably read-only) versions: >=20 > pte_offset_map() > pte_offset_unmap() These should mostly only be read access, you'd need other ways of making=20 sure nobody else messes with that entry. I think it even holds for=20 khugepaged collapsing code. I find these hidden PMD entry modifications (e.g., without holding the=20 PMD lock) deep down in arch code quite concerning. Read: horribly ugly=20 and a nightmare to debug. --=20 Thanks, David / dhildenb