From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA30DCD342E for ; Tue, 3 Sep 2024 08:01:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E7678D0146; Tue, 3 Sep 2024 04:01:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 296178D013C; Tue, 3 Sep 2024 04:01:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15E5A8D0146; Tue, 3 Sep 2024 04:01:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EC1E58D013C for ; Tue, 3 Sep 2024 04:01:39 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5E92E40447 for ; Tue, 3 Sep 2024 08:01:39 +0000 (UTC) X-FDA: 82522682718.23.B300E37 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf30.hostedemail.com (Postfix) with ESMTP id 66A0380027 for ; Tue, 3 Sep 2024 08:01:36 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GDaDDbgn; spf=pass (imf30.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725350449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xDeynKssdN1XfK/xQnAB2rnokmkSXiG53xB8wusPu+Y=; b=A+kaYgfC2TYSxImJfutD7HUPgeLhvtjac8lyG+iL7Kt48htzs5kiHuq03k5NYNIdNDamwV Cjn9UoIF5HPcf8LFZ03BSBf2eo37vDJR6vmhSvvrV6+PqMyvZT6D++Tse8a/Qf/oeVqnKC msidt9R9/8uu1rtRiiooRDic7xILy/o= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GDaDDbgn; spf=pass (imf30.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725350449; a=rsa-sha256; cv=none; b=YMriP+dJrXSqzASMByjwELLu3JHEQA06BvuCKS7sSyWtXWhEb+FkBOF0qr0hkYRbT++d9U alDoGhrpe6fpCgrlo/f4QKkLiBmU8/BXVREFK9WpDFORLDpQd4wsHhOGN7vnT6ZARKMz6I CTpAkQIeFX5z/UEXEmyIdR8edulZZBc= Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-7176645e501so864939b3a.1 for ; Tue, 03 Sep 2024 01:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725350495; x=1725955295; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xDeynKssdN1XfK/xQnAB2rnokmkSXiG53xB8wusPu+Y=; b=GDaDDbgnhRGzl6ljWz25if96B02hHHsWar2O7NrhO/ZiDGtw5OQ5yK8XATHn6125pW jPl5oQsTH8FejUoAwM6ft0/rUGiAokDmsnL4sA20Ic2RxH6Kfl1w70MmdQPS9ctHE8oI zs8issmXbmUiFWZshRJk6f8usZ2W+cZ1F0F50ClfH3G3cF8Gx86yLC4Yos2JO7UbxRf2 y3VUUtyzK/7h8I37x3Whpngi8zzN6CqmIoCsstgw7Zl7CUk5xnQPbC73oSdmgwAGKcxh IoFcFptXO6jex41/K6KurUjmB8DLa+bgBGjMDtIP6OihvkOybKXjHDWQukieg0qNMyUa fx5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725350495; x=1725955295; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xDeynKssdN1XfK/xQnAB2rnokmkSXiG53xB8wusPu+Y=; b=cQbUabHYHBzf0pfn9vm6hOX24ZfmAo9DMHo0Eo8RJ/KAaDSCigMa47QKGQx0Fj+w96 8DC22HXX52vihbKpJsHsvPWp4mrtrJU4dhzFlkzD5OfTc+SqcSI58PU5/ygVbCgDYOFF qu7XFPbhmNlzuzllrOSGODmNfv/2h6R/v3/7J8di+g77tIJ/+AKgsvhmwAIKBCPEm3zT kSGv49EiF1aKpUuCI8Sk3myQbFudBKJe8TPQP1sQID8T+TgS5R4fZgj1EBxMV33+g5Ug oqXFFLMLN2gTa7ve96ESaCkkeuLxXrFuK5HMfqLnmP51wP0D0agMxzzHuLO56ANtMc4l QlGg== X-Forwarded-Encrypted: i=1; AJvYcCW+XVNAwcJmwG+sxXAkSdeCb0BKE7g+N2X8NYSviLzcitQsq6U5FyIqZ4EozRWI6SlffsiI4Xd5og==@kvack.org X-Gm-Message-State: AOJu0YxMIQSBjU/iIZVkMvOif1frEaUPK/ywNypBZPRCaK+r56wYV0Wb 8gJaSHRhwXSlgkL6EAqhbuoKAABSC1CALJb+bo8eOFjxcRuZN+JQ X-Google-Smtp-Source: AGHT+IHtSPGhKPKwuY26xN3mhxwFZhhUm++ETeppT2ZLuysOpkGc03XxPvITNNRc19bO3k39mZU0fg== X-Received: by 2002:a05:6a21:3213:b0:1c4:a8a6:a85f with SMTP id adf61e73a8af0-1ced62a2b24mr8148849637.30.1725350494668; Tue, 03 Sep 2024 01:01:34 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-715e55a5c71sm7953269b3a.79.2024.09.03.01.01.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Sep 2024 01:01:34 -0700 (PDT) Message-ID: <1ec2f951-8ce8-485a-9f51-e3b9f4eba73e@gmail.com> Date: Tue, 3 Sep 2024 16:01:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 00/21] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool To: Sergey Senozhatsky Cc: alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com References: <20240902072136.578720-1-alexs@kernel.org> <20240903033558.GC9738@google.com> <20240903034542.GD9738@google.com> Content-Language: en-US From: Alex Shi In-Reply-To: <20240903034542.GD9738@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 66A0380027 X-Stat-Signature: 1bwphxueptyi9h8abuyif56aoxxcbmc5 X-HE-Tag: 1725350496-48619 X-HE-Meta: U2FsdGVkX18axJAqlZn7D/8TZ2NmskbMqTkr8iYCSrDUzTOop/KbZSherAsg6OwcJnBI4dx4KCoPicPaIHrj9XJ56FVuCWwNJPlCZsiX4A6YE5DQ7HEorbLLWBZTSe8qcCIbJVvLQmweIHISsW66jca6RxhBVeuEc4ojVQMAX5ARIdzuTQFoOPhTPCAQbikOtYGkH+Vcho9hIJmSmRThCShuavhTXUZokW7jFFFrgHucGYZO6YYlCe7VHSzv2tog+H5nH+pF1MKeZTkKs3SzQ35NHr55bblPVIGWH6ZaRd9tgNpeDYlNFEqPPHvlAcZajjjojDyyc9frPCpzLwjWyKfcSUT7sbmxdNWkTa3QyEIcoc/kZo8EjujO5syNhE1KwhLzhNLnlW5oGWC65P4R+Or6GzDhPsDH9gpX4kXHylXHPWY7I/5n4TZaRGN3RV4dasjsTaGGMtBqmi9PB7wm/eiDF/IR5668H/+qPlOlxI8LLq+tcWdfayJ6oUNHpYODpa9UBExcyhHl1zQykSjbDKlfDiY7CZqbUqOBBa2Q9NWNt1f44FRBeoY7jLHAMPnjxfBmm9vReJVCP6LBuhyLROMlDf9/6qbnfgFo8HPtjnZRYCxfgxA10g4TdAf3CygeA+4Jd6Ze61XKpTsrJsjOelgYJ9sk2Za3jRQyHYCDefxbnO90iThvfWMnlCGuzURx59SbaRzLTMouvcJqA1dqEmwoMLubgmPUbMNR2zwxnO96uq8sMJywV0fke3RyGE8CiHJUgi0BNyb5dokbQpP519L7U3XAvXFAM+uWFkZDpoNUz9tezuP4vps8/WtjZKWQooY31PrtlTQHzvXKlprXrtR5tUZuEW4f0KQFCC71wF6XTXqpD0ET4qS6QnYd2L0FkP+KLo8P7jz5Jk/z/ZCqFZsr6/UGZv7ojrMkWjG/O5ebYBpJLqncs8oZW57zY4QT0aqhFQ/9uk3YnVrSXZM Hq5CB1lJ cr6v6PcxI7odhVZx18usRnJeAWCTAXYgVo9pMdUM8vQOUEH9+LEc4oqTVTQNrImYsuU0zUr4PTKhj75s1JxFSvoaRZOkwlDGv4wuRfKVqCu+MKvY/+gePlgoLp8Q8Zip35NKRY20s9SIPRxdiDLdt6hr8Xl+JaTv5ZRYR+z9Avr4KrLJtscYDmnf2NKE6wVrXYXcbwM/BSPej7/TaInIeblpOydEFQ788V/0xGwpzCaUEribx+Ccqc/sqKo64VXIHUZIVYngtyvjY58YrkgJWZb2NrK9ob0cUcHMuUUlNBNqxIDK/AOBUVjZ2IbFCRBemS9xMwTytGIgP9abmZkCxLUwGr49YNAHINhOUseYmKMzQvDFcch8S5aEaHXlKBzvUvXJOfl3VY0RSRC8wIqFwl51gsLeDEB7+QDlir4haNFqbH6by+H+9sjTB3el68326Y8u8PFWAEzYIuAR8MbRymztneHD3oqWkXyrnCJbbDHs33UJW7kK286Trtw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/3/24 11:45 AM, Sergey Senozhatsky wrote: > On (24/09/03 12:35), Sergey Senozhatsky wrote: >> On (24/09/02 15:21), alexs@kernel.org wrote: >>> The descriptor still overlays the struct page; nothing has changed >>> in that regard. >>> [..] >>> This patachset does not increase the descriptor size nor introduce any >>> functional changes, and could save about 122Kbytes zsmalloc.o size. >> >> Is this number accurate? Where does such a large saving come from? Hi Sergey, Thanks for asking, I collected some data on Aug 2, before the patchset, zsmalloc.o is 1200960 bytes, after patched, it's 1076144 bytes. At that time it's saved about 124KB, about 10%, with some debug option enabled. Just test again with x86defconfig + ZSMALLOC + ZSMALLOC_STAT, on mm-unstable tree, zsmalloc.o reduces to 34960 bytes from 37328 bytes, that's 6.3% saved. The bloat-o-meter show in machine: $ ./scripts/bloat-o-meter x86def/mm/zsmalloc.o x86def/mm/zsmalloc-patched.o add/remove: 1/1 grow/shrink: 1/5 up/down: 100/-1068 (-968) Function old new delta create_zpdesc_chain - 92 +92 zs_compact 2352 2360 +8 zs_malloc 1334 1277 -57 __free_zspage 291 223 -68 free_zspage 289 211 -78 create_page_chain 95 - -95 zs_page_migrate 950 807 -143 async_free_zspage 1252 625 -627 Total: Before=11868, After=10900, chg -8.16% > > ./scripts/bloat-o-meter mm/zsmalloc.o-base mm/zsmalloc.o-patched > add/remove: 0/0 grow/shrink: 2/6 up/down: 7/-843 (-836) > Function old new delta > obj_free 211 215 +4 > zs_unmap_object 568 571 +3 > zs_map_object 661 633 -28 > SetZsPageMovable 135 86 -49 > free_zspage 310 253 -57 > __free_zspage 284 226 -58 > zs_page_migrate 1304 1136 -168 > async_free_zspage 1099 616 -483 Many thanks for detailed data here! Thanks Alex