From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F1D9D2A520 for ; Wed, 16 Oct 2024 15:16:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 179536B0088; Wed, 16 Oct 2024 11:16:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1291A6B008A; Wed, 16 Oct 2024 11:16:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0BFB6B008C; Wed, 16 Oct 2024 11:16:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D2A7E6B0088 for ; Wed, 16 Oct 2024 11:16:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 38783406E9 for ; Wed, 16 Oct 2024 15:16:44 +0000 (UTC) X-FDA: 82679817696.28.DE0604C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 4454D40010 for ; Wed, 16 Oct 2024 15:16:39 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LtjlC2zr; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729091760; a=rsa-sha256; cv=none; b=OQp1lcSFwtiwx21/JJyGDlxtKh7hIDw9+0R/HNU35ijLsf6JCwjm1EUh4YW4rruYuEDFBC OsFKZF88RlLVoNuur4apegiLpU2VIMVrBSGTA2F4KDI1EAgR5jdW3fYkAE6ZrBaB5bo5cq iJ5b3G0p6qZhDMHuOqcfUMvEjEFxSc4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LtjlC2zr; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729091760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rckCI6BcQdAYpz3FvS5gzBv3y2Neehx7nzPLfaUCfW4=; b=nqdPw8+9Po++9OGsiHMsZQQkQIcma2NfTs67kI+cHQNcVkrQ4C/JrdFQt7GRFVfUVVcXvl 4rIBlIi/aGKzB/i40AV6Tt+RUBqfxClWiB6zVO9F3AGRiXLd97Nz6xmkPtcQb7yAT91Tae gI2VBIsL0BFdMLKMAPi5uHn12BcjhrA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729091807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rckCI6BcQdAYpz3FvS5gzBv3y2Neehx7nzPLfaUCfW4=; b=LtjlC2zrAU6iVSD3uEezx0ioMthelBNFW7dpra0h9JvhPQBaSuG7LWWKt6MRVkBfSnLHOT uNfniTw3fdQ6/LBsekewgB7RUpdS3e7U4qtthu8jyBBrjmzA14nHnAHS9A+Mgw/rtT+gP0 XPGJ0q8n+DDRM4jdCVhX1LqvbKsf/os= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-4GTiFtwpMse0HrDqO2ufUw-1; Wed, 16 Oct 2024 11:16:46 -0400 X-MC-Unique: 4GTiFtwpMse0HrDqO2ufUw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43154a0886bso3539055e9.0 for ; Wed, 16 Oct 2024 08:16:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729091805; x=1729696605; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rckCI6BcQdAYpz3FvS5gzBv3y2Neehx7nzPLfaUCfW4=; b=nEctBCQoXSwQfntVGO/pcqoOjnO0YAYf2IaA9C0uuM0HclgBF0B+TdP4id/Cf67UDt RbJB3XAbLQfj6Pij5fOCwkWGA7opY67Ge5tq4MsKE3Fb+XtKdzmsvw7WDigTAySmPzLo PZl0XWVvTFTI8Z7GkIvN/KT74Nt7SmGUA5OtXBuwxikK9+NHLGq4HHE8jOGMwlFYauPc 1hd/Sogmlrt3DZJTuscLTCbFoXmXCjqeMWGWCgVEmKnnOhMbyv9XskQYjY5nXuH4lWhG tUcqYRC7I2UnlFWhNccjfT+PV+UiZWtUwXCJYtfspVRuPtHSX07uwOfzu2nEQCtfj7ha 6TbQ== X-Forwarded-Encrypted: i=1; AJvYcCVlzDwuNBsyHz34eu1VwEkfC2eZMo1VQjtaZF/sO1pLYyrCjvypNsjW+oEFZWfwSOBkHVHNE842vw==@kvack.org X-Gm-Message-State: AOJu0YwFz5CYflEpEW7nYCPkmUosObXZSX4vUcklJIyLrI50aQDxO89A mDlRZjgFwPtMI/gZtLWlrjfkykLgUhhqOxceZfdoU9/yDCaqQpr1ak+/x1lgRb0mAacA7fNnOvQ HoDjWpWhr1xYUpqozbqXyjmDZbnzrdoOYIBUjq6kAiy0CwqUv X-Received: by 2002:a05:600c:444f:b0:42f:8515:e479 with SMTP id 5b1f17b1804b1-431255d4e6cmr114950695e9.4.1729091804898; Wed, 16 Oct 2024 08:16:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhhGcNrxVmkNJEtywMCqvJOFcBc8Fpq5HqvDzLlA5aNRCPuGv5s1RDNR37gx+mmV9Y0mGGVw== X-Received: by 2002:a05:600c:444f:b0:42f:8515:e479 with SMTP id 5b1f17b1804b1-431255d4e6cmr114950495e9.4.1729091804477; Wed, 16 Oct 2024 08:16:44 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:d000:3a9:de5c:9ae6:ccb3? (p200300cbc74bd00003a9de5c9ae6ccb3.dip0.t-ipconnect.de. [2003:cb:c74b:d000:3a9:de5c:9ae6:ccb3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4315069032asm24478235e9.0.2024.10.16.08.16.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2024 08:16:44 -0700 (PDT) Message-ID: <1fd0dae8-b04a-42b9-9d6f-32100610ef76@redhat.com> Date: Wed, 16 Oct 2024 17:16:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 00/57] Boot-time page size selection for arm64 To: Ryan Roberts , Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Greg Marsden , Ivan Ivanov , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Will Deacon , Donald Dutile Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241014105514.3206191-1-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241014105514.3206191-1-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 4454D40010 X-Rspamd-Server: rspam01 X-Stat-Signature: 1ybcdobmzobgygcxw3osk6ca5na55m65 X-HE-Tag: 1729091799-683071 X-HE-Meta: U2FsdGVkX1+4B+k/Sb0KUR/8mVUk/Pu6bKucYT/Dk8jypQEYXK40MljUhAjDLzKCg5//UwGdBsmep3pni1z3fenOdNFF+2WMIVCdNJsi/8j7Rr8F/k3SbeYwc/3rJhdMoI+ECtBIYBw0R3dRv1+f7jJLAwZjIWoAjfIoOMCfzfp+WT26++SKJl6MYPhmIYi6+l2bzpqStr28kHeTijeMXcd0t/gglAsDLWtnuit5K8SZN1BKuVSgOMQfb2vW+ZU85ePv20hz+6h73Q4vhJCRllXHOFiUPNwX0xnEc8ilQdtpoRhmVLsQbqml2DB3aSBL+Q9l1f13U/m2DZoKjJ4EuzCxAvNrTWSn4YkPLIJ7iiMP9CGTD9TCeCEbVaX1BneH+gi4mwl81BCKcwDQjlfxXyXDp9NMGhI6ljTwcJqiiNI9DmZqVam9xb43R6qvupoIO9/ePGHfBQ5SKfVdTz/eKKUUf/0ottJBfjR06rQLTe+tiN/teuSJ72x74X7R6+JvPDN9x35x2LH6675iIt7AjWcvW6eN/SELapgnt7WgCNxp5u1d0DSwuw4QFH6yNst75QVTvzZUt09wh5pR8Ea0/gz+0JaYfBpwsczhlTCYTQLSL/eCbiulnm2MmSvO+wJjH/LI0QERHwpVK+Yb4oekdkUOuYWXCrAKcZcvfjRQlzcj/JUnGCq53bVr2f1ECA4Dc2yuqpoSgyU0+t8ruUeHlZ5hdYvd4SmC4aLuV6TAumhaqxl01c5q29UyIhFsrm/iAKaBYBVIxmF4OeOvSDiERCEDc/LnkehFP7KscRLfySykc1ljqBf3kMhGZuOVCWbCdtyobvyHRMa9gitqun7s8jXKB2fpdXa1i8v8zzbJrjbnyd+SLnutws7elkqTRRI/FyEIixQDJBvi9xRvHJI7rAlSnWeKCgogv6mzWFy7JGWhUwWuXsC540eCg5N+PPNMabsaZbLq7FJq/MPdNak fCkQ/veq RnU3c4jkuKkL32xsKIv9me/nOo22ZybprTz1wTroMKDKr2MjlAkdyWuQ03I0p13WVMtMXgroTL84MZcS08QKEi3vfrsvENjqh2KaTv5zmwfJApDRxFzGvC67FEMZxDhjHbAJBPtzpbKirQNJgHrOs/SbRNIPfVkOkLA7r+6yW5rDYmTAmy/c5N/SILHpuzYc2NbRxwgSy1mSJaXaJZPrFTwV9NsQy9o9Y74O0UlLr5bLe5Ve0Ml0esnkXc2BqYVv+110sr4x3lNketCt4Z2Un73deuhZkNidIQM3u/t7GGn15k0DqITxcKUMFv1zPUwtUpRFNUIrrvAIOukD9yrUzn3wEnP/RHYxjIiiJF4prFP9D8LdD8ATIIOC9NXoZWXdrwdZuy0hpCbaNZCYMcoawCycthg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Performance Testing > =================== > > I've run some limited performance benchmarks: > > First, a real-world benchmark that causes a lot of page table manipulation (and > therefore we would expect to see regression here if we are going to see it > anywhere); kernel compilation. It barely registers a change. Values are times, > so smaller is better. All relative to base-4k: > > | | kern | kern | user | user | real | real | > | config | mean | stdev | mean | stdev | mean | stdev | > |-------------|---------|---------|---------|---------|---------|---------| > | base-4k | 0.0% | 1.1% | 0.0% | 0.3% | 0.0% | 0.3% | > | compile-4k | -0.2% | 1.1% | -0.2% | 0.3% | -0.1% | 0.3% | > | boot-4k | 0.1% | 1.0% | -0.3% | 0.2% | -0.2% | 0.2% | > > The Speedometer JavaScript benchmark also shows no change. Values are runs per > min, so bigger is better. All relative to base-4k: > > | config | mean | stdev | > |-------------|---------|---------| > | base-4k | 0.0% | 0.8% | > | compile-4k | 0.4% | 0.8% | > | boot-4k | 0.0% | 0.9% | > > Finally, I've run some microbenchmarks known to stress page table manipulations > (originally from David Hildenbrand). The fork test maps/allocs 1G of anon > memory, then measures the cost of fork(). The munmap test maps/allocs 1G of anon > memory then measures the cost of munmap()ing it. The fork test is known to be > extremely sensitive to any changes that cause instructions to be aligned > differently in cachelines. When using this test for other changes, I've seen > double digit regressions for the slightest thing, so 12% regression on this test > is actually fairly good. This likely represents the extreme worst case for > regressions that will be observed across other microbenchmarks (famous last > words). Values are times, so smaller is better. All relative to base-4k: > ... and here I am, worrying about much smaller degradation in these micro-benchmark ;) You're right, these are pure micro-benchmarks, and while 12% does sound like "much", even stupid compiler code movement can result in such changes in the fork() micro benchmark. So I think this is just fine, and actually "surprisingly" small. And, there is even a way to statically compile a page size and not worry about that at all. As discussed ahead of times, I consider this change very valuable. In RHEL, the biggest issue is actually the test matrix, that cannot really be reduced significantly ... but it will make shipping/packaging easier. CCing Don, who did the separate 64k RHEL flavor kernel. -- Cheers, David / dhildenb