From: John Hubbard <jhubbard@nvidia.com>
To: Alistair Popple <apopple@nvidia.com>,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: david@redhat.com, osalvador@suse.de, jgg@ziepe.ca,
peterx@redhat.com, linux-kernel@vger.kernel.org,
dan.j.williams@intel.com, Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCH v2 1/2] mm/gup: Remove dead pgmap refcounting code
Date: Fri, 5 Sep 2025 20:27:00 -0700 [thread overview]
Message-ID: <1ffb22b9-98e2-4073-8399-217f4ed4d9d9@nvidia.com> (raw)
In-Reply-To: <5f3b6bf9-1762-48b7-bc36-705055c99ce8@nvidia.com>
On 9/5/25 5:56 PM, John Hubbard wrote:
...> Maybe I'll post a quick follow-up, in fact, to remove page_mask
> as well. No need to pass that around all over the place, I think
> it can instead be computed by the single place that actually
> consumes it.
>
Almost, but not quite. The problem is in the -EEXIST return code
case for follow_page_mask(). In that case, we also need folio
size (PMD, PUD, or normal) to be returned. The page_mask argument
does that now, and as long as we are in C, it's awkward to do
anything else.
oh well.
thanks,
--
John Hubbard
prev parent reply other threads:[~2025-09-06 3:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 22:59 [PATCH v2 1/2] mm/gup: Remove dead pgmap refcounting code Alistair Popple
2025-09-03 22:59 ` [PATCH v2 2/2] mm/memremap: Remove unused get_dev_pagemap() parameter Alistair Popple
2025-09-06 0:56 ` [PATCH v2 1/2] mm/gup: Remove dead pgmap refcounting code John Hubbard
2025-09-06 3:27 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ffb22b9-98e2-4073-8399-217f4ed4d9d9@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox