Re: [patch] take 2 Re: PG_swap_entry bug in recent kernels

Rik van Riel
2000-04-07T11:29:23Z

On Fri, 7 Apr 2000, Andrea Arcangeli wrote:

> spin_unlock(&pagecache_lock);
> __delete_from_swap_cache(page);
> + /* the page is local to us now */
> + page->flags &= ~(1UL << PG_swap_entry);
> goto made_inode_progress;
> }

Please use the clear_bit() macro for this, the code is
unreadable enough in its current state...

cheers,

Rik
--
The Internet is not a network of computers. It is a network
of people. That is its real strength.

Wanna talk about the kernel? irc.openprojects.net / #kernelnewbies
http://www.conectiva.com/ http://www.surriel.com/