RE: [PATCH] Recent VM fiasco - fixed

Jones D (ISaCS)
2000-05-11T11:26:37Z

> There probably are some good bits in the classzone patch, but
> it also backs out bugfixes for bugs which have been proven to
> exist and fixed by those fixes. ;(
>
> It would be nice if Andrea could separate the good bits from
> the bad bits and make a somewhat cleaner patch...

As I've been playing with invalidate_inode_pages for the last few
days, this section of Andrea's classzone diff caught my eye.

I noticed that in Andrea's version, if a page is locked, then it is just
ignored, and never freed. He reduced the complexity of the function, and
sped it up immeasuarably, but aparently at the expense of leaking pages.
I've not looked at the rest of the patch, so my judgement is on the basis
of this section alone.

Andrea, for an improved version of that function see the patch I sent
yesterday.

d.