RE: [PATCH] Recent VM fiasco - fixed

Andrea Arcangeli
2000-05-12T07:50:54Z

On Thu, 11 May 2000, Jones D (ISaCS) wrote:

>As I've been playing with invalidate_inode_pages for the last few
>days, this section of Andrea's classzone diff caught my eye.
>
>I noticed that in Andrea's version, if a page is locked, then it is just
>ignored, and never freed. He reduced the complexity of the function, and

Note that the official kernel clearly ignores it too so I'm not
reinserting any bug there but only avoiding dropping performance for no
good reason and that's why I intentionally backed out such a recent
change.

To avoiding ignoring it you should wait_on_page() (you have no other way)
and according to Trond we can't do that because the caller doesn't handle
a blocking function.

Your patch ignores locked pages too from within
invalidate_inode_pages() as far I can tell.

Andrea