Re: [CFT][PATCH] ext2 directories in pagecache

Alexander Viro
2000-09-27T09:22:35Z

On Wed, 27 Sep 2000, Ingo Molnar wrote:

>
> On Wed, 27 Sep 2000, Marko Kreen wrote:
>
> > > Why?
> > >
> > > > + } else if (de->name[2])
> > >
> > Sorry, I had a hard day and I should have gone to sleep already...
>
> hey, you made Alexander notice an endianness bug so it was ok :-)

Definitely. Usually "it looks fishy" feeling should be trusted - if code
is non-obvious it's more likely to contain bugs.

How it was? "The goal is to write clear code, not clever code". And right
now dir.c in the patch is not clear enough - better than the corresponding
code in the tree (esp. in ext2_readdir()), but still needs cleaning up.

ObFsck: router in the $ORKPLACE apparently deciding that it's a good time
to shit itself and external SCSI on one of the home boxen joining the
fun. Sheesh...